Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

interpret/memory: explain why we check is_thread_local_static #119257

Merged
merged 1 commit into from
Dec 24, 2023

Conversation

RalfJung
Copy link
Member

No description provided.

@rustbot
Copy link
Collaborator

rustbot commented Dec 23, 2023

r? @petrochenkov

(rustbot has picked a reviewer for you, use r? to override)

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Dec 23, 2023
@rustbot
Copy link
Collaborator

rustbot commented Dec 23, 2023

Some changes occurred to the CTFE / Miri engine

cc @rust-lang/miri

@petrochenkov
Copy link
Contributor

@bors r+ rollup

@bors
Copy link
Contributor

bors commented Dec 23, 2023

📌 Commit c83bcbb has been approved by petrochenkov

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Dec 23, 2023
bors added a commit to rust-lang-ci/rust that referenced this pull request Dec 24, 2023
…iaskrgr

Rollup of 3 pull requests

Successful merges:

 - rust-lang#119165 (improve container runner script)
 - rust-lang#119205 (fix minor mistake in comments describing VecDeque resizing)
 - rust-lang#119257 (interpret/memory: explain why we check is_thread_local_static)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 511eb0a into rust-lang:master Dec 24, 2023
11 checks passed
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request Dec 24, 2023
Rollup merge of rust-lang#119257 - RalfJung:tls-comments, r=petrochenkov

interpret/memory: explain why we check is_thread_local_static
@rustbot rustbot added this to the 1.77.0 milestone Dec 24, 2023
@RalfJung RalfJung deleted the tls-comments branch December 24, 2023 08:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants