Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

stabilize file_create_new #119153

Merged
merged 1 commit into from
Dec 23, 2023
Merged

stabilize file_create_new #119153

merged 1 commit into from
Dec 23, 2023

Conversation

rursprung
Copy link
Contributor

closes #105135

@rustbot
Copy link
Collaborator

rustbot commented Dec 20, 2023

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @thomcc (or someone else) soon.

Please see the contribution instructions for more information. Namely, in order to ensure the minimum review times lag, PR authors and assigned reviewers should ensure that the review label (S-waiting-on-review and S-waiting-on-author) stays updated, invoking these commands when appropriate:

  • @rustbot author: the review is finished, PR author should check the comments and take action accordingly
  • @rustbot review: the author is ready for a review, this PR will be queued again in the reviewer's queue

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Dec 20, 2023
@rursprung
Copy link
Contributor Author

@rustbot modify labels: +T-libs-api

note: i found a reference to this as well in this place, but i'm not sure what to do with it since it seems to be generated code (based on the path) and i didn't see what is generating it:

rust/src/tools/rust-analyzer/crates/ide-db/src/generated/lints.rs

Lines 4703 to 4713 in 5810dee

Lint {
label: "file_create_new",
description: r##"# `file_create_new`
The tracking issue for this feature is: [#105135]
[#105135]: https://github.com/rust-lang/rust/issues/105135
------------------------
"##,
},

@rustbot rustbot added the T-libs-api Relevant to the library API team, which will review and decide on the PR/issue. label Dec 20, 2023
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@rursprung rursprung marked this pull request as draft December 20, 2023 07:40
@rursprung rursprung marked this pull request as ready for review December 20, 2023 08:38
@Noratrieb
Copy link
Member

This file is part of rust-analyzer, I think they regenerate it on syncs or whatever. Nothing you need to care about.

@thomcc
Copy link
Member

thomcc commented Dec 23, 2023

I'm on vacation currently. But this is libs-api anyway, and needs an FCP.

r? @rust-lang/libs-api

@rustbot rustbot assigned Amanieu and unassigned thomcc Dec 23, 2023
@dtolnay dtolnay assigned dtolnay and unassigned Amanieu Dec 23, 2023
dtolnay
dtolnay approved these changes Dec 23, 2023
View reviewed changes
Copy link
Member

@dtolnay dtolnay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR!

FCP already finished in the tracking issue.

@dtolnay
Copy link
Member

dtolnay commented Dec 23, 2023

@bors r+

@bors
Copy link
Contributor

bors commented Dec 23, 2023

📌 Commit 62d5321 has been approved by dtolnay

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Dec 23, 2023
@matthiaskrgr matthiaskrgr mentioned this pull request Dec 23, 2023
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Dec 23, 2023
@bors
Auto merge of rust-lang#119263 - matthiaskrgr:rollup-zxok9fb, r=matth…
2d7be73 
…iaskrgr

Rollup of 5 pull requests

Successful merges:

 - rust-lang#112936 (Add illumos aarch64 target for rust.)
 - rust-lang#119153 (stabilize `file_create_new`)
 - rust-lang#119246 ([rustdoc] Add `is_object_safe` information for traits in JSON output)
 - rust-lang#119254 (Remove an unused diagnostic struct)
 - rust-lang#119255 (add a test for ICE rust-lang#112822)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit b136919 into rust-lang:master Dec 23, 2023
11 checks passed
@rustbot rustbot added this to the 1.77.0 milestone Dec 23, 2023
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request Dec 23, 2023
@rust-timer
Unrolled build for rust-lang#119153
9b21d24 
Rollup merge of rust-lang#119153 - rursprung:stabilize-file_create_new, r=dtolnay

stabilize `file_create_new`

closes rust-lang#105135
@rursprung rursprung deleted the stabilize-file_create_new branch December 24, 2023 08:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dtolnay dtolnay dtolnay approved these changes

Assignees

@dtolnay dtolnay

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-libs Relevant to the library team, which will review and decide on the PR/issue. T-libs-api Relevant to the library API team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.77.0
Development

Successfully merging this pull request may close these issues.

Tracking Issue for file_create_new
8 participants
@rursprung @rustbot @rust-log-analyzer @Noratrieb @thomcc @dtolnay @bors @Amanieu