Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rustdoc: clean up source sidebar hide button #119066

Merged
merged 6 commits into from
Dec 31, 2023
Merged

rustdoc: clean up source sidebar hide button #119066

merged 6 commits into from
Dec 31, 2023

Commits on Dec 18, 2023

  1. rustdoc: clean up source sidebar hide button 

    This is a redesign of the feature, with parts pulled from
rust-lang#119049
but with a button that looks more like a button and matches the
one used on other sidebar pages.
    @notriddle
    notriddle committed Dec 18, 2023
    Configuration menu
    Copy the full SHA
    859bbc5 View commit details
    Browse the repository at this point in the history

  2. Add back the column

    @notriddle
    notriddle committed Dec 18, 2023
    Configuration menu
    Copy the full SHA
    bd14fb6 View commit details
    Browse the repository at this point in the history

  3. Stop using the trigram of heaven as a hamburger button 

    It doesn't look quite right, because the lines are too far apart,
and it's not going to be announced by screenreaders as a menu button,
since that's not what the symbol means.

This adds a real tooltip and uses a better drawing of the icon.
    @notriddle
    notriddle committed Dec 18, 2023
    Configuration menu
    Copy the full SHA
    c3e29ea View commit details
    Browse the repository at this point in the history

  4. Add border bottom for source sidebar title area

    @notriddle
    notriddle committed Dec 18, 2023
    Configuration menu
    Copy the full SHA
    66779ff View commit details
    Browse the repository at this point in the history

Commits on Dec 19, 2023

  1. Use folder icon instead of hamburger and sidebar

    @notriddle
    notriddle committed Dec 19, 2023
    Configuration menu
    Copy the full SHA
    34984a6 View commit details
    Browse the repository at this point in the history

Commits on Dec 20, 2023

  1. Fix corner cases when dealing with mobile mode

    @notriddle
    notriddle committed Dec 20, 2023
    Configuration menu
    Copy the full SHA
    9566db1 View commit details
    Browse the repository at this point in the history