Rollup of 7 pull requests #118893
Closed
Rollup of 7 pull requests #118893
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Wrap coroutine variant fields in MaybeUninit to indicate that they might be uninitialized. Otherwise an uninhabited field will make the entire variant uninhabited and introduce undefined behaviour. The analogous issue in the prefix of coroutine layout was addressed by 6fae7f8.
Stop allowing `rustc::potential_query_instability` in all of `rustc_passes` and instead allow it on a case-by-case basis if it is safe. In this case, all instances of the lint are safe to allow.
filter_map_identity needless_bool search_is_some unit_arg map_identity needless_question_mark derivable_impls
add note that `missing_empty` is cleared now Co-authored-by: Nadrieril <Nadrieril@users.noreply.github.com>
…ty, r=compiler-errors rustc_passes: Enforce `rustc::potential_query_instability` lint Stop allowing `rustc::potential_query_instability` in all of `rustc_passes` and instead allow it on a case-by-case basis if it is safe. In this case, all instances of the lint are safe to allow. Part of rust-lang#84447 which is E-help-wanted.
…lds, r=compiler-errors Coroutine variant fields can be uninitialized Wrap coroutine variant fields in MaybeUninit to indicate that they might be uninitialized. Otherwise an uninhabited field will make the entire variant uninhabited and introduce undefined behaviour. The analogous issue in the prefix of coroutine layout was addressed by 6fae7f8.
…, r=notriddle Add rustX check to codeblock attributes lint We discovered this issue [here](rust-lang#118802 (comment)). I assume that the issue will be present in other places outside of the compiler so it's worth adding a check for it. First commit is just a small cleanup about variables creation which was a bit strange (at least more than necessary). r? ``@notriddle``
…drieril NFC: simplify merging of two vecs
…r-errors clippy::complexity fixes filter_map_identity needless_bool search_is_some unit_arg map_identity needless_question_mark derivable_impls
…s, r=notriddle Clean up variables in `search.js` While reviewing rust-lang#118402, I saw a few small clean ups that were needed, mostly about variables creation. r? ``@notriddle``
rustbot
added
A-query-system
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Successful merges:
rustc::potential_query_instabilitylint #118870 (rustc_passes: Enforcerustc::potential_query_instabilitylint)search.js#118886 (Clean up variables insearch.js)r? @ghost
@rustbot modify labels: rollup
Create a similar rollup