Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

codegen: panic when trying to compute size/align of extern type #118534

Merged
merged 7 commits into from
Dec 13, 2023
Merged

codegen: panic when trying to compute size/align of extern type #118534

merged 7 commits into from
Dec 13, 2023

Commits on Dec 12, 2023

  1. codegen: panic when trying to compute size/align of extern type

    @RalfJung
    RalfJung committed Dec 12, 2023
    Configuration menu
    Copy the full SHA
    b1613eb View commit details
    Browse the repository at this point in the history

  2. reject projecting to fields whose offset we cannot compute

    @RalfJung
    RalfJung committed Dec 12, 2023
    Configuration menu
    Copy the full SHA
    9ef1e35 View commit details
    Browse the repository at this point in the history

  3. remove a cranelift test that doesn't make sense any more

    @RalfJung
    RalfJung committed Dec 12, 2023
    Configuration menu
    Copy the full SHA
    b9c9b3e View commit details
    Browse the repository at this point in the history

  4. make it more clear what comments refer to; avoid dangling unaligned r… 

    …eferences

Co-authored-by: Waffle Maybe <waffle.lapkin@gmail.com>
    @RalfJung @WaffleLapkin
    RalfJung and WaffleLapkin committed Dec 12, 2023
    Configuration menu
    Copy the full SHA
    df227f7 View commit details
    Browse the repository at this point in the history

  5. test that both size_of_val and align_of_val panic

    @RalfJung
    RalfJung committed Dec 12, 2023
    Configuration menu
    Copy the full SHA
    a47416b View commit details
    Browse the repository at this point in the history

  6. also test projecting to some sized fields at non-zero offset in struc… 

    …ts with an extern type tail
    @RalfJung
    RalfJung committed Dec 12, 2023
    Configuration menu
    Copy the full SHA
    edcb7ab View commit details
    Browse the repository at this point in the history

  7. also add a Miri test

    @RalfJung
    RalfJung committed Dec 12, 2023
    Configuration menu
    Copy the full SHA
    f813ccd View commit details
    Browse the repository at this point in the history