Rollup of 9 pull requests #118277
Merged
Rollup of 9 pull requests #118277
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t Binder<TraitRef>
Signed-off-by: onur-ozkan <work@onurozkan.dev>
This fixes the problem of not being able to see bootstrap config changes unless the change-id in config.toml changes. Signed-off-by: onur-ozkan <work@onurozkan.dev>
Because bootstrap lib is already large and complicated, this should make the "bumping change-id" process easier. Signed-off-by: onur-ozkan <work@onurozkan.dev>
This file was getting too big and causing a lot of merge conflicts. All these changes shouldn't be visible to users since this module is private.
Separate items that are exposed in the `stable_mir` crate to be used by the compiler from items that we expect to be used by tool developers.
…acrum general improvements/fixes on bootstrap - adds rust-lang#117813 into change tracker rust-lang@6d9b92f - fixes a bug in change tracker rust-lang@63a4410 - relocates `CONFIG_CHANGE_HISTORY` rust-lang@a7dcb98
…, r=GuillaumeGomez rustdoc-search: avoid infinite where clause unbox Fixes rust-lang#118242
Replace `option.map(cond) == Some(true)` with `option.is_some_and(cond)` Requested by `@fmease` in rust-lang#118226 (review). There is also a much larger number of `option.map_or(false, cond)` that can be changed separately if someone wants. r? fmease
…rk-Simulacrum Request that rust-analyzer changes are sent upstream first if possible This automates `@lnicola's` comment rust-lang#118253 (comment). Rustbot will write a comment similar to rust-lang#116743 (comment).
…infer, r=compiler-errors Move EagerResolution to rustc_infer::infer::resolve `EagerResolver` fits better in `rustc_infer::infer::resolver`. Started to disentagle rust-lang#118118 that has a lot of unrelated things. r? `@compiler-errors` `@lcnr`
…=compiler-errors Relate Inherent Associated Types using eq We should call `eq` instead of `sup` as we're relating `Ty` directly and not `Binder<TraitRef>`. This is part of rust-lang#118118 but unrelated to that PR. r? `@compiler-errors` `@lcnr`
…ler-errors
Move stuff around on `stable_mir` and `rustc_smir` crate
1. Break down rustc_smir/mod.rs file.
- This file was getting too big and causing a lot of merge conflicts.
All these changes shouldn't be visible to users since this module is private.
2. Move the compiler interface defs to its own module
- Separate items that are exposed in the `stable_mir` crate to be used
by the compiler from items that we expect to be used by tool developers.
Separate `NaN`/`Inf` floats with `_` r? RalfJung Fixes rust-lang#118221 No test 🤷 unless you know a good way to print an `ImmTy` in a unit test?
Fix smir's `Ty::Ref` pretty printing Add `&` or `&mut` to reference when generating a string for `TyKind::Ref`. r? `@ouz-a`
rustbot
added
A-meta
|
@bors r+ rollup=never p=9 |
bors
added
S-waiting-on-bors
|
☀️ Test successful - checks-actions |
|
📌 Perf builds for each rolled up PR:
previous master: fad6bb80fa In the case of a perf regression, run the following command for each PR you suspect might be the cause: |
This was referenced Nov 25, 2023
|
Finished benchmarking commit (3668a8a): comparison URL. Overall result: no relevant changes - no action needed@rustbot label: -perf-regression Instruction countThis benchmark run did not return any relevant results for this metric. Max RSS (memory usage)ResultsThis is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
CyclesThis benchmark run did not return any relevant results for this metric. Binary sizeThis benchmark run did not return any relevant results for this metric. Bootstrap: 674.747s -> 675.41s (0.10%) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Successful merges:
option.map(cond) == Some(true)withoption.is_some_and(cond)#118253 (Replaceoption.map(cond) == Some(true)withoption.is_some_and(cond))stable_mirandrustc_smircrate #118266 (Move stuff around onstable_mirandrustc_smircrate)NaN/Inffloats with_#118271 (SeparateNaN/Inffloats with_)Ty::Refpretty printing #118274 (Fix smir'sTy::Refpretty printing)r? @ghost
@rustbot modify labels: rollup
Create a similar rollup