Add support for global allocation in smir #118012
Conversation
|
(rustbot has picked a reviewer for you, use r? to override) |
rustbot
added
S-waiting-on-review
|
This PR changes Stable MIR cc @oli-obk, @celinval, @spastorino, @ouz-a |
This comment has been minimized.
This comment has been minimized.
|
This PR changes Stable MIR cc @oli-obk, @celinval, @spastorino, @ouz-a |
Why me of all people, I never even touched stable MIR! |
|
Reroll. |
Sorry @petrochenkov, that was automatic assignment. I've created a PR to automatically assign stable mir PRs to one of the project members. |
|
r? @spastorino |
|
☔ The latest upstream changes (presumably #118023) made this pull request unmergeable. Please resolve the merge conflicts. |
|
could you please explain the current necessity for supporting this feature, and the contexts in which it will be utilized |
|
Yeah, I agree with @ouz-a and think this PR should be more motivated. Maybe fill out the PR description a bit more? |
|
@compiler-errors @ouz-a, I added a basic test and edited the PR's description. Let me know if that makes more sense. Thanks |
|
☔ The latest upstream changes (presumably #118015) made this pull request unmergeable. Please resolve the merge conflicts. |
|
@bors r+ rollup |
bors
added
S-waiting-on-bors
…iaskrgr Rollup of 4 pull requests Successful merges: - rust-lang#117972 (Add VarDebugInfo to Stable MIR) - rust-lang#118110 (Document `DefiningAnchor` a bit more) - rust-lang#118112 (Don't ICE when ambiguity is found when selecting `Index` implementation in typeck) - rust-lang#118135 (Remove quotation from filename in stable_mir) Failed merges: - rust-lang#118012 (Add support for global allocation in smir) r? `@ghost` `@rustbot` modify labels: rollup
…iaskrgr Rollup of 5 pull requests Successful merges: - rust-lang#117972 (Add VarDebugInfo to Stable MIR) - rust-lang#118109 (rustdoc-search: simplify `checkPath` and `sortResults`) - rust-lang#118110 (Document `DefiningAnchor` a bit more) - rust-lang#118112 (Don't ICE when ambiguity is found when selecting `Index` implementation in typeck) - rust-lang#118135 (Remove quotation from filename in stable_mir) Failed merges: - rust-lang#118012 (Add support for global allocation in smir) r? `@ghost` `@rustbot` modify labels: rollup
…mpiler-errors Rollup of 6 pull requests Successful merges: - rust-lang#118012 (Add support for global allocation in smir) - rust-lang#118013 (Enable Rust to use the EHCont security feature of Windows) - rust-lang#118100 (Enable profiler in dist-powerpc64-linux) - rust-lang#118142 (Tighten up link attributes for llvm-wrapper bindings) - rust-lang#118147 (Fix some unnecessary casts) - rust-lang#118161 (Allow defining opaques in `check_coroutine_obligations`) r? `@ghost` `@rustbot` modify labels: rollup
Rollup merge of rust-lang#118012 - celinval:smir-alloc, r=ouz-a Add support for global allocation in smir Add APIs to StableMir to support global allocation. Before this change, StableMir users had no API available to retrieve Allocation provenance information. They had to resource to internal APIs instead. One example is retrieving the Allocation of an `&str`. See test for an example on how the API can be used.
Add APIs to StableMir to support global allocation. Before this change, StableMir users had no API available to retrieve Allocation provenance information. They had to resource to internal APIs instead.
One example is retrieving the Allocation of an
&str. See test for an example on how the API can be used.