When a local binding shadows a fn, point at fn def in call failure

[estebank]

When a local binding shadows a function that is then called, this local binding will cause an E0618 error. We now point not only at the binding definition, but also at the locally defined function of the same name.

error[E0618]: expected function, found `&str`
  --> $DIR/issue-22468.rs:3:13
   |
LL |     let foo = "bar";
   |         --- `foo` has type `&str`
LL |     let x = foo("baz");
   |             ^^^-------
   |             |
   |             call expression requires function
...
LL | fn foo(file: &str) -> bool {
   | -------------------------- this function of the same name is available here, but it shadowed by the local binding of the same name

Fix #53841

[rustbot]

r? @petrochenkov

(rustbot has picked a reviewer for you, use r? to override)

[petrochenkov]

r=me with cleanup.
@rustbot author

[estebank]

@bors r=petrochenkov

[bors]

📌 Commit 7141399 has been approved by petrochenkov

It is now in the queue for this repository.

[bors]

⌛ Testing commit 7141399 with merge e1e60b6...

[bors]

☀️ Test successful - checks-actions
Approved by: petrochenkov
Pushing e1e60b6 to master...

[rust-timer]

Finished benchmarking commit (e1e60b6): comparison URL.

Overall result: no relevant changes - no action needed

@rustbot label: -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-0.8%	[-0.8%, -0.8%]	1
Improvements ✅ (secondary)	-2.9%	[-4.0%, -2.3%]	3
All ❌✅ (primary)	-0.8%	[-0.8%, -0.8%]	1

Cycles

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-3.6%	[-3.6%, -3.6%]	1
All ❌✅ (primary)	-	-	0

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 675.683s -> 678.285s (0.39%)
Artifact size: 313.83 MiB -> 313.84 MiB (0.00%)