Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(release): Clarify cargo entries #117889

Merged
merged 5 commits into from
Nov 17, 2023
Merged

docs(release): Clarify cargo entries #117889

merged 5 commits into from
Nov 17, 2023

Conversation

epage
Copy link
Contributor

@epage epage commented Nov 13, 2023

Trying to make these easier to scan and more understandable out of the context of their PR

@rustbot
Copy link
Collaborator

rustbot commented Nov 13, 2023

r? @Mark-Simulacrum

(rustbot has picked a reviewer for you, use r? to override)

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-release Relevant to the release subteam, which will review and decide on the PR/issue. labels Nov 13, 2023
@weihanglo
Copy link
Member

Could you also help delete this entry in 1.73 release note?

- [Encode URL params correctly for `SourceId` in `Cargo.lock`.](https://github.com/rust-lang/cargo/pull/12280/)

It is behind an unstable feature gate hence shouldn't be there.

@rustbot
Copy link
Collaborator

rustbot commented Nov 14, 2023

Some changes occurred in src/tools/cargo

cc @ehuss

@Mark-Simulacrum
Copy link
Member

@bors r+

@bors
Copy link
Contributor

bors commented Nov 17, 2023

📌 Commit c8330ba has been approved by Mark-Simulacrum

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 17, 2023
bors added a commit to rust-lang-ci/rust that referenced this pull request Nov 17, 2023
Rollup of 5 pull requests

Successful merges:

 - rust-lang#117649 (Move `lint_store`)
 - rust-lang#117850 (bootstrap: simplify setting unstable-options for tools)
 - rust-lang#117889 (docs(release): Clarify cargo entries)
 - rust-lang#117946 (avoid exhaustive i16 test in Miri)
 - rust-lang#117963 (`rustc_query_system` cleanups)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 3c0f22d into rust-lang:master Nov 17, 2023
11 checks passed
@rustbot rustbot added this to the 1.76.0 milestone Nov 17, 2023
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request Nov 17, 2023
Rollup merge of rust-lang#117889 - epage:docs, r=Mark-Simulacrum

docs(release): Clarify cargo entries

Trying to make these easier to scan and more understandable out of the context of their PR
@epage epage deleted the docs branch November 28, 2023 21:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-release Relevant to the release subteam, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants