Hint optimizer about try-reserved capacity #117503

kornelski · 2023-11-02T01:31:05Z

This is #116568, but limited only to the less-common try_reserve functions to reduce bloat in debug binaries from debug info, while still addressing the main use-case #117925

rustbot · 2023-11-02T01:31:14Z

r? @Mark-Simulacrum

(rustbot has picked a reviewer for you, use r? to override)

tests/codegen/vec-reserve-extend.rs

the8472 · 2023-11-02T21:56:14Z

@bors try @rust-timer queue

bors · 2023-11-02T21:59:09Z

⌛ Trying commit 029fbd6 with merge 616f4d8...

Hint optimizer about try-reserved capacity This is rust-lang#116568, but limited only to the less-common `try_reserve` functions to reduce bloat in debug binaries from debug info, while still addressing the main use-case rust-lang#116570

bors · 2023-11-02T23:27:02Z

☀️ Try build successful - checks-actions
Build commit: 616f4d8 (616f4d88e8be2877dcccfa1aa98b1038d406226a)

rust-timer · 2023-11-03T00:48:58Z

Finished benchmarking commit (616f4d8): comparison URL.

Overall result: ✅ improvements - no action needed

Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. While you can manually mark this PR as fit for rollup, we strongly recommend not doing so since this PR may lead to changes in compiler perf.

@bors rollup=never
@rustbot label: -S-waiting-on-perf -perf-regression

Instruction count

This is a highly reliable metric that was used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-2.8%	[-2.8%, -2.8%]	1
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	-2.8%	[-2.8%, -2.8%]	1

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	2.0%	[2.0%, 2.0%]	1
Improvements ✅ (primary)	-1.8%	[-1.8%, -1.8%]	1
Improvements ✅ (secondary)	-2.2%	[-2.2%, -2.2%]	1
All ❌✅ (primary)	-1.8%	[-1.8%, -1.8%]	1

Cycles

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-2.6%	[-2.6%, -2.6%]	1
Improvements ✅ (secondary)	-2.4%	[-2.9%, -2.0%]	5
All ❌✅ (primary)	-2.6%	[-2.6%, -2.6%]	1

Binary size

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	0.1%	[0.0%, 0.7%]	22
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	0.1%	[0.0%, 0.7%]	22

Bootstrap: 637.769s -> 637.695s (-0.01%)
Artifact size: 304.51 MiB -> 304.53 MiB (0.00%)

Mark-Simulacrum · 2023-11-04T16:12:11Z

r? @workingjubilee

workingjubilee · 2023-11-04T18:00:46Z

@bors r+

bors · 2023-11-04T18:00:49Z

📌 Commit 029fbd6 has been approved by workingjubilee

It is now in the queue for this repository.

bors · 2023-11-05T00:03:44Z

⌛ Testing commit 029fbd6 with merge f5ca57e...

bors · 2023-11-05T01:58:25Z

☀️ Test successful - checks-actions
Approved by: workingjubilee
Pushing f5ca57e to master...

rust-timer · 2023-11-05T22:38:07Z

Finished benchmarking commit (f5ca57e): comparison URL.

Overall result: ✅ improvements - no action needed

@rustbot label: -perf-regression

Instruction count

This is a highly reliable metric that was used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-10.4%	[-23.6%, -0.4%]	6
Improvements ✅ (secondary)	-13.5%	[-19.5%, -7.5%]	2
All ❌✅ (primary)	-10.4%	[-23.6%, -0.4%]	6

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	0.7%	[0.5%, 1.2%]	3
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-2.3%	[-5.9%, -0.6%]	10
Improvements ✅ (secondary)	-6.9%	[-9.8%, -4.1%]	2
All ❌✅ (primary)	-1.6%	[-5.9%, 1.2%]	13

Cycles

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	0.5%	[0.5%, 0.6%]	3
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-6.2%	[-22.4%, -0.4%]	10
Improvements ✅ (secondary)	-16.8%	[-23.0%, -10.6%]	2
All ❌✅ (primary)	-4.7%	[-22.4%, 0.6%]	13

Binary size

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	0.1%	[0.0%, 0.4%]	22
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	0.1%	[0.0%, 0.4%]	22

Bootstrap: 635.284s -> 638.1s (0.44%)
Artifact size: 304.41 MiB -> 304.38 MiB (-0.01%)

84: Automated pull from upstream `master` r=Dajamante a=github-actions[bot] This PR pulls the following changes from the upstream repository: * rust-lang/rust#117585 * rust-lang/rust#117576 * rust-lang/rust#96979 * rust-lang/rust#117191 * rust-lang/rust#117179 * rust-lang/rust#117574 * rust-lang/rust#117537 * rust-lang/rust#117608 * rust-lang/rust#117596 * rust-lang/rust#117588 * rust-lang/rust#117524 * rust-lang/rust#116017 * rust-lang/rust#117504 * rust-lang/rust#117469 * rust-lang/rust#116218 * rust-lang/rust#117589 * rust-lang/rust#117581 * rust-lang/rust#117503 * rust-lang/rust#117590 * rust-lang/rust#117583 * rust-lang/rust#117570 * rust-lang/rust#117562 * rust-lang/rust#117534 * rust-lang/rust#116894 * rust-lang/rust#110340 * rust-lang/rust#113343 * rust-lang/rust#117579 * rust-lang/rust#117094 * rust-lang/rust#117566 * rust-lang/rust#117564 * rust-lang/rust#117554 * rust-lang/rust#117550 * rust-lang/rust#117343 * rust-lang/rust#115274 * rust-lang/rust#117540 * rust-lang/rust#116412 * rust-lang/rust#115333 * rust-lang/rust#117507 * rust-lang/rust#117538 * rust-lang/rust#117533 * rust-lang/rust#117523 * rust-lang/rust#117520 * rust-lang/rust#117505 * rust-lang/rust#117434 * rust-lang/rust#117535 * rust-lang/rust#117510 * rust-lang/rust#116439 * rust-lang/rust#117508 Co-authored-by: Ben Wiederhake <BenWiederhake.GitHub@gmx.de> Co-authored-by: SabrinaJewson <sejewson@gmail.com> Co-authored-by: J-ZhengLi <lizheng135@huawei.com> Co-authored-by: koka <koka.code@gmail.com> Co-authored-by: bjorn3 <17426603+bjorn3@users.noreply.github.com> Co-authored-by: Joshua Liebow-Feeser <joshlf@users.noreply.github.com> Co-authored-by: lengyijun <sjtu5140809011@gmail.com> Co-authored-by: Zalathar <Zalathar@users.noreply.github.com> Co-authored-by: Oli Scherer <git-spam-no-reply9815368754983@oli-obk.de> Co-authored-by: Philipp Krones <hello@philkrones.com> Co-authored-by: y21 <30553356+y21@users.noreply.github.com> Co-authored-by: bors <bors@rust-lang.org> Co-authored-by: bohan <bohan-zhang@foxmail.com>

pnkfelix · 2023-11-07T18:51:28Z

Visiting for weekly perf triage.

improvement here is transient noise on bitmaps and cargo.

Handle out of memory errors in io:Read::read_to_end() rust-lang#116570 got stuck due to a [procedural confusion](rust-lang#116570 (comment)). Retrying so that it can get FCP with the proper team now. cc `@joshtriplett` `@BurntSushi` ---- I'd like to propose handling of out-of-memory errors in the default implementation of `io::Read::read_to_end()` and `fs::read()`. These methods create/grow a `Vec` with a size that is external to the program, and could be arbitrarily large. Due to being I/O methods, they can already fail in a variety of ways, in theory even including `ENOMEM` from the OS too, so another failure case should not surprise anyone. While this may not help much Linux with overcommit, it's useful for other platforms like WASM. [Internals thread](https://internals.rust-lang.org/t/io-read-read-to-end-should-handle-oom/19662). I've added documentation that makes it explicit that the OOM handling is a nice-to-have, and not a guarantee of the trait. I haven't changed the implementation of `impl Read for &[u8]` and `VecDeque` out of caution, because in these cases users could assume `read` can't fail. This code uses `try_reserve()` + `extend_from_slice()` which is optimized since rust-lang#117503.

Hint optimizer about reserved capacity

029fbd6

rustbot assigned Mark-Simulacrum Nov 2, 2023

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Nov 2, 2023

jhorstmann reviewed Nov 2, 2023

View reviewed changes

tests/codegen/vec-reserve-extend.rs Show resolved Hide resolved

This comment has been minimized.

Sign in to view

rustbot added the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Nov 2, 2023

This comment has been minimized.

Sign in to view

rustbot removed the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Nov 3, 2023

rustbot assigned workingjubilee and unassigned Mark-Simulacrum Nov 4, 2023

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 4, 2023

bors added the merged-by-bors This PR was explicitly merged by bors. label Nov 5, 2023

bors merged commit f5ca57e into rust-lang:master Nov 5, 2023
11 checks passed

rustbot added this to the 1.75.0 milestone Nov 5, 2023

bors mentioned this pull request Nov 5, 2023

Hint optimizer about reserved capacity #116568

Closed

kornelski mentioned this pull request Nov 6, 2023

Handle out of memory errors in io::Read::read_to_end #116570

Closed

kornelski deleted the hint-try-reserved branch November 6, 2023 00:49

github-actions bot mentioned this pull request Nov 6, 2023

Automated pull from upstream master ferrocene/ferrocene#84

Merged

kornelski mentioned this pull request Nov 15, 2023

Handle out of memory errors in io:Read::read_to_end() #117925

Merged

kornelski mentioned this pull request Jan 30, 2024

Vec::try_with_capacity #120504

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Hint optimizer about try-reserved capacity #117503

Hint optimizer about try-reserved capacity #117503

kornelski commented Nov 2, 2023 •

edited

Loading

rustbot commented Nov 2, 2023

the8472 commented Nov 2, 2023

This comment has been minimized.

bors commented Nov 2, 2023

bors commented Nov 2, 2023

This comment has been minimized.

rust-timer commented Nov 3, 2023

Mark-Simulacrum commented Nov 4, 2023

workingjubilee commented Nov 4, 2023

bors commented Nov 4, 2023

bors commented Nov 5, 2023

bors commented Nov 5, 2023

rust-timer commented Nov 5, 2023

pnkfelix commented Nov 7, 2023

Hint optimizer about try-reserved capacity #117503

Hint optimizer about try-reserved capacity #117503

Conversation

kornelski commented Nov 2, 2023 • edited Loading

rustbot commented Nov 2, 2023

the8472 commented Nov 2, 2023

This comment has been minimized.

bors commented Nov 2, 2023

bors commented Nov 2, 2023

This comment has been minimized.

rust-timer commented Nov 3, 2023

Overall result: ✅ improvements - no action needed

Mark-Simulacrum commented Nov 4, 2023

workingjubilee commented Nov 4, 2023

bors commented Nov 4, 2023

bors commented Nov 5, 2023

bors commented Nov 5, 2023

rust-timer commented Nov 5, 2023

Overall result: ✅ improvements - no action needed

pnkfelix commented Nov 7, 2023

kornelski commented Nov 2, 2023 •

edited

Loading