Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mark .rmeta files as /SAFESEH on x86 Windows. #117115

Merged
merged 1 commit into from
Oct 26, 2023
Merged

Mark .rmeta files as /SAFESEH on x86 Windows. #117115

merged 1 commit into from
Oct 26, 2023

Commits on Oct 24, 2023

  1. Mark .rmeta files as /SAFESEH on x86 Windows. 

    Chrome links .rlibs with /WHOLEARCHIVE or -Wl,--whole-archive to prevent
the linker from discarding static initializers. This works well, except
on Windows x86, where lld complains:

  error: /safeseh: lib.rmeta is not compatible with SEH

The fix is simply to mark the .rmeta as SAFESEH aware. This is trivially
true, since the metadata file does not contain any executable code.
    @zetafunction
    zetafunction committed Oct 24, 2023
    Configuration menu
    Copy the full SHA
    8fa800d View commit details
    Browse the repository at this point in the history