Clippy subtree update #117021

flip1995 · 2023-10-21T12:18:21Z

documenation -> documentation

The word "active" is currently used in two different and confusing ways: - `ACTIVE_FEATURES` actually means "available unstable features" - `Features::active_features` actually means "features declared in the crate's code", which can include feature within `ACTIVE_FEATURES` but also others. (This is also distinct from "enabled" features which includes declared features but also some edition-specific features automatically enabled depending on the edition in use.) This commit changes the `Features::active_features` to `Features::declared_features` which actually matches its meaning. Likewise, `Features::active` becomes `Features::declared`.

…nt in async function for the `needless_pass_by_ref_mut` lint

Fix ice in `redundant_locals` Fixes rust-lang#11619 Rebinding over macro like the code below, idents will be different (`x#4` and `x#0` in that case). ```rust fn reassign_in_macro() { let x = 10; macro_rules! mac { ($i:ident) => { let mut x = x; } } mac!(y); } ``` It causes unwrapping `None`. https://github.com/rust-lang/rust-clippy/blob/9554e477c29e6ddca9e5cdce71524341ef9d48e8/clippy_lints/src/redundant_locals.rs#L88-L98 changelog: ICE: [`redundant_locals`]: No longer lints rebinding over macro

Fix typo in attrs.rs documenation -> documentation

[`into_iter_without_iter`]: walk up deref impl chain to find `iter` methods Fixes rust-lang#11635 changelog: [`into_iter_without_iter`]: walk up deref impl chain to find `iter` methods

Clean up `rustc_features` Plenty more to be done, but this is a decent start. r? `@Nilstrieb`

Fix two typos in lint description Fix rust-lang#11636 changelog: none

…assocfn, r=dswij `impl_trait_in_params` now supports impls and traits Before this PR, the lint `impl_trait_in_params`. This PR gives the lint support for functions in impls and traits. (Also, some pretty heavy refactor) fixes rust-lang#11548 changelog:[`impl_trait_in_params`] now supports `impl` blocks and functions in traits

Update ui_test to 0.21.2 Hopefully fixes rust-lang#11489 r? `@flip1995` changelog: none

There are several that are unused and can be removed. And there are some calls to `to_string`, which can be expressed more nicely as a `foo_to_string` call, and then `to_string` need not be `pub`. (This requires adding `pat_to_string`).

…e1-dead `rustc_hir_pretty` cleanups Just some improvements I found while looking through this code. r? ``@fee1-dead``

[`manual_is_ascii_check`]: Also check for `is_ascii_hexdigt` changelog: [`manual_is_ascii_check`]: Also check for `is_ascii_hexdigt`

Now `declare_interior_mutable_const` and `borrow_interior_mutable_const` respect the `ignore-interior-mutability` configuration entry Fix rust-lang#10537 changelog: Now `declare_interior_mutable_const` and `borrow_interior_mutable_const` respect the `ignore-interior-mutability` configuration entry

…ntri3 Warn missing_enforced_import_renames by default Similar to rust-lang/rust-clippy#8261 that did the same thing to disallowed_methods & disallowed_types. This lint is also only triggered if import renames are defined in the `clippy.toml` file. changelog: Moved [`missing_enforced_import_renames`] to `style` (Now warn-by-default) [rust-lang#11539](rust-lang/rust-clippy#11539)

Rustup r? `@ghost` changelog: none

rustbot · 2023-10-21T12:18:31Z

Some changes occurred in src/tools/clippy

cc @rust-lang/clippy

These commits modify the Cargo.lock file. Unintentional changes to Cargo.lock can be introduced when switching branches and rebasing PRs.

If this was unintentional then you should revert the changes before this PR is merged.
Otherwise, you can ignore this comment.

matthiaskrgr · 2023-10-21T13:44:53Z

@bors r? matthiaskrgr r+ p=1

matthiaskrgr · 2023-10-21T13:45:27Z

@bors r+ p=1

bors · 2023-10-21T13:45:29Z

📌 Commit b8b55fe has been approved by matthiaskrgr

It is now in the queue for this repository.

bors · 2023-10-21T14:53:49Z

⌛ Testing commit b8b55fe with merge ad7b8a0...

bors · 2023-10-21T16:46:23Z

☀️ Test successful - checks-actions
Approved by: matthiaskrgr
Pushing ad7b8a0 to master...

rust-timer · 2023-10-21T18:08:24Z

Finished benchmarking commit (ad7b8a0): comparison URL.

Overall result: no relevant changes - no action needed

@rustbot label: -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-2.5%	[-2.8%, -2.2%]	3
All ❌✅ (primary)	-	-	0

Cycles

This benchmark run did not return any relevant results for this metric.

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 631.62s -> 632.219s (0.09%)
Artifact size: 301.95 MiB -> 301.96 MiB (0.01%)

pitaj and others added 30 commits September 15, 2023 21:56

triagebot no-merges: exclude "Rustup"s, add labels

6e0c456

Warn missing_enforced_import_renames by default

77c121e

Fix typo in attrs.rs

faacd55

documenation -> documentation

[get_first]: lint on non-primitive types

31fd282

dogfood

e6f29f1

Add more diagnostic items for clippy

9de3e6c

Add regression test for rust-lang#11610 about mutable usage of argume…

ddd1564

…nt in async function for the `needless_pass_by_ref_mut` lint

Merge commit 'b105fb4c39bc1a010807a6c076193cef8d93c109' into clippyup

8ebed4c

Fix ice

68d2082

Rollup merge of rust-lang#116423 - eltociear:patch-22, r=flip1995

0ed398e

Fix typo in attrs.rs documenation -> documentation

Fix two typos in lint description

bffba76

[into_iter_without_iter]: look for iter method in deref chains

1c6fa29

Auto merge of rust-lang#11639 - y21:issue11635, r=llogiq

7624045

[`into_iter_without_iter`]: walk up deref impl chain to find `iter` methods Fixes rust-lang#11635 changelog: [`into_iter_without_iter`]: walk up deref impl chain to find `iter` methods

Auto merge of rust-lang#116437 - nnethercote:rustc_features, r=Nilstrieb

56400a0

Clean up `rustc_features` Plenty more to be done, but this is a decent start. r? `@Nilstrieb`

Auto merge of rust-lang#11638 - samueltardieu:into-iter, r=Manishearth

33f49f3

Fix two typos in lint description Fix rust-lang#11636 changelog: none

Update ui_test to 0.21.2

850f2f5

impl_trait_in_params now supports impls and traits

5ed338d

Fix tests, only lint for public tests

7755737

Auto merge of rust-lang#11645 - Alexendoo:ui_test, r=flip1995

929a288

Update ui_test to 0.21.2 Hopefully fixes rust-lang#11489 r? `@flip1995` changelog: none

Extend impl's def_span to include where clauses

70b8d15

[map_identity]: allow closure with type annotations

0b60531

move changed logic to into its own util function

bba155e

Rejig some top-level rustc_hir_pretty functions.

359fa98

There are several that are unused and can be removed. And there are some calls to `to_string`, which can be expressed more nicely as a `foo_to_string` call, and then `to_string` need not be `pub`. (This requires adding `pat_to_string`).

Rollup merge of rust-lang#116625 - nnethercote:rustc_hir_pretty, r=fe…

0b8495b

…e1-dead `rustc_hir_pretty` cleanups Just some improvements I found while looking through this code. r? ``@fee1-dead``

[manual_is_ascii_check]: Also check for is_ascii_hexdigt

b5488f9

Auto merge of rust-lang#11659 - aDotInTheVoid:hexdigit, r=Jarcho

ff00e9c

[`manual_is_ascii_check`]: Also check for `is_ascii_hexdigt` changelog: [`manual_is_ascii_check`]: Also check for `is_ascii_hexdigt`

Avoid panic!, omit instead

eb6fb18

bors and others added 9 commits October 20, 2023 16:50

s/Generator/Coroutine/

868e513

s/generator/coroutine/

d9259fd

Merge remote-tracking branch 'upstream/master' into rustup

5f03156

Bump nightly version -> 2023-10-21

a585cda

Auto merge of rust-lang#11694 - flip1995:rustup, r=flip1995

2b030eb

Rustup r? `@ghost` changelog: none

Merge commit '2b030eb03d9e5837440b1ee0b98c50b97c0c5889' into clippyup

24b3554

Update Cargo.lock (ui_test update)

b8b55fe

rustbot assigned Manishearth Oct 21, 2023

rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Oct 21, 2023

rustbot assigned matthiaskrgr and unassigned Manishearth Oct 21, 2023

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 21, 2023

bors added the merged-by-bors This PR was explicitly merged by bors. label Oct 21, 2023

bors merged commit ad7b8a0 into rust-lang:master Oct 21, 2023
12 checks passed

rustbot added this to the 1.75.0 milestone Oct 21, 2023

bors mentioned this pull request Oct 21, 2023

Weekly cargo update #112865

Merged

flip1995 deleted the clippyup branch October 24, 2023 11:37

github-actions bot mentioned this pull request Oct 31, 2023

Automated pull from upstream master ferrocene/ferrocene#74

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Clippy subtree update #117021

Clippy subtree update #117021

flip1995 commented Oct 21, 2023

rustbot commented Oct 21, 2023

matthiaskrgr commented Oct 21, 2023

matthiaskrgr commented Oct 21, 2023

bors commented Oct 21, 2023

bors commented Oct 21, 2023

bors commented Oct 21, 2023

rust-timer commented Oct 21, 2023

Clippy subtree update #117021

Clippy subtree update #117021

Conversation

flip1995 commented Oct 21, 2023

rustbot commented Oct 21, 2023

matthiaskrgr commented Oct 21, 2023

matthiaskrgr commented Oct 21, 2023

bors commented Oct 21, 2023

bors commented Oct 21, 2023

bors commented Oct 21, 2023

rust-timer commented Oct 21, 2023

Overall result: no relevant changes - no action needed

Instruction count

Max RSS (memory usage)

Cycles

Binary size