Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rollup of 3 pull requests #116782

Merged
merged 6 commits into from
Oct 16, 2023
Merged

Rollup of 3 pull requests #116782

merged 6 commits into from
Oct 16, 2023

Commits on Sep 19, 2023

  1. Stabilize {IpAddr, Ipv6Addr}::to_canonical

    Make `IpAddr::to_canonical` and `IpV6Addr::to_canonical` stable, as well as
    const stabilize `Ipv6Addr::to_ipv4_mapped`.
    
    Newly stable API:
    
        impl IpAddr {
            // Now stable under `ip_to_canonical`
            const fn to_canonical(&self) -> IpAddr;
        }
    
        impl Ipv6Addr {
            // Now stable under `ip_to_canonical`
            const fn to_canonical(&self) -> IpAddr;
    
            // Already stable, this makes it const stable under
            // `const_ipv6_to_ipv4_mapped`
            const fn to_ipv4_mapped(&self) -> Option<Ipv4Addr>
        }
    
    These stabilize a subset of the following tracking issues:
    
    - rust-lang#27709
    - rust-lang#76205
    tgross35 committed Sep 19, 2023
    Configuration menu
    Copy the full SHA
    7381f9d View commit details
    Browse the repository at this point in the history

Commits on Oct 15, 2023

  1. Suggest adding return if the type of unused semi return value can c…

    …oerce to the fn return type
    chenyukang committed Oct 15, 2023
    Configuration menu
    Copy the full SHA
    25d38c4 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    61a752a View commit details
    Browse the repository at this point in the history

Commits on Oct 16, 2023

  1. Rollup merge of rust-lang#115196 - chenyukang:yukang-fix-86094, r=est…

    …ebank
    
    Suggest adding `return` if the for semi which can coerce to the fn return type
    
    Fixes rust-lang#86094
    r? `@estebank`
    matthiaskrgr committed Oct 16, 2023
    Configuration menu
    Copy the full SHA
    1de910f View commit details
    Browse the repository at this point in the history
  2. Rollup merge of rust-lang#115955 - tgross35:ip-to-canonical, r=dtolnay

    Stabilize `{IpAddr, Ipv6Addr}::to_canonical`
    
    Make `IpAddr::to_canonical` and `IpV6Addr::to_canonical` stable (+const), as well as const stabilize `Ipv6Addr::to_ipv4_mapped`.
    
    Newly stable API:
    
    ```rust
    impl IpAddr {
        // Newly stable under `ip_to_canonical`
        const fn to_canonical(&self) -> IpAddr;
    }
    
    impl Ipv6Addr {
        // Newly stable under `ip_to_canonical`
        const fn to_canonical(&self) -> IpAddr;
    
        // Already stable, this makes it const stable under
        // `const_ipv6_to_ipv4_mapped`
        const fn to_ipv4_mapped(&self) -> Option<Ipv4Addr>
    }
    ```
    
    These stabilize a subset of the following tracking issues:
    
    - rust-lang#27709
    - rust-lang#76205
    
    Stabilization of all methods under the `ip` gate was attempted once at rust-lang#66584 then again at rust-lang#76098. These were not successful because there are still unknowns about `is_documentation` `is_benchmarking` and similar; `to_canonical` is much more straightforward.
    
    I have looked and could not find any known issues with `to_canonical`. These were added in 2021 in rust-lang#87708
    
    cc implementor ``@the8472``
    
    r? libs-api
    ``@rustbot`` label +T-libs-api +needs-fcp
    matthiaskrgr committed Oct 16, 2023
    Configuration menu
    Copy the full SHA
    17113f7 View commit details
    Browse the repository at this point in the history
  3. Rollup merge of rust-lang#116776 - WaffleLapkin:hell-yeah-review-requ…

    …ested, r=Mark-Simulacrum
    
    Enable `review-requested` feature for rustbot
    
    See rust-lang/triagebot#1733.
    
    r? `@Mark-Simulacrum`
    matthiaskrgr committed Oct 16, 2023
    Configuration menu
    Copy the full SHA
    8feb7c5 View commit details
    Browse the repository at this point in the history