Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rollup of 3 pull requests #116742

Merged
merged 7 commits into from
Oct 15, 2023
Merged

Rollup of 3 pull requests #116742

merged 7 commits into from
Oct 15, 2023

Commits on Oct 12, 2023

  1. Configuration menu
    Copy the full SHA
    406fb86 View commit details
    Browse the repository at this point in the history

Commits on Oct 13, 2023

  1. Configuration menu
    Copy the full SHA
    6db2587 View commit details
    Browse the repository at this point in the history
  2. Add some optimizations

    daxpedda committed Oct 13, 2023
    Configuration menu
    Copy the full SHA
    dd34d90 View commit details
    Browse the repository at this point in the history

Commits on Oct 14, 2023

  1. const-eval: allow calling functions with targat features disabled at …

    …compile time in WASM
    
    This is not unsafe on WASM, see rust-lang#84988
    eduardosm committed Oct 14, 2023
    Configuration menu
    Copy the full SHA
    f9b1af6 View commit details
    Browse the repository at this point in the history
  2. Rollup merge of rust-lang#116540 - daxpedda:once-cell-lock-try-insert…

    …, r=Mark-Simulacrum
    
    Implement `OnceCell/Lock::try_insert()`
    
    I took inspiration from [`once_cell`](https://crates.io/crates/once_cell):
    - [`once_cell::unsync::OnceCell::try_insert()`](https://github.com/matklad/once_cell/blob/874f9373abd7feaf923a3b3c34bfb3383529c671/src/lib.rs#L551-L563)
    - [`once_cell::sync::OnceCell::try_insert()`](https://github.com/matklad/once_cell/blob/874f9373abd7feaf923a3b3c34bfb3383529c671/src/lib.rs#L1080-L1087)
    
    I tried to change as little code as possible in the first commit and applied some obvious optimizations in the second one.
    
    ACP: rust-lang/libs-team#276
    Tracking issue: rust-lang#116693
    GuillaumeGomez committed Oct 14, 2023
    Configuration menu
    Copy the full SHA
    fcd75cc View commit details
    Browse the repository at this point in the history
  3. Rollup merge of rust-lang#116576 - eduardosm:const-eval-wasm-target-f…

    …eatures, r=RalfJung
    
    const-eval: allow calling functions with targat features disabled at compile time in WASM
    
    This is not unsafe on WASM, see rust-lang#84988
    
    r? `@RalfJung`
    
    Fixes rust-lang#116516
    GuillaumeGomez committed Oct 14, 2023
    Configuration menu
    Copy the full SHA
    03cbf50 View commit details
    Browse the repository at this point in the history
  4. Rollup merge of rust-lang#116661 - WaffleLapkin:make-reviews-change-p…

    …r-state, r=Mark-Simulacrum
    
    Make "request changes" reviews apply `S-waiting-on-author`
    
    This makes it so **assignee** requesting changes on a PR via GitHub UI adds https://github.com/rust-lang/rust/labels/S-waiting-on-author and removes https://github.com/rust-lang/rust/labels/S-waiting-on-review.
    
    cc `@compiler-errors` :3
    GuillaumeGomez committed Oct 14, 2023
    Configuration menu
    Copy the full SHA
    31b86ea View commit details
    Browse the repository at this point in the history