-
Notifications
You must be signed in to change notification settings - Fork 12.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Token cleanups #116649
Token cleanups #116649
Conversation
For consistency with `proc_macro::Punct`.
Explaining something in the output that surprised me.
And reorder the arguments. I find it easier to think about this way.
@@ -404,7 +404,7 @@ impl Token { | |||
[DotDot, DotDotDot, DotDotEq].contains(&self.kind) | |||
} | |||
|
|||
pub fn is_op(&self) -> bool { | |||
pub fn is_punct(&self) -> bool { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Punct
in proc macros is about punctuation characters (single-character), but op
here is about operators (possibly multi-character, like +=
).
But I'm also not sure how right is to call e.g. #
an operator.
So renaming this is probably fine.
@bors r+ |
…sors, r=petrochenkov Token cleanups Some precursors to rust-lang#114571 that are worth merging even if the main part of rust-lang#114571 doesn't get merged. r? `@petrochenkov`
💔 Test failed - checks-actions |
@bors retry |
☀️ Test successful - checks-actions |
Finished benchmarking commit (19149d1): comparison URL. Overall result: no relevant changes - no action needed@rustbot label: -perf-regression Instruction countThis benchmark run did not return any relevant results for this metric. Max RSS (memory usage)ResultsThis is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
CyclesThis benchmark run did not return any relevant results for this metric. Binary sizeThis benchmark run did not return any relevant results for this metric. Bootstrap: 627.587s -> 628.214s (0.10%) |
50: Automated pull from upstream `master` r=Dajamante a=github-actions[bot] This PR pulls the following changes from the upstream repository: * rust-lang/rust#116619 * rust-lang/rust#115964 * rust-lang/rust#116391 * rust-lang/rust#116510 * rust-lang/rust#116671 * rust-lang/rust#116669 * rust-lang/rust#116654 * rust-lang/rust#116642 * rust-lang/rust#116625 * rust-lang/rust#116593 * rust-lang/rust#116649 * rust-lang/rust#116600 * rust-lang/rust#116628 Co-authored-by: Nadrieril <nadrieril+git@gmail.com> Co-authored-by: Scott McMurray <scottmcm@users.noreply.github.com> Co-authored-by: bjorn3 <17426603+bjorn3@users.noreply.github.com> Co-authored-by: Nicholas Nethercote <n.nethercote@gmail.com> Co-authored-by: Trevor Gross <tmgross@umich.edu> Co-authored-by: Georg Semmler <github@weiznich.de> Co-authored-by: Guillaume Gomez <guillaume.gomez@huawei.com> Co-authored-by: Gurinder Singh <frederick.the.fool@gmail.com> Co-authored-by: bors <bors@rust-lang.org>
Some precursors to #114571 that are worth merging even if the main part of #114571 doesn't get merged.
r? @petrochenkov