Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

compiler: env/path handling fixes #116487

Merged
merged 4 commits into from
Oct 8, 2023
Merged

compiler: env/path handling fixes #116487

merged 4 commits into from
Oct 8, 2023

Commits on Oct 6, 2023

  1. compiler: always use var_os("RUST_BACKTRACE") 

    There are 3 instances of var(...) and 3 instances of var_os(...); the
latter avoids an appearance of unhandled error, so use it everywhere.
    @tamird
    tamird committed Oct 6, 2023
    Configuration menu
    Copy the full SHA
    7654d4b View commit details
    Browse the repository at this point in the history

  2. rustc_driver: avoid fallible conversions 

    Use `std::path::PathBuf` rather than `String`; use `std::env::var_os`
rather than `std::env::var`. These changes avoid a number of error paths
which can arise in the presence of non-UTF-8 paths.
    @tamird
    tamird committed Oct 6, 2023
    Configuration menu
    Copy the full SHA
    a081007 View commit details
    Browse the repository at this point in the history

  3. rustc_codegen_ssa: use try_canonicalize in rpath 

    This is simpler and avoids unnecessary calls to `env::current_dir`.
    @tamird
    tamird committed Oct 6, 2023
    Configuration menu
    Copy the full SHA
    5aeb6a3 View commit details
    Browse the repository at this point in the history

  4. rustc_metadata: use try_canonicalize 

    This is simpler and avoids unnecessary calls to `env::current_dir`.

rustc_plugin is left unchanged to avoid conflicts with rust-lang#116412.

Updates rust-lang#116426.
    @tamird
    tamird committed Oct 6, 2023
    Configuration menu
    Copy the full SHA
    3cac3de View commit details
    Browse the repository at this point in the history