Additional doc links and explanation of Wake.
#116387
Conversation
|
r? @scottmcm (rustbot has picked a reviewer for you, use r? to override) |
rustbot
added
S-waiting-on-review
|
I'm waker-ignorant, so re-rolling in hopes of getting someone more qualified: |
|
☔ The latest upstream changes (presumably #96979) made this pull request unmergeable. Please resolve the merge conflicts. |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
The broken link checker seems to be giving a false positive — the link works in generated docs. |
|
Re-requesting review because of lack of response for 6 weeks. r? libs |
|
I'm going to be away for a few months, so I'm rerolling my PRs so that folks don't have to wait for me. Sorry/thanks. r? libs |
|
The addition looks fine to me, but the link checker is going to need to be fixed or otherwise convinced. Have you followed up on that at all? |
This is intended to clarify: * That `Wake` exists and can be used instead of `RawWaker`. * How to construct a `Waker` when you are looking at `Wake` (which was previously only documented in the example).
To be honest, I was hoping someone would come along with “Oh, you just have to format it like so…” To unblock this improvement to the docs, I've removed the link (except for a comment about why it doesn't exist). |
|
@bors r+ rollup |
bors
added
S-waiting-on-bors
Rollup of 13 pull requests Successful merges: - rust-lang#116387 (Additional doc links and explanation of `Wake`.) - rust-lang#118738 (Netbsd10 update) - rust-lang#118890 (Clarify the lifetimes of allocations returned by the `Allocator` trait) - rust-lang#120498 (Uplift `TypeVisitableExt` into `rustc_type_ir`) - rust-lang#120530 (Be less confident when `dyn` suggestion is not checked for object safety) - rust-lang#120915 (Fix suggestion span for `?Sized` when param type has default) - rust-lang#121015 (Optimize `delayed_bug` handling.) - rust-lang#121024 (implement `Default` for `AsciiChar`) - rust-lang#121039 (Correctly compute adjustment casts in GVN) - rust-lang#121045 (Fix two UI tests with incorrect directive / invalid revision) - rust-lang#121049 (Do not point at `#[allow(_)]` as the reason for compat lint triggering) - rust-lang#121071 (Use fewer delayed bugs.) - rust-lang#121073 (Fix typos in `OneLock` doc) r? `@ghost` `@rustbot` modify labels: rollup
Rollup merge of rust-lang#116387 - kpreid:wake-doc, r=cuviper Additional doc links and explanation of `Wake`. This is intended to clarify: * That `Wake` exists and can be used instead of `RawWaker`. * How to construct a `Waker` when you are looking at `Wake` (which was previously only documented in the example).
This is intended to clarify:
Wakeexists and can be used instead ofRawWaker.Wakerwhen you are looking atWake(which was previously only documented in the example).