-
Notifications
You must be signed in to change notification settings - Fork 13k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rename BoxMeUp to PanicPayload. #116008
Merged
Merged
Rename BoxMeUp to PanicPayload. #116008
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
m-ou-se
added
C-cleanup
Category: PRs that clean code up or issues documenting cleanup.
T-libs
Relevant to the library team, which will review and decide on the PR/issue.
A-panic
Area: Panicking machinery
labels
Sep 20, 2023
rustbot
added
the
S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
label
Sep 20, 2023
15 tasks
@bors r+ rollup |
bors
added
S-waiting-on-bors
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
and removed
S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
labels
Sep 20, 2023
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Sep 20, 2023
…iaskrgr Rollup of 4 pull requests Successful merges: - rust-lang#114394 (style-guide: Document formatting of `as` casts (mostly like a binary operator)) - rust-lang#115990 (Allow anyone to set llvm-fixed-upstream) - rust-lang#116008 (Rename BoxMeUp to PanicPayload.) - rust-lang#116011 (Update browser-ui-test version to 0.16.10) r? `@ghost` `@rustbot` modify labels: rollup
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Sep 21, 2023
…iaskrgr Rollup of 4 pull requests Successful merges: - rust-lang#114394 (style-guide: Document formatting of `as` casts (mostly like a binary operator)) - rust-lang#115990 (Allow anyone to set llvm-fixed-upstream) - rust-lang#116008 (Rename BoxMeUp to PanicPayload.) - rust-lang#116011 (Update browser-ui-test version to 0.16.10) r? `@ghost` `@rustbot` modify labels: rollup
rust-timer
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Sep 21, 2023
Rollup merge of rust-lang#116008 - m-ou-se:boxmeup, r=oli-obk Rename BoxMeUp to PanicPayload. "BoxMeUp" is not very clear. Let's rename that to a description of what it actually represents: a panic payload. This PR also renames the structs that implement this trait to have more descriptive names. Part of rust-lang#116005 r? `@oli-obk`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
A-panic
Area: Panicking machinery
C-cleanup
Category: PRs that clean code up or issues documenting cleanup.
S-waiting-on-bors
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
T-libs
Relevant to the library team, which will review and decide on the PR/issue.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
"BoxMeUp" is not very clear. Let's rename that to a description of what it actually represents: a panic payload.
This PR also renames the structs that implement this trait to have more descriptive names.
Part of #116005
r? @oli-obk