Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: return early when has tainted in mir pass #115815

Merged
merged 1 commit into from
Sep 13, 2023

Conversation

bvanjoi
Copy link
Contributor

@bvanjoi bvanjoi commented Sep 13, 2023

Fixes #115809

As in #115643, run_pass is skipped if the body has tainted errors.

r? @oli-obk

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Sep 13, 2023
@rustbot
Copy link
Collaborator

rustbot commented Sep 13, 2023

Some changes occurred to MIR optimizations

cc @rust-lang/wg-mir-opt

@oli-obk
Copy link
Contributor

oli-obk commented Sep 13, 2023

We could also skip the entire optimization pipeline instead of doing it per pass. For the const_prop_lint pass the situation was a bit different as that's part of our analyses and not a pure optimization

@bvanjoi
Copy link
Contributor Author

bvanjoi commented Sep 13, 2023

Thanks for your advice. I've relocated this condition to precede run_optimization_passes.

@oli-obk
Copy link
Contributor

oli-obk commented Sep 13, 2023

Thanks!

@bors r+

@bors
Copy link
Contributor

bors commented Sep 13, 2023

📌 Commit 7c53e87 has been approved by oli-obk

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 13, 2023
bors added a commit to rust-lang-ci/rust that referenced this pull request Sep 13, 2023
…iaskrgr

Rollup of 6 pull requests

Successful merges:

 - rust-lang#115736 (Remove `verbose_generic_activity_with_arg`)
 - rust-lang#115771 (cleanup leftovers of const_err lint)
 - rust-lang#115798 (add helper method for finding the one non-1-ZST field)
 - rust-lang#115812 (Merge settings.css into rustdoc.css)
 - rust-lang#115815 (fix: return early when has tainted in mir pass)
 - rust-lang#115816 (Disabled socketpair for Vita)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 48d89a8 into rust-lang:master Sep 13, 2023
11 checks passed
@rustbot rustbot added this to the 1.74.0 milestone Sep 13, 2023
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request Sep 13, 2023
Rollup merge of rust-lang#115815 - bvanjoi:fix-115809, r=oli-obk

fix: return early when has tainted in mir pass

Fixes rust-lang#115809

As in rust-lang#115643, `run_pass` is skipped if the body has tainted errors.

r? `@oli-obk`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ICE: layout.is_sized()
4 participants