Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update Miri #115800

Merged
merged 21 commits into from
Sep 12, 2023
Merged

update Miri #115800

merged 21 commits into from
Sep 12, 2023

Conversation

RalfJung
Copy link
Member

r? @ghost

RalfJung and others added 21 commits September 6, 2023 08:04
```
$ ls /bin/bash
ls: cannot access '/bin/bash': No such file or directory
```

On certain systems, `/bin` and `/usr/bin` are nothing but wastelands, with just `env`around as the last survivor of the great purge. The binaries have cowardly hidden away and only `env` can show us the way to greatness (bash).
❄️
Use `#!/usr/bin/env` shebang

```
$ ls /bin/bash
ls: cannot access '/bin/bash': No such file or directory
```

On certain systems, `/bin` and `/usr/bin` are nothing but wastelands, with just `env`around as the last survivor of the great purge. The binaries have cowardly hidden away and only `env` can show us the way to greatness (bash). ❄️
add subtree-sync label to rustc update PRs

For rust-lang#114157
enforce no-merge policy via triagebot

r? `@rust-lang/miri`
extra ABI tests, in particular for DispatchFromDyn
Implements LLVM intrisics needed to run most SSE2 functions from `core::arch::x86{,_64}`.

Also adds miri tests for those functions (mostly copied from core_arch tests).
Implement some `llvm.x86.sse2.*` intrinsics and add tests

Continuation of rust-lang/miri#2989 with SSE2 intrinsics.

Thankfully, a significant amount of SSE2 functions use `simd_*` intrinsics, which are already implemented in Miri.
@RalfJung RalfJung added the subtree-sync PR updates a subtree (miri, clippy, etc). Ignored by no-merges check label Sep 12, 2023
@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Sep 12, 2023
@rustbot
Copy link
Collaborator

rustbot commented Sep 12, 2023

The Miri subtree was changed

cc @rust-lang/miri

@RalfJung
Copy link
Member Author

@bors r+ p=1

@bors
Copy link
Contributor

bors commented Sep 12, 2023

📌 Commit 8cd31ea has been approved by RalfJung

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 12, 2023
@bors
Copy link
Contributor

bors commented Sep 12, 2023

⌛ Testing commit 8cd31ea with merge d9c8274...

@bors
Copy link
Contributor

bors commented Sep 12, 2023

☀️ Test successful - checks-actions
Approved by: RalfJung
Pushing d9c8274 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Sep 12, 2023
@bors bors merged commit d9c8274 into rust-lang:master Sep 12, 2023
@rustbot rustbot added this to the 1.74.0 milestone Sep 12, 2023
@rust-timer
Copy link
Collaborator

Finished benchmarking commit (d9c8274): comparison URL.

Overall result: no relevant changes - no action needed

@rustbot label: -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)
1.4% [0.7%, 2.2%] 2
Regressions ❌
(secondary)
1.8% [1.2%, 2.3%] 6
Improvements ✅
(primary)
- - 0
Improvements ✅
(secondary)
- - 0
All ❌✅ (primary) 1.4% [0.7%, 2.2%] 2

Cycles

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)
- - 0
Regressions ❌
(secondary)
- - 0
Improvements ✅
(primary)
- - 0
Improvements ✅
(secondary)
-4.4% [-4.4%, -4.4%] 1
All ❌✅ (primary) - - 0

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 631.022s -> 632.182s (0.18%)
Artifact size: 317.92 MiB -> 317.96 MiB (0.01%)

@RalfJung RalfJung deleted the miri branch September 13, 2023 06:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. subtree-sync PR updates a subtree (miri, clippy, etc). Ignored by no-merges check
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants