Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

some inspect improvements #115751

Merged
merged 5 commits into from
Sep 14, 2023
Merged

some inspect improvements #115751

merged 5 commits into from
Sep 14, 2023

Commits on Sep 11, 2023

  1. split GoalEvaluation and CanonicalGoalEvaluation 

    the unnormalized goal is in the callers inference context, while
anything inside of the `CanonicalGoalEvaluation` is inside of
a new one.
    @lcnr
    lcnr committed Sep 11, 2023
    Configuration menu
    Copy the full SHA
    fc452e2 View commit details
    Browse the repository at this point in the history

  2. inspect: handle None in nested

    @lcnr
    lcnr committed Sep 11, 2023
    Configuration menu
    Copy the full SHA
    01f3da6 View commit details
    Browse the repository at this point in the history

  3. revision -> iteration for added_goals_evaluation

    @lcnr
    lcnr committed Sep 11, 2023
    Configuration menu
    Copy the full SHA
    006d599 View commit details
    Browse the repository at this point in the history

  4. inspect: strongly typed CandidateKind

    @lcnr
    lcnr committed Sep 11, 2023
    Configuration menu
    Copy the full SHA
    8225a2e View commit details
    Browse the repository at this point in the history

  5. dedup GoalEvaluationStep and GoalCandidate 

    also handle 2 panics when dumping proof trees for the whole test suite

- need to actually tell the proof tree builder about overflow
- need to handle a recursion_limit of 0 :<
    @lcnr
    lcnr committed Sep 11, 2023
    Configuration menu
    Copy the full SHA
    eac55ee View commit details
    Browse the repository at this point in the history