Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow loading the SMIR for constants and statics #115749

Merged
merged 1 commit into from
Sep 11, 2023

Conversation

oli-obk
Copy link
Contributor

@oli-obk oli-obk commented Sep 11, 2023

cc rust-lang/project-stable-mir#34

before this PR we were ICEing when trying to access the SMIR of anything other than functions

@rustbot
Copy link
Collaborator

rustbot commented Sep 11, 2023

r? @compiler-errors

(rustbot has picked a reviewer for you, use r? to override)

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Sep 11, 2023
@rustbot
Copy link
Collaborator

rustbot commented Sep 11, 2023

This PR changes Stable MIR

cc @oli-obk, @celinval, @spastorino

@compiler-errors
Copy link
Member

@bors r+ rollup

@bors
Copy link
Contributor

bors commented Sep 11, 2023

📌 Commit c2e7900 has been approved by compiler-errors

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 11, 2023
bors added a commit to rust-lang-ci/rust that referenced this pull request Sep 11, 2023
…iaskrgr

Rollup of 8 pull requests

Successful merges:

 - rust-lang#115548 (Extract parallel operations in `rustc_data_structures::sync` into a new `parallel` submodule)
 - rust-lang#115591 (Add regression test for LLVM 17-rc3 miscompile)
 - rust-lang#115631 (Don't ICE when computing ctype's `repr_nullable_ptr` for possibly-unsized ty)
 - rust-lang#115708 (fix homogeneous_aggregate not ignoring some ZST)
 - rust-lang#115730 (Some more small driver refactors)
 - rust-lang#115749 (Allow loading the SMIR for constants and statics)
 - rust-lang#115757 (Add a test for rust-lang#108030)
 - rust-lang#115761 (Update books)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 2a087be into rust-lang:master Sep 11, 2023
@rustbot rustbot added this to the 1.74.0 milestone Sep 11, 2023
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request Sep 11, 2023
Rollup merge of rust-lang#115749 - oli-obk:smir_consts, r=compiler-errors

Allow loading the SMIR for constants and statics

cc rust-lang/project-stable-mir#34

before this PR we were ICEing when trying to access the SMIR of anything other than functions
@oli-obk oli-obk deleted the smir_consts branch September 22, 2023 15:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants