Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rustdoc: add impl items from aliased type into sidebar #115682

Merged
merged 3 commits into from
Sep 10, 2023
Merged

rustdoc: add impl items from aliased type into sidebar #115682

merged 3 commits into from
Sep 10, 2023

Conversation

notriddle
Copy link
Contributor

@notriddle notriddle commented Sep 8, 2023 •
edited by GuillaumeGomez
Loading

Follow-up of #115201.

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. labels Sep 8, 2023
@GuillaumeGomez GuillaumeGomez mentioned this pull request Sep 9, 2023
Merged
GuillaumeGomez
GuillaumeGomez reviewed Sep 10, 2023
View reviewed changes
src/librustdoc/html/render/context.rs Outdated
}));
}
let mut saw_impls = FxHashSet::default();
v.retain(|i| saw_impls.insert(i.def_id()));
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just thought about it but wouldn't it be better to use saw_impls directly in v.extend(av.iter().filter(|impl_| { ... }? Like that no need to re-run a loop here to remove duplicated items. That should also limit the perf regression.

@GuillaumeGomez
Copy link
Member

I suppose it'll impact performance so let's avoid rollup.

@bors r+ rollup=iffy

@bors
Copy link
Contributor

bors commented Sep 10, 2023

📌 Commit c79b960 has been approved by GuillaumeGomez

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 10, 2023
@bors
Copy link
Contributor

bors commented Sep 10, 2023

⌛ Testing commit c79b960 with merge 9be37f127178eafda298d57a2c0d788cc9a15c78...

@rust-log-analyzer
Copy link
Collaborator

The job armhf-gnu failed! Check out the build log: (web) (plain)

Click to see the possible cause of the failure (guessed by this bot)

@bors
Copy link
Contributor

bors commented Sep 10, 2023

💔 Test failed - checks-actions

@bors bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Sep 10, 2023
@notriddle
Copy link
Contributor Author

Network error in a non-rustdoc test.

@bors retry

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 10, 2023
@bors
Copy link
Contributor

bors commented Sep 10, 2023

⌛ Testing commit c79b960 with merge 030e4d3...

@bors
Copy link
Contributor

bors commented Sep 10, 2023

☀️ Test successful - checks-actions
Approved by: GuillaumeGomez
Pushing 030e4d3 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Sep 10, 2023
@bors bors merged commit 030e4d3 into rust-lang:master Sep 10, 2023
@rustbot rustbot added this to the 1.74.0 milestone Sep 10, 2023
@notriddle notriddle deleted the notriddle/impl-sidebar branch September 10, 2023 23:56
@bors bors mentioned this pull request Sep 11, 2023
Merged
@rust-timer
Copy link
Collaborator

Finished benchmarking commit (030e4d3): comparison URL.

Overall result: ❌ regressions - no action needed

@rustbot label: -perf-regression

Instruction count

This is a highly reliable metric that was used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)		 - - 0
Regressions ❌
(secondary)		 0.5% [0.5%, 0.5%] 1
Improvements ✅
(primary)		 - - 0
Improvements ✅
(secondary)		 - - 0
All ❌✅ (primary) - - 0

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)		 - - 0
Regressions ❌
(secondary)		 - - 0
Improvements ✅
(primary)		 - - 0
Improvements ✅
(secondary)		 -2.9% [-2.9%, -2.9%] 1
All ❌✅ (primary) - - 0

Cycles

This benchmark run did not return any relevant results for this metric.

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 630.509s -> 629.082s (-0.23%)
Artifact size: 317.56 MiB -> 317.60 MiB (0.01%)

@GuillaumeGomez GuillaumeGomez mentioned this pull request Sep 11, 2023
Merged
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Sep 11, 2023
@matthiaskrgr
Rollup merge of rust-lang#115752 - GuillaumeGomez:aliased-type-title,…
9ed6eea 
… r=notriddle

rustdoc: Add missing "Aliased type" title in the sidebar

Follow-up of rust-lang#115682.

The sections title are supposed to be present in the sidebar, we forgot to put this one so I added it into it. I also added the missing newly created `aliased-type` ID into the `DEFAULT_ID_MAP`.

r? `@notriddle`
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request Sep 11, 2023
@rust-timer
Unrolled build for rust-lang#115752
c5f9122 
Rollup merge of rust-lang#115752 - GuillaumeGomez:aliased-type-title, r=notriddle

rustdoc: Add missing "Aliased type" title in the sidebar

Follow-up of rust-lang#115682.

The sections title are supposed to be present in the sidebar, we forgot to put this one so I added it into it. I also added the missing newly created `aliased-type` ID into the `DEFAULT_ID_MAP`.

r? `@notriddle`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GuillaumeGomez GuillaumeGomez GuillaumeGomez approved these changes

Assignees

@GuillaumeGomez GuillaumeGomez

Labels
merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.74.0
Development

Successfully merging this pull request may close these issues.
6 participants
@notriddle @GuillaumeGomez @bors @rust-log-analyzer @rust-timer @rustbot