Inline functions called from add_coverage

[Swatinem]

This removes quite a bit of indirection and duplicated code related to getting the FunctionCoverage.

CC @Zalathar

[rustbot]

r? @fee1-dead

(rustbot has picked a reviewer for you, use r? to override)

[Zalathar]

@rustbot label +A-code-coverage

[Zalathar]

Yeah, these methods were left over from the SSA/LLVM split that was removed in #113355, so getting rid of them makes sense.

[fee1-dead]

I'm not familiar with codegen code.

r? compiler

[Zalathar]

Looks good to me. 👍

[compiler-errors]

@bors r+

[bors]

📌 Commit 2ceea9a has been approved by compiler-errors

It is now in the queue for this repository.

[bors]

⌛ Testing commit 2ceea9a with merge 8c79e8d...

[bors]

☀️ Test successful - checks-actions
Approved by: compiler-errors
Pushing 8c79e8d to master...

[rust-timer]

Finished benchmarking commit (8c79e8d): comparison URL.

Overall result: ❌ regressions - no action needed

@rustbot label: -perf-regression

Instruction count

This is a highly reliable metric that was used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	0.4%	[0.4%, 0.4%]	1
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	-	-	0

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	0.9%	[0.6%, 1.3%]	2
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-1.2%	[-1.3%, -1.1%]	2
Improvements ✅ (secondary)	-2.2%	[-3.1%, -1.4%]	3
All ❌✅ (primary)	-0.1%	[-1.3%, 1.3%]	4

Cycles

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-0.6%	[-0.7%, -0.4%]	2
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	-0.6%	[-0.7%, -0.4%]	2

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 632.335s -> 630.996s (-0.21%)
Artifact size: 316.60 MiB -> 316.52 MiB (-0.03%)