rustpkg: CrateId cleanup #11478
Merged
rustpkg: CrateId cleanup #11478
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks good. Could we switch fully to semver, though, rather than using string version names? So it'd be |
|
(Needs a rebase too.) |
|
We shouldn't switch only to SemVer because the version might be a branch or revid. Or at least that was the intent. |
| pub fn system_library(sysroot: &Path, crate_id: &str) -> Option<Path> { | ||
| let (lib_name, version) = split_crate_id(crate_id); | ||
| library_in(lib_name, &version, &sysroot.join(relative_target_lib_path(host_triple()))) | ||
| // rustc doesn't use target-specific subdirectories |
There was a problem hiding this comment.
This comment should be removed, see https://github.com/mozilla/rust/pull/11338/files
There was a problem hiding this comment.
Right, forgot to remove it when I rebased it. I'll push corrected commit soon.
|
Test currently fails because rustpkg tries to find |
|
Rebased; it now passes all tests. |
|
@klutzy needs another rebase. |
rustpkg accessed git repo to read tags and guess package version, but it's not quite useful: version can be given explicitly by user, and implicit guess may cause confusions.
Currently rustpkg doesn't use SemanticVersion or Tagged, so they are removed. Remaining variants are replaced by `Option<~str>`.
Previously rustpkg tried to parse filenames to find crate. Now ue use deterministic hashes, so it becomes possible to directly construct filename and check if the file exists.
There is no significant difference between `rustpkg::crate_id::CrateId` and `syntax::crateid::CrateId`. rustpkg's one is replaced by syntax's one.
|
Rebased! |
bors
added a commit
that referenced
this pull request
Jan 22, 2014
This patchset consists of three parts: - rustpkg doesn't guess crate version if it is not given by user. - `rustpkg::version::Version` is replaced by `Option<~str>`. It removes some semantic versioning portions which is not currently used. (cc #8405 and #11396) `rustpkg::crate_id::CrateId` is also replaced by `syntax::crateid::CrateId`. - rustpkg now computes hash to find crate, instead of manual filename parse. cc @metajack
bors
added a commit
that referenced
this pull request
Jan 24, 2014
This patchset consists of three parts: - rustpkg doesn't guess crate version if it is not given by user. - `rustpkg::version::Version` is replaced by `Option<~str>`. It removes some semantic versioning portions which is not currently used. (cc #8405 and #11396) `rustpkg::crate_id::CrateId` is also replaced by `syntax::crateid::CrateId`. - rustpkg now computes hash to find crate, instead of manual filename parse. cc @metajack
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patchset consists of three parts:
rustpkg::version::Versionis replaced byOption<~str>.It removes some semantic versioning portions which is not currently used.
(cc rustpkg should support semantic versions #8405 and Semantically version the language specification, compiler, and libraries #11396)
rustpkg::crate_id::CrateIdis also replaced bysyntax::crateid::CrateId.cc @metajack