Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use upvar_tys in more places, make it return a list #114079

Merged
merged 1 commit into from
Aug 2, 2023
Merged

Use upvar_tys in more places, make it return a list #114079

merged 1 commit into from
Aug 2, 2023

Conversation

compiler-errors
Copy link
Member

@compiler-errors compiler-errors commented Jul 26, 2023 •
edited
Loading

Just a cleanup that fell out of a PR that I was gonna write, but that PR kinda got stuck.

@rustbot
Copy link
Collaborator

rustbot commented Jul 26, 2023

r? @b-naber

(rustbot has picked a reviewer for you, use r? to override)

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Jul 26, 2023
@rustbot
Copy link
Collaborator

rustbot commented Jul 26, 2023

Some changes occurred to MIR optimizations

cc @rust-lang/wg-mir-opt

@compiler-errors
Copy link
Member Author

probably shouldnt matter, but let's see

@bors try @rust-timer queue

@rust-timer

This comment has been minimized.

Sign in to view
@rustbot rustbot added the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Jul 26, 2023
@compiler-errors compiler-errors added C-cleanup Category: PRs that clean code up or issues documenting cleanup. and removed S-waiting-on-perf Status: Waiting on a perf run to be completed. labels Jul 26, 2023
@bors
Copy link
Contributor

bors commented Jul 26, 2023

⌛ Trying commit 59571266f44c3b285770aa0018d0da88679fd937 with merge 5eb97f48bed6d5a9258294931ebb9b872c8d2ba9...

@bors
Copy link
Contributor

bors commented Jul 26, 2023

☀️ Try build successful - checks-actions
Build commit: 5eb97f48bed6d5a9258294931ebb9b872c8d2ba9 (5eb97f48bed6d5a9258294931ebb9b872c8d2ba9)

@rust-timer

This comment has been minimized.

Sign in to view
@rust-timer
Copy link
Collaborator

Finished benchmarking commit (5eb97f48bed6d5a9258294931ebb9b872c8d2ba9): comparison URL.

Overall result: ❌✅ regressions and improvements - no action needed

Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. While you can manually mark this PR as fit for rollup, we strongly recommend not doing so since this PR may lead to changes in compiler perf.

@bors rollup=never
@rustbot label: -S-waiting-on-perf -perf-regression

Instruction count

This is a highly reliable metric that was used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)		 - - 0
Regressions ❌
(secondary)		 1.0% [1.0%, 1.0%] 1
Improvements ✅
(primary)		 - - 0
Improvements ✅
(secondary)		 -1.2% [-1.2%, -1.2%] 1
All ❌✅ (primary) - - 0

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)		 - - 0
Regressions ❌
(secondary)		 - - 0
Improvements ✅
(primary)		 -4.0% [-4.0%, -4.0%] 1
Improvements ✅
(secondary)		 - - 0
All ❌✅ (primary) -4.0% [-4.0%, -4.0%] 1

Cycles

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)		 - - 0
Regressions ❌
(secondary)		 2.1% [2.1%, 2.1%] 1
Improvements ✅
(primary)		 - - 0
Improvements ✅
(secondary)		 -1.8% [-1.8%, -1.8%] 1
All ❌✅ (primary) - - 0

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 650.399s -> 651.262s (0.13%)

@oli-obk
Copy link
Contributor

oli-obk commented Aug 2, 2023

@bors r+ rollup

@bors
Copy link
Contributor

bors commented Aug 2, 2023

📌 Commit 99969d2 has been approved by oli-obk

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 2, 2023
Noratrieb added a commit to Noratrieb/rust that referenced this pull request Aug 2, 2023
@Noratrieb
Rollup merge of rust-lang#114079 - compiler-errors:closure-upvars, r=…
3edc51b 
…oli-obk

Use `upvar_tys` in more places, make it return a list

Just a cleanup that fell out of a PR that I was gonna write, but that PR kinda got stuck.
@Noratrieb Noratrieb mentioned this pull request Aug 2, 2023
Closed
Noratrieb added a commit to Noratrieb/rust that referenced this pull request Aug 2, 2023
@Noratrieb
Rollup merge of rust-lang#114079 - compiler-errors:closure-upvars, r=…
3da2470 
…oli-obk

Use `upvar_tys` in more places, make it return a list

Just a cleanup that fell out of a PR that I was gonna write, but that PR kinda got stuck.
@Noratrieb Noratrieb mentioned this pull request Aug 2, 2023
Closed
@Noratrieb Noratrieb mentioned this pull request Aug 2, 2023
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Aug 2, 2023
@bors
Auto merge of rust-lang#114368 - Nilstrieb:rollup-pgvm9cf, r=Nilstrieb
7637653 
Rollup of 5 pull requests

Successful merges:

 - rust-lang#114079 (Use `upvar_tys` in more places, make it return a list)
 - rust-lang#114166 (Add regression test for resolving `--extern libc=test.rlib`)
 - rust-lang#114321 (get auto traits for parallel rustc)
 - rust-lang#114335 (fix and extend ptr_comparison test)
 - rust-lang#114347 (x.py print more detailed format files and untracked files count)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 46f6b05 into rust-lang:master Aug 2, 2023
@rustbot rustbot added this to the 1.73.0 milestone Aug 2, 2023
@compiler-errors compiler-errors deleted the closure-upvars branch August 11, 2023 19:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oli-obk oli-obk oli-obk left review comments

Assignees

@b-naber b-naber

Labels
C-cleanup Category: PRs that clean code up or issues documenting cleanup. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.73.0
Development

Successfully merging this pull request may close these issues.
6 participants
@compiler-errors @rustbot @rust-timer @bors @oli-obk @b-naber