interpret: make Place always refer to the current frame [perf experiment] #113964

RalfJung · 2023-07-22T14:45:53Z

The place storing a frame-idx was only a band-aid, since with concurrency we still would not have any idea which thread's stack the place refers to. So let's just accept that places must be short-lived, and use MemPlace in situations where stack frames are being pushed or popped.

This is a perf experiment.
(If perf looks good, a bit more cleanup should be done to consistently use MPlaceTy for the return place in the various functions for shims and hooks.)

r? @ghost

rustbot · 2023-07-22T14:46:00Z

Some changes occurred to the CTFE / Miri engine

cc @rust-lang/miri

Some changes occurred to MIR optimizations

cc @rust-lang/wg-mir-opt

RalfJung · 2023-07-22T14:46:37Z

@bors try @rust-timer queue

bors · 2023-07-22T14:46:45Z

⌛ Trying commit dcd018c with merge 8d2bed6d76e99526a3999cae306609362c9b7994...

rust-log-analyzer · 2023-07-22T14:52:03Z

The job mingw-check failed! Check out the build log: (web) (plain)

Click to see the possible cause of the failure (guessed by this bot)

##[group]Run git config --global core.autocrlf false
git config --global core.autocrlf false
shell: /usr/bin/bash --noprofile --norc -e -o pipefail {0}
env:
  PR_CI_JOB: 1
  CARGO_REGISTRIES_CRATES_IO_PROTOCOL: sparse
  HEAD_SHA: dcd018c19ed28522abba7ac356489f170c4bc670
  SCCACHE_BUCKET: rust-lang-ci-sccache2
  TOOLSTATE_REPO: https://github.com/rust-lang-nursery/rust-toolstate
---
  lfs: false
  submodules: false
  set-safe-directory: true
env:
  PR_CI_JOB: 1
  CARGO_REGISTRIES_CRATES_IO_PROTOCOL: sparse
  HEAD_SHA: dcd018c19ed28522abba7ac356489f170c4bc670
  SCCACHE_BUCKET: rust-lang-ci-sccache2
  TOOLSTATE_REPO: https://github.com/rust-lang-nursery/rust-toolstate
---
##[group]Run src/ci/scripts/setup-environment.sh
src/ci/scripts/setup-environment.sh
shell: /usr/bin/bash --noprofile --norc -e -o pipefail {0}
env:
  PR_CI_JOB: 1
  CARGO_REGISTRIES_CRATES_IO_PROTOCOL: sparse
  HEAD_SHA: dcd018c19ed28522abba7ac356489f170c4bc670
  SCCACHE_BUCKET: rust-lang-ci-sccache2
  TOOLSTATE_REPO: https://github.com/rust-lang-nursery/rust-toolstate
---
##[group]Run src/ci/scripts/should-skip-this.sh
src/ci/scripts/should-skip-this.sh
shell: /usr/bin/bash --noprofile --norc -e -o pipefail {0}
env:
  PR_CI_JOB: 1
  CARGO_REGISTRIES_CRATES_IO_PROTOCOL: sparse
  HEAD_SHA: dcd018c19ed28522abba7ac356489f170c4bc670
  SCCACHE_BUCKET: rust-lang-ci-sccache2
  TOOLSTATE_REPO: https://github.com/rust-lang-nursery/rust-toolstate
---
##[group]Run src/ci/scripts/verify-channel.sh
src/ci/scripts/verify-channel.sh
shell: /usr/bin/bash --noprofile --norc -e -o pipefail {0}
env:
  PR_CI_JOB: 1
  CARGO_REGISTRIES_CRATES_IO_PROTOCOL: sparse
  HEAD_SHA: dcd018c19ed28522abba7ac356489f170c4bc670
  SCCACHE_BUCKET: rust-lang-ci-sccache2
  TOOLSTATE_REPO: https://github.com/rust-lang-nursery/rust-toolstate
  TOOLSTATE_REPO: https://github.com/rust-lang-nursery/rust-toolstate
  CACHE_DOMAIN: ci-caches.rust-lang.org
  IMAGE: mingw-check
##[endgroup]
##[group]Run src/ci/scripts/collect-cpu-stats.sh
src/ci/scripts/collect-cpu-stats.sh
shell: /usr/bin/bash --noprofile --norc -e -o pipefail {0}
env:
  PR_CI_JOB: 1
  CARGO_REGISTRIES_CRATES_IO_PROTOCOL: sparse
  HEAD_SHA: dcd018c19ed28522abba7ac356489f170c4bc670
  SCCACHE_BUCKET: rust-lang-ci-sccache2
  TOOLSTATE_REPO: https://github.com/rust-lang-nursery/rust-toolstate
---
##[group]Run src/ci/scripts/install-sccache.sh
src/ci/scripts/install-sccache.sh
shell: /usr/bin/bash --noprofile --norc -e -o pipefail {0}
env:
  PR_CI_JOB: 1
  CARGO_REGISTRIES_CRATES_IO_PROTOCOL: sparse
  HEAD_SHA: dcd018c19ed28522abba7ac356489f170c4bc670
  SCCACHE_BUCKET: rust-lang-ci-sccache2
  TOOLSTATE_REPO: https://github.com/rust-lang-nursery/rust-toolstate
  TOOLSTATE_REPO: https://github.com/rust-lang-nursery/rust-toolstate
  CACHE_DOMAIN: ci-caches.rust-lang.org
  IMAGE: mingw-check
##[endgroup]
##[group]Run src/ci/scripts/select-xcode.sh
src/ci/scripts/select-xcode.sh
shell: /usr/bin/bash --noprofile --norc -e -o pipefail {0}
env:
  PR_CI_JOB: 1
  CARGO_REGISTRIES_CRATES_IO_PROTOCOL: sparse
  HEAD_SHA: dcd018c19ed28522abba7ac356489f170c4bc670
  SCCACHE_BUCKET: rust-lang-ci-sccache2
  TOOLSTATE_REPO: https://github.com/rust-lang-nursery/rust-toolstate
  TOOLSTATE_REPO: https://github.com/rust-lang-nursery/rust-toolstate
  CACHE_DOMAIN: ci-caches.rust-lang.org
  IMAGE: mingw-check
##[endgroup]
##[group]Run src/ci/scripts/install-clang.sh
src/ci/scripts/install-clang.sh
shell: /usr/bin/bash --noprofile --norc -e -o pipefail {0}
env:
  PR_CI_JOB: 1
  CARGO_REGISTRIES_CRATES_IO_PROTOCOL: sparse
  HEAD_SHA: dcd018c19ed28522abba7ac356489f170c4bc670
  SCCACHE_BUCKET: rust-lang-ci-sccache2
  TOOLSTATE_REPO: https://github.com/rust-lang-nursery/rust-toolstate
  TOOLSTATE_REPO: https://github.com/rust-lang-nursery/rust-toolstate
  CACHE_DOMAIN: ci-caches.rust-lang.org
  IMAGE: mingw-check
##[endgroup]
##[group]Run src/ci/scripts/install-wix.sh
src/ci/scripts/install-wix.sh
shell: /usr/bin/bash --noprofile --norc -e -o pipefail {0}
env:
  PR_CI_JOB: 1
  CARGO_REGISTRIES_CRATES_IO_PROTOCOL: sparse
  HEAD_SHA: dcd018c19ed28522abba7ac356489f170c4bc670
  SCCACHE_BUCKET: rust-lang-ci-sccache2
  TOOLSTATE_REPO: https://github.com/rust-lang-nursery/rust-toolstate
  TOOLSTATE_REPO: https://github.com/rust-lang-nursery/rust-toolstate
  CACHE_DOMAIN: ci-caches.rust-lang.org
  IMAGE: mingw-check
##[endgroup]
##[group]Run src/ci/scripts/disable-git-crlf-conversion.sh
src/ci/scripts/disable-git-crlf-conversion.sh
shell: /usr/bin/bash --noprofile --norc -e -o pipefail {0}
env:
  PR_CI_JOB: 1
  CARGO_REGISTRIES_CRATES_IO_PROTOCOL: sparse
  HEAD_SHA: dcd018c19ed28522abba7ac356489f170c4bc670
  SCCACHE_BUCKET: rust-lang-ci-sccache2
  TOOLSTATE_REPO: https://github.com/rust-lang-nursery/rust-toolstate
---
##[group]Run src/ci/scripts/install-msys2.sh
src/ci/scripts/install-msys2.sh
shell: /usr/bin/bash --noprofile --norc -e -o pipefail {0}
env:
  PR_CI_JOB: 1
  CARGO_REGISTRIES_CRATES_IO_PROTOCOL: sparse
  HEAD_SHA: dcd018c19ed28522abba7ac356489f170c4bc670
  SCCACHE_BUCKET: rust-lang-ci-sccache2
  TOOLSTATE_REPO: https://github.com/rust-lang-nursery/rust-toolstate
  TOOLSTATE_REPO: https://github.com/rust-lang-nursery/rust-toolstate
  CACHE_DOMAIN: ci-caches.rust-lang.org
  IMAGE: mingw-check
##[endgroup]
##[group]Run src/ci/scripts/install-mingw.sh
src/ci/scripts/install-mingw.sh
shell: /usr/bin/bash --noprofile --norc -e -o pipefail {0}
env:
  PR_CI_JOB: 1
  CARGO_REGISTRIES_CRATES_IO_PROTOCOL: sparse
  HEAD_SHA: dcd018c19ed28522abba7ac356489f170c4bc670
  SCCACHE_BUCKET: rust-lang-ci-sccache2
  TOOLSTATE_REPO: https://github.com/rust-lang-nursery/rust-toolstate
  TOOLSTATE_REPO: https://github.com/rust-lang-nursery/rust-toolstate
  CACHE_DOMAIN: ci-caches.rust-lang.org
  IMAGE: mingw-check
##[endgroup]
##[group]Run src/ci/scripts/install-ninja.sh
src/ci/scripts/install-ninja.sh
shell: /usr/bin/bash --noprofile --norc -e -o pipefail {0}
env:
  PR_CI_JOB: 1
  CARGO_REGISTRIES_CRATES_IO_PROTOCOL: sparse
  HEAD_SHA: dcd018c19ed28522abba7ac356489f170c4bc670
  SCCACHE_BUCKET: rust-lang-ci-sccache2
  TOOLSTATE_REPO: https://github.com/rust-lang-nursery/rust-toolstate
  TOOLSTATE_REPO: https://github.com/rust-lang-nursery/rust-toolstate
  CACHE_DOMAIN: ci-caches.rust-lang.org
  IMAGE: mingw-check
##[endgroup]
##[group]Run src/ci/scripts/enable-docker-ipv6.sh
src/ci/scripts/enable-docker-ipv6.sh
shell: /usr/bin/bash --noprofile --norc -e -o pipefail {0}
env:
  PR_CI_JOB: 1
  CARGO_REGISTRIES_CRATES_IO_PROTOCOL: sparse
  HEAD_SHA: dcd018c19ed28522abba7ac356489f170c4bc670
  SCCACHE_BUCKET: rust-lang-ci-sccache2
  TOOLSTATE_REPO: https://github.com/rust-lang-nursery/rust-toolstate
---
##[group]Run src/ci/scripts/disable-git-crlf-conversion.sh
src/ci/scripts/disable-git-crlf-conversion.sh
shell: /usr/bin/bash --noprofile --norc -e -o pipefail {0}
env:
  PR_CI_JOB: 1
  CARGO_REGISTRIES_CRATES_IO_PROTOCOL: sparse
  HEAD_SHA: dcd018c19ed28522abba7ac356489f170c4bc670
  SCCACHE_BUCKET: rust-lang-ci-sccache2
  TOOLSTATE_REPO: https://github.com/rust-lang-nursery/rust-toolstate
  TOOLSTATE_REPO: https://github.com/rust-lang-nursery/rust-toolstate
  CACHE_DOMAIN: ci-caches.rust-lang.org
  IMAGE: mingw-check
##[endgroup]
##[group]Run src/ci/scripts/verify-line-endings.sh
src/ci/scripts/verify-line-endings.sh
shell: /usr/bin/bash --noprofile --norc -e -o pipefail {0}
env:
  PR_CI_JOB: 1
  CARGO_REGISTRIES_CRATES_IO_PROTOCOL: sparse
  HEAD_SHA: dcd018c19ed28522abba7ac356489f170c4bc670
  SCCACHE_BUCKET: rust-lang-ci-sccache2
  TOOLSTATE_REPO: https://github.com/rust-lang-nursery/rust-toolstate
  TOOLSTATE_REPO: https://github.com/rust-lang-nursery/rust-toolstate
  CACHE_DOMAIN: ci-caches.rust-lang.org
  IMAGE: mingw-check
##[endgroup]
##[group]Run src/ci/scripts/verify-backported-commits.sh
src/ci/scripts/verify-backported-commits.sh
shell: /usr/bin/bash --noprofile --norc -e -o pipefail {0}
env:
  PR_CI_JOB: 1
  CARGO_REGISTRIES_CRATES_IO_PROTOCOL: sparse
  HEAD_SHA: dcd018c19ed28522abba7ac356489f170c4bc670
  SCCACHE_BUCKET: rust-lang-ci-sccache2
  TOOLSTATE_REPO: https://github.com/rust-lang-nursery/rust-toolstate
---
##[group]Run src/ci/scripts/verify-stable-version-number.sh
src/ci/scripts/verify-stable-version-number.sh
shell: /usr/bin/bash --noprofile --norc -e -o pipefail {0}
env:
  PR_CI_JOB: 1
  CARGO_REGISTRIES_CRATES_IO_PROTOCOL: sparse
  HEAD_SHA: dcd018c19ed28522abba7ac356489f170c4bc670
  SCCACHE_BUCKET: rust-lang-ci-sccache2
  TOOLSTATE_REPO: https://github.com/rust-lang-nursery/rust-toolstate
---
##[group]Run src/ci/scripts/run-build-from-ci.sh
src/ci/scripts/run-build-from-ci.sh
shell: /usr/bin/bash --noprofile --norc -e -o pipefail {0}
env:
  PR_CI_JOB: 1
  CARGO_REGISTRIES_CRATES_IO_PROTOCOL: sparse
  HEAD_SHA: dcd018c19ed28522abba7ac356489f170c4bc670
  SCCACHE_BUCKET: rust-lang-ci-sccache2
  TOOLSTATE_REPO: https://github.com/rust-lang-nursery/rust-toolstate
---
     |
1214 |         place: &PlaceTy<'tcx, Provenance>,
     |                ^^^^^^^^^^^^^^^^^^^^^^^^^^
     |                |
     |                expected `MPlaceTy<'tcx, Provenance>`, found `PlaceTy<'tcx, Provenance>`
     |
     |
     = note: expected signature `fn(&mut rustc_const_eval::interpret::InterpCx<'mir, 'tcx, machine::MiriMachine<'mir, 'tcx>>, &rustc_const_eval::interpret::MPlaceTy<'tcx, machine::Provenance>) -> Result<_, _>`
                found signature `fn(&mut rustc_const_eval::interpret::InterpCx<'mir, 'tcx, machine::MiriMachine<'mir, 'tcx>>, &rustc_const_eval::interpret::PlaceTy<'tcx, machine::Provenance>) -> Result<_, _>`
error[E0308]: mismatched types
   --> src/tools/miri/src/helpers.rs:366:39
    |
366 |         this.push_stack_frame(f, mir, &dest, stack_pop)?;
366 |         this.push_stack_frame(f, mir, &dest, stack_pop)?;
    |              ----------------         ^^^^^ expected `&MPlaceTy<'_, Provenance>`, found `&PlaceTy<'_, Provenance>`
    |              arguments to this method are incorrect
    |
    = note: expected reference `&rustc_const_eval::interpret::MPlaceTy<'_, machine::Provenance>`
               found reference `&rustc_const_eval::interpret::PlaceTy<'tcx, machine::Provenance>`
---

error[E0308]: mismatched types
   --> src/tools/miri/src/helpers.rs:744:27
    |
744 |         this.check_mplace(mplace)?;
    |              ------------ ^^^^^^ expected `&MPlaceTy<'_, Provenance>`, found `MPlaceTy<'_, Provenance>`
    |              arguments to this method are incorrect
    |
    = note: expected reference `&rustc_const_eval::interpret::MPlaceTy<'_, machine::Provenance>`
                  found struct `rustc_const_eval::interpret::MPlaceTy<'_, machine::Provenance>`
                  found struct `rustc_const_eval::interpret::MPlaceTy<'_, machine::Provenance>`
note: method defined here
   --> /checkout/compiler/rustc_const_eval/src/interpret/place.rs:384:12
    |
384 |     pub fn check_mplace(&self, mplace: &MPlaceTy<'tcx, M::Provenance>) -> InterpResult<'tcx> {
help: consider borrowing here
    |
    |
744 |         this.check_mplace(&mplace)?;

error[E0277]: the `?` operator can only be applied to values that implement `std::ops::Try`
   --> src/tools/miri/src/machine.rs:915:20
    |
    |
915 |         let args = ecx.copy_fn_args(args)?; // FIXME: Should `InPlace` arguments be reset to uninit?
    |                    ^^^^^^^^^^^^^^^^^^^^^^^ the `?` operator cannot be applied to type `Vec<rustc_const_eval::interpret::OpTy<'_, machine::Provenance>>`
    = help: the trait `std::ops::Try` is not implemented for `Vec<rustc_const_eval::interpret::OpTy<'_, machine::Provenance>>`


error[E0277]: the size for values of type `[rustc_const_eval::interpret::OpTy<'_, machine::Provenance>]` cannot be known at compilation time
    |
    |
915 |         let args = ecx.copy_fn_args(args)?; // FIXME: Should `InPlace` arguments be reset to uninit?
    |
    = help: the trait `std::marker::Sized` is not implemented for `[rustc_const_eval::interpret::OpTy<'_, machine::Provenance>]`
    = note: all local variables must have a statically known size
    = help: unsized locals are gated as an unstable feature
    = help: unsized locals are gated as an unstable feature

error[E0277]: the size for values of type `[rustc_const_eval::interpret::OpTy<'_, machine::Provenance>]` cannot be known at compilation time
    |
    |
915 |         let args = ecx.copy_fn_args(args)?; // FIXME: Should `InPlace` arguments be reset to uninit?
    |
    = help: the trait `std::marker::Sized` is not implemented for `[rustc_const_eval::interpret::OpTy<'_, machine::Provenance>]`
    = note: all local variables must have a statically known size
    = help: unsized locals are gated as an unstable feature
    = help: unsized locals are gated as an unstable feature

error[E0277]: the size for values of type `[rustc_const_eval::interpret::OpTy<'_, machine::Provenance>]` cannot be known at compilation time
    |
    |
915 |         let args = ecx.copy_fn_args(args)?; // FIXME: Should `InPlace` arguments be reset to uninit?
    |
    = help: the trait `std::marker::Sized` is not implemented for `[rustc_const_eval::interpret::OpTy<'_, machine::Provenance>]`
note: required by a bound in `std::ops::ControlFlow::Break`
   --> /checkout/library/core/src/ops/control_flow.rs:85:25
---
    Checking serde v1.0.164
error[E0277]: the `?` operator can only be applied to values that implement `std::ops::Try`
  --> src/tools/miri/src/shims/mod.rs:44:24
   |
44 |             let args = this.copy_fn_args(args)?;
   |                        ^^^^^^^^^^^^^^^^^^^^^^^^ the `?` operator cannot be applied to type `Vec<rustc_const_eval::interpret::OpTy<'_, machine::Provenance>>`
   = help: the trait `std::ops::Try` is not implemented for `Vec<rustc_const_eval::interpret::OpTy<'_, machine::Provenance>>`


error[E0277]: the size for values of type `[rustc_const_eval::interpret::OpTy<'_, machine::Provenance>]` cannot be known at compilation time
   |
   |
44 |             let args = this.copy_fn_args(args)?;
   |
   = help: the trait `std::marker::Sized` is not implemented for `[rustc_const_eval::interpret::OpTy<'_, machine::Provenance>]`
   = note: all local variables must have a statically known size
   = help: unsized locals are gated as an unstable feature
   = help: unsized locals are gated as an unstable feature

error[E0277]: the size for values of type `[rustc_const_eval::interpret::OpTy<'_, machine::Provenance>]` cannot be known at compilation time
   |
   |
44 |             let args = this.copy_fn_args(args)?;
   |
   = help: the trait `std::marker::Sized` is not implemented for `[rustc_const_eval::interpret::OpTy<'_, machine::Provenance>]`
   = note: all local variables must have a statically known size
   = help: unsized locals are gated as an unstable feature
   = help: unsized locals are gated as an unstable feature

error[E0277]: the size for values of type `[rustc_const_eval::interpret::OpTy<'_, machine::Provenance>]` cannot be known at compilation time
   |
   |
44 |             let args = this.copy_fn_args(args)?;
   |
   = help: the trait `std::marker::Sized` is not implemented for `[rustc_const_eval::interpret::OpTy<'_, machine::Provenance>]`
note: required by a bound in `std::ops::ControlFlow::Break`
  --> /checkout/library/core/src/ops/control_flow.rs:85:25
---

error[E0277]: the `?` operator can only be applied to values that implement `std::ops::Try`
  --> src/tools/miri/src/shims/mod.rs:59:24
   |
59 |             let args = this.copy_fn_args(args)?; // FIXME: Should `InPlace` arguments be reset to uninit?
   |                        ^^^^^^^^^^^^^^^^^^^^^^^^ the `?` operator cannot be applied to type `Vec<rustc_const_eval::interpret::OpTy<'_, machine::Provenance>>`
   = help: the trait `std::ops::Try` is not implemented for `Vec<rustc_const_eval::interpret::OpTy<'_, machine::Provenance>>`


error[E0277]: the size for values of type `[rustc_const_eval::interpret::OpTy<'_, machine::Provenance>]` cannot be known at compilation time
   |
   |
59 |             let args = this.copy_fn_args(args)?; // FIXME: Should `InPlace` arguments be reset to uninit?
   |
   = help: the trait `std::marker::Sized` is not implemented for `[rustc_const_eval::interpret::OpTy<'_, machine::Provenance>]`
   = note: all local variables must have a statically known size
   = help: unsized locals are gated as an unstable feature
   = help: unsized locals are gated as an unstable feature

error[E0277]: the size for values of type `[rustc_const_eval::interpret::OpTy<'_, machine::Provenance>]` cannot be known at compilation time
   |
   |
59 |             let args = this.copy_fn_args(args)?; // FIXME: Should `InPlace` arguments be reset to uninit?
   |
   = help: the trait `std::marker::Sized` is not implemented for `[rustc_const_eval::interpret::OpTy<'_, machine::Provenance>]`
   = note: all local variables must have a statically known size
   = help: unsized locals are gated as an unstable feature
   = help: unsized locals are gated as an unstable feature

error[E0277]: the size for values of type `[rustc_const_eval::interpret::OpTy<'_, machine::Provenance>]` cannot be known at compilation time
   |
   |
59 |             let args = this.copy_fn_args(args)?; // FIXME: Should `InPlace` arguments be reset to uninit?
   |
   = help: the trait `std::marker::Sized` is not implemented for `[rustc_const_eval::interpret::OpTy<'_, machine::Provenance>]`
note: required by a bound in `std::ops::ControlFlow::Break`
  --> /checkout/library/core/src/ops/control_flow.rs:85:25

bors · 2023-07-22T16:03:47Z

☀️ Try build successful - checks-actions
Build commit: 8d2bed6d76e99526a3999cae306609362c9b7994 (8d2bed6d76e99526a3999cae306609362c9b7994)

rust-timer · 2023-07-22T20:05:41Z

Finished benchmarking commit (8d2bed6d76e99526a3999cae306609362c9b7994): comparison URL.

Overall result: ❌ regressions - ACTION NEEDED

Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. While you can manually mark this PR as fit for rollup, we strongly recommend not doing so since this PR may lead to changes in compiler perf.

Next Steps: If you can justify the regressions found in this try perf run, please indicate this with @rustbot label: +perf-regression-triaged along with sufficient written justification. If you cannot justify the regressions please fix the regressions and do another perf run. If the next run shows neutral or positive results, the label will be automatically removed.

@bors rollup=never
@rustbot label: -S-waiting-on-perf +perf-regression

Instruction count

This is a highly reliable metric that was used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	3.7%	[0.3%, 4.8%]	7
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	-	-	0

Max RSS (memory usage)

This benchmark run did not return any relevant results for this metric.

Cycles

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	2.6%	[2.1%, 3.5%]	4
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	-	-	0

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 650.262s -> 650.688s (0.07%)

RalfJung · 2023-07-23T16:16:03Z

Okay, looks like this is quite measurable in the stress test, so I guess we can keep it. We have to be careful to not switch threads at the wrong time... but then with this PR we have to be careful to not push/pop at the wrong time, so it's not like that is significantly more robust.

interpret: make Place always refer to the current frame

dcd018c

This comment was marked as outdated.

Sign in to view

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Jul 22, 2023

This comment was marked as outdated.

Sign in to view

This comment has been minimized.

Sign in to view

rustbot added the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Jul 22, 2023

This comment has been minimized.

Sign in to view

rustbot added perf-regression Performance regression. and removed S-waiting-on-perf Status: Waiting on a perf run to be completed. labels Jul 22, 2023

RalfJung closed this Jul 23, 2023

RalfJung mentioned this pull request Mar 4, 2024

interpret: avoid a long-lived PlaceTy in stack frames #121985

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

interpret: make Place always refer to the current frame [perf experiment] #113964

interpret: make Place always refer to the current frame [perf experiment] #113964

RalfJung commented Jul 22, 2023 •

edited

Loading

This comment was marked as outdated.

rustbot commented Jul 22, 2023

This comment was marked as outdated.

RalfJung commented Jul 22, 2023

This comment has been minimized.

bors commented Jul 22, 2023

rust-log-analyzer commented Jul 22, 2023

bors commented Jul 22, 2023

This comment has been minimized.

rust-timer commented Jul 22, 2023

RalfJung commented Jul 23, 2023

interpret: make Place always refer to the current frame [perf experiment] #113964

interpret: make Place always refer to the current frame [perf experiment] #113964

Conversation

RalfJung commented Jul 22, 2023 • edited Loading

This comment was marked as outdated.

rustbot commented Jul 22, 2023

This comment was marked as outdated.

RalfJung commented Jul 22, 2023

This comment has been minimized.

bors commented Jul 22, 2023

rust-log-analyzer commented Jul 22, 2023

bors commented Jul 22, 2023

This comment has been minimized.

rust-timer commented Jul 22, 2023

Overall result: ❌ regressions - ACTION NEEDED

Instruction count

Max RSS (memory usage)

Cycles

Binary size

RalfJung commented Jul 23, 2023

RalfJung commented Jul 22, 2023 •

edited

Loading