-
Notifications
You must be signed in to change notification settings - Fork 12.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Copy stage0 rustc
binaries to stage0-sysroot
#113341
Conversation
(rustbot has picked a reviewer for you, use r? to override) |
@bors try @rust-timer queue |
This comment has been minimized.
This comment has been minimized.
⌛ Trying commit bb8c497 with merge 4326a1077ebab6adbc37556763a8fd302d86f154... |
☀️ Try build successful - checks-actions |
This comment has been minimized.
This comment has been minimized.
Finished benchmarking commit (4326a1077ebab6adbc37556763a8fd302d86f154): comparison URL. Overall result: no relevant changes - no action neededBenchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. While you can manually mark this PR as fit for rollup, we strongly recommend not doing so since this PR may lead to changes in compiler perf. @bors rollup=never Instruction countThis benchmark run did not return any relevant results for this metric. Max RSS (memory usage)ResultsThis is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
CyclesResultsThis is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
Binary sizeThis benchmark run did not return any relevant results for this metric. Bootstrap: 653.846s -> 654.334s (0.07%) |
Ok, perf seems to work, hopefully the conservative approach taken here will not break it. @rustbot ready |
@bors r+ rollup=iffy |
☀️ Test successful - checks-actions |
Finished benchmarking commit (1065d87): comparison URL. Overall result: no relevant changes - no action needed@rustbot label: -perf-regression Instruction countThis benchmark run did not return any relevant results for this metric. Max RSS (memory usage)ResultsThis is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
CyclesThis benchmark run did not return any relevant results for this metric. Binary sizeThis benchmark run did not return any relevant results for this metric. Bootstrap: 657.324s -> 659.399s (0.32%) |
This is now done by the bootstrapping process. See rust-lang/rust#113341.
This is now done by the bootstrapping process. See rust-lang/rust#113341.
… (rust-lang/backtrace#550) This is now done by the bootstrapping process. See rust-lang/rust#113341.
This is basically a revival of #101711 and #107956, with an added check that the full sysroot will only be created if the original rustc comes from
stage0/bin
.What is/should be tested:
rustup toolchain link stage0
(new libstd is used correctly)python3 x.py fmt dist --stage 0
config.toml
(in this case this logic is ignored)(Hopefully) fixes: #101691
This is not the "end all, be all" solution to this problem, but as long as it resolves the basic use-case, and doesn't break perfbot, I say ship it. This code will probably be nuked anyway Soon™ because of the stage redesign.