-
Notifications
You must be signed in to change notification settings - Fork 13k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Utility functions #1129
Utility functions #1129
Conversation
Ah, well, I have finally decided to add the library to the pull request. |
I should add that this library is my first real foray into Rust. I fully expect numerous efficiencies, unexpected memory copies, etc. Please do not hesitate to point me to any error I may have committed. |
Actually, there is a difference between |
So this looks really great! Thank you. I made a number of comments, but mostly on style. One thing to note is that functions without naturaldocs comments (starting with "Function:") will not show up in the library documentation at all, so every public function needs documentation. This patch does establish a naming convention 'loop' and a protocol (return bool) for iterators that can break early, which I guess is as good as any. I would very much like it if you provided tests for std::rope. They would live in src/test/stdtest/rope.rs |
… opportunity to add function loop
… to improve doc of my new functions.
Normally, everything is done, except for the explicit |
Thanks, Yoric. Integrated. |
A few utility functions that I use in my implementation of ropes.
I will send a separate pull request for ropes once I have finished cleaning up the code.