remove unused field #112677
Merged
remove unused field #112677
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
since DrainFilter no longer continues draining when it's dropped the panic tracking is no longer needed.
|
(rustbot has picked a reviewer for you, use r? to override) |
rustbot
added
S-waiting-on-review
JohnTitor
approved these changes
Jun 26, 2023
|
Feel free to r=me if an approval from libs-contributors is enough to r+ here |
|
Thanks! And sure, contributors can use their r+ rights for things that don't touch the API surface. @bors r=JohnTitor |
bors
added
S-waiting-on-bors
|
@bors rollup |
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Jun 26, 2023
Rollup of 2 pull requests Successful merges: - rust-lang#112677 (remove unused field) - rust-lang#112920 (rustdoc: render generic params & where-clauses of cross-crate assoc tys in impls) r? `@ghost` `@rustbot` modify labels: rollup
|
☔ The latest upstream changes (presumably #113057) made this pull request unmergeable. Please resolve the merge conflicts. |
bors
added
S-waiting-on-author
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Followup to #104455. The field is no longer needed since ExtractIf (previously DrainFilter) doesn't keep draining in its drop impl.