Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't inline functions with unsized args #111424

Merged
merged 1 commit into from
May 21, 2023

Conversation

JakobDegen
Copy link
Contributor

Fixes #111355 .

I have some ideas for how we can get this back in the future, out of scope for this PR though.

r? @cjgillot

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels May 10, 2023
@rustbot
Copy link
Collaborator

rustbot commented May 10, 2023

Some changes occurred to MIR optimizations

cc @rust-lang/wg-mir-opt

@tmiasko tmiasko self-assigned this May 10, 2023
@JakobDegen
Copy link
Contributor Author

@bors try @rust-timer queue

@rust-timer

This comment has been minimized.

@rustbot rustbot added the S-waiting-on-perf Status: Waiting on a perf run to be completed. label May 10, 2023
@bors
Copy link
Contributor

bors commented May 10, 2023

⌛ Trying commit e3c6278749aac887c9ef6694e41b07095e5b0d13 with merge 8f705f0a8cf3d7990c3b886c89615d90ee80479a...

@bors
Copy link
Contributor

bors commented May 10, 2023

☀️ Try build successful - checks-actions
Build commit: 8f705f0a8cf3d7990c3b886c89615d90ee80479a (8f705f0a8cf3d7990c3b886c89615d90ee80479a)

@rust-timer

This comment has been minimized.

@rust-timer
Copy link
Collaborator

Finished benchmarking commit (8f705f0a8cf3d7990c3b886c89615d90ee80479a): comparison URL.

Overall result: no relevant changes - no action needed

Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. While you can manually mark this PR as fit for rollup, we strongly recommend not doing so since this PR may lead to changes in compiler perf.

@bors rollup=never
@rustbot label: -S-waiting-on-perf -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)
- - 0
Regressions ❌
(secondary)
2.2% [2.2%, 2.2%] 1
Improvements ✅
(primary)
- - 0
Improvements ✅
(secondary)
- - 0
All ❌✅ (primary) - - 0

Cycles

This benchmark run did not return any relevant results for this metric.

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 660.093s -> 659.309s (-0.12%)

@rustbot rustbot removed the S-waiting-on-perf Status: Waiting on a perf run to be completed. label May 10, 2023
@JakobDegen JakobDegen force-pushed the inline-unsized branch 2 times, most recently from a46a0b3 to b66a66a Compare May 13, 2023 04:06
@tmiasko
Copy link
Contributor

tmiasko commented May 13, 2023

Thanks!

@bors r+

@bors
Copy link
Contributor

bors commented May 13, 2023

📌 Commit b66a66a3555bccf60ec03531e5eed92f4d13a613 has been approved by tmiasko

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels May 13, 2023
@bors
Copy link
Contributor

bors commented May 13, 2023

⌛ Testing commit b66a66a3555bccf60ec03531e5eed92f4d13a613 with merge df243137dfb798aa9b4bea7ba250c7dcf32ea212...

@rust-log-analyzer

This comment has been minimized.

@bors
Copy link
Contributor

bors commented May 13, 2023

💔 Test failed - checks-actions

@bors bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels May 13, 2023
@cjgillot cjgillot removed the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label May 13, 2023
@cjgillot cjgillot added the S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. label May 13, 2023
@tmiasko
Copy link
Contributor

tmiasko commented May 21, 2023

@bors r+

@bors
Copy link
Contributor

bors commented May 21, 2023

📌 Commit 60cc72c has been approved by tmiasko

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels May 21, 2023
@bors
Copy link
Contributor

bors commented May 21, 2023

⌛ Testing commit 60cc72c with merge 0634557...

@bors
Copy link
Contributor

bors commented May 21, 2023

☀️ Test successful - checks-actions
Approved by: tmiasko
Pushing 0634557 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label May 21, 2023
@bors bors merged commit 0634557 into rust-lang:master May 21, 2023
@rustbot rustbot added this to the 1.71.0 milestone May 21, 2023
@rust-timer
Copy link
Collaborator

Finished benchmarking commit (0634557): comparison URL.

Overall result: no relevant changes - no action needed

@rustbot label: -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)
3.8% [3.8%, 3.8%] 1
Regressions ❌
(secondary)
3.6% [3.3%, 3.9%] 2
Improvements ✅
(primary)
- - 0
Improvements ✅
(secondary)
-2.5% [-2.6%, -2.3%] 2
All ❌✅ (primary) 3.8% [3.8%, 3.8%] 1

Cycles

This benchmark run did not return any relevant results for this metric.

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 644.012s -> 643.639s (-0.06%)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Inlining introduces unsized temporaries
7 participants