-
Notifications
You must be signed in to change notification settings - Fork 13k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Don't inline functions with unsized args #111424
Conversation
Some changes occurred to MIR optimizations cc @rust-lang/wg-mir-opt |
5c54f1c
to
e3c6278
Compare
@bors try @rust-timer queue |
This comment has been minimized.
This comment has been minimized.
⌛ Trying commit e3c6278749aac887c9ef6694e41b07095e5b0d13 with merge 8f705f0a8cf3d7990c3b886c89615d90ee80479a... |
☀️ Try build successful - checks-actions |
This comment has been minimized.
This comment has been minimized.
Finished benchmarking commit (8f705f0a8cf3d7990c3b886c89615d90ee80479a): comparison URL. Overall result: no relevant changes - no action neededBenchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. While you can manually mark this PR as fit for rollup, we strongly recommend not doing so since this PR may lead to changes in compiler perf. @bors rollup=never Instruction countThis benchmark run did not return any relevant results for this metric. Max RSS (memory usage)ResultsThis is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
CyclesThis benchmark run did not return any relevant results for this metric. Binary sizeThis benchmark run did not return any relevant results for this metric. Bootstrap: 660.093s -> 659.309s (-0.12%) |
a46a0b3
to
b66a66a
Compare
Thanks! @bors r+ |
📌 Commit b66a66a3555bccf60ec03531e5eed92f4d13a613 has been approved by It is now in the queue for this repository. |
⌛ Testing commit b66a66a3555bccf60ec03531e5eed92f4d13a613 with merge df243137dfb798aa9b4bea7ba250c7dcf32ea212... |
This comment has been minimized.
This comment has been minimized.
💔 Test failed - checks-actions |
b66a66a
to
60cc72c
Compare
@bors r+ |
☀️ Test successful - checks-actions |
Finished benchmarking commit (0634557): comparison URL. Overall result: no relevant changes - no action needed@rustbot label: -perf-regression Instruction countThis benchmark run did not return any relevant results for this metric. Max RSS (memory usage)ResultsThis is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
CyclesThis benchmark run did not return any relevant results for this metric. Binary sizeThis benchmark run did not return any relevant results for this metric. Bootstrap: 644.012s -> 643.639s (-0.06%) |
Fixes #111355 .
I have some ideas for how we can get this back in the future, out of scope for this PR though.
r? @cjgillot