Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleaner assert_eq! & assert_ne! panic messages #111071

Merged
merged 1 commit into from
Aug 16, 2023

Commits on Aug 15, 2023

  1. Cleaner assert_eq! & assert_ne! panic messages

    Modify panic message for `assert_eq!`, `assert_ne!`, the currently unstable `assert_matches!`, as well as the corresponding `debug_assert_*` macros.
    
    ```rust
    assert_eq!(1 + 1, 3);
    assert_eq!(1 + 1, 3, "my custom message value={}!", 42);
    ```
    
    ```plain
    thread 'main' panicked at $DIR/main.rs:6:5:
    assertion failed: `(left == right)`
      left: `2`,
     right: `3`
    ```
    ```plain
    thread 'main' panicked at $DIR/main.rs:6:5:
    assertion failed: `(left == right)`
      left: `2`,
     right: `3`: my custom message value=42!
    ```
    
    ```plain
    thread 'main' panicked at $DIR/main.rs:6:5:
    assertion `left == right` failed
      left: 2
     right: 3
    ```
    
    ```plain
    thread 'main' panicked at $DIR/main.rs:6:5:
    assertion `left == right` failed: my custom message value=42!
      left: 2
     right: 3
    ```
    
    This PR is a simpler subset of the rust-lang#111030, but it does NOT stringify the original left and right source code assert expressions, thus should be faster to compile.
    nyurik committed Aug 15, 2023
    Configuration menu
    Copy the full SHA
    950e3d9 View commit details
    Browse the repository at this point in the history