Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the test directories suggested by ./x.py suggest #111002

Merged
merged 1 commit into from
May 7, 2023

Conversation

Zalathar
Copy link
Contributor

It seems that these paths were correct when #106249 was being written, but since then #106458 has been merged (moving src/test/ to tests/), making the tool's suggestions incorrect.

The tests that were in `src/test/` have been moved to `tests/`, so the paths
given by the suggestion tool should reflect this.
@rustbot
Copy link
Collaborator

rustbot commented Apr 30, 2023

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @Mark-Simulacrum (or someone else) soon.

Please see the contribution instructions for more information. Namely, in order to ensure the minimum review times lag, PR authors and assigned reviewers should ensure that the review label (S-waiting-on-review and S-waiting-on-author) stays updated, invoking these commands when appropriate:

  • @rustbot author: the review is finished, PR author should check the comments and take action accordingly
  • @rustbot review: the author is ready for a review, this PR will be queued again in the reviewer's queue

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Apr 30, 2023
@jyn514
Copy link
Member

jyn514 commented Apr 30, 2023

I think we should consider autogenerating these paths from the make_run function in Step so they can't get out of date.

@Mark-Simulacrum
Copy link
Member

@bors r+ rollup

In the meantime, this seems like a good change.

@bors
Copy link
Contributor

bors commented May 6, 2023

📌 Commit 71ab284 has been approved by Mark-Simulacrum

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels May 6, 2023
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request May 6, 2023
…mulacrum

Fix the test directories suggested by `./x.py suggest`

It seems that these paths were correct when rust-lang#106249 was being written, but since then rust-lang#106458 has been merged (moving `src/test/` to `tests/`), making the tool's suggestions incorrect.
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request May 6, 2023
…mulacrum

Fix the test directories suggested by `./x.py suggest`

It seems that these paths were correct when rust-lang#106249 was being written, but since then rust-lang#106458 has been merged (moving `src/test/` to `tests/`), making the tool's suggestions incorrect.
bors added a commit to rust-lang-ci/rust that referenced this pull request May 6, 2023
…iaskrgr

Rollup of 7 pull requests

Successful merges:

 - rust-lang#111002 (Fix the test directories suggested by `./x.py suggest`)
 - rust-lang#111077 (Make more ConstProp tests unit.)
 - rust-lang#111151 (check bootstrap scripts syntax)
 - rust-lang#111203 (Output LLVM optimization remark kind in `-Cremark` output)
 - rust-lang#111237 (asm: loongarch64: Implementation of clobber_abi)
 - rust-lang#111274 (Expand the LLVM coverage of `--print target-cpus`)
 - rust-lang#111289 (Check arguments length in trivial diagnostic lint)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit cec5c40 into rust-lang:master May 7, 2023
@rustbot rustbot added this to the 1.71.0 milestone May 7, 2023
@Zalathar Zalathar deleted the x-suggest-dirs branch May 7, 2023 02:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants