Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rollup of 6 pull requests #110752

Merged
merged 13 commits into from
Apr 24, 2023
Merged

Rollup of 6 pull requests #110752

merged 13 commits into from
Apr 24, 2023

Conversation

matthiaskrgr
Copy link
Member

Successful merges:

Failed merges:

r? @ghost
@rustbot modify labels: rollup

Create a similar rollup

clubby789 and others added 13 commits April 17, 2023 13:01
@clubby789
Suggest using integration tests for proc-macros
f7581d8
@compiler-errors
Remove find_map_relevant_impl
1467877
@oli-obk
Group entire build steps in the gha logs
95e8b6a
@scottmcm
Add intrinsics::transmute_unchecked
1de2257 
This takes a whole 3 lines in `compiler/` since it lowers to `CastKind::Transmute` in MIR *exactly* the same as the existing `intrinsics::transmute` does, it just doesn't have the fancy checking in `hir_typeck`.

Added to enable experimenting with the request in <rust-lang#106281 (comment)> and because the portable-simd folks might be interested for dependently-sized array-vector conversions.

It also simplifies a couple places in `core`.
@cjgillot
Also reveal constants before MIR opts.
7efcf67
@cjgillot
Use param_env_reveal_all_normalized in MIR opts.
4fe5136
@compiler-errors
Don't create projection ty for const projection
cde5bca
@matthiaskrgr
Rollup merge of rust-lang#110255 - clubby789:proc-macro-test-help, r=…
0f27161 
…jackh726

Suggest using integration tests for test crate using own proc-macro

cc rust-lang#110247
@matthiaskrgr
Rollup merge of rust-lang#110514 - compiler-errors:remove-find_map_re…
d60c64a 
…levant_impl, r=b-naber

Remove `find_map_relevant_impl`

Fixes rust-lang#108895
@matthiaskrgr
Rollup merge of rust-lang#110566 - compiler-errors:bad-projection-ter…
8aab707 
…m, r=cjgillot,BoxyUwU

Don't create projection ty for const projection

Fixes rust-lang#110549
@matthiaskrgr
Rollup merge of rust-lang#110637 - oli-obk:gha, r=jyn514
775682d 
Group some sections of our logs in github actions

This makes logs a little bit more readable as you can now collapse all the parts that don't interest you (and they get collapsed automatically)

Obviously there's a lot more sites where we can/need to do this, too, but this is already helpful imo

r? ```@jyn514```
@matthiaskrgr
Rollup merge of rust-lang#110706 - scottmcm:transmute_unchecked, r=ol…
3ecae29 
…i-obk

Add `intrinsics::transmute_unchecked`

This takes a whole 3 lines in `compiler/` since it lowers to `CastKind::Transmute` in MIR *exactly* the same as the existing `intrinsics::transmute` does, it just doesn't have the fancy checking in `hir_typeck`.

Added to enable experimenting with the request in <rust-lang#106281 (comment)> and because the portable-simd folks might be interested for dependently-sized array-vector conversions.

It also simplifies a couple places in `core`.

See also rust-lang#108442 (comment), where `CastKind::Transmute` was added having exactly these semantics before the lang meeting (which I wasn't in) independently expressed interest.
@matthiaskrgr
Rollup merge of rust-lang#110714 - cjgillot:reveal-consts, r=oli-obk
2ce9b57 
Normalize types and consts in MIR opts.

Some passes were using a non-RevealAll param_env, which is needlessly restrictive in mir-opts.

As a drive-by, we normalize all constants, since just normalizing their types is not enough.
@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-libs Relevant to the library team, which will review and decide on the PR/issue. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. WG-trait-system-refactor The Rustc Trait System Refactor Initiative (-Znext-solver) rollup A PR which is a rollup labels Apr 24, 2023
@matthiaskrgr
Copy link
Member Author

@bors r+ rollup=never p=6

@bors
Copy link
Contributor

bors commented Apr 24, 2023

📌 Commit 2ce9b57 has been approved by matthiaskrgr

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 24, 2023
@bors
Copy link
Contributor

bors commented Apr 24, 2023

⌛ Testing commit 2ce9b57 with merge 64bcb32...

@bors
Copy link
Contributor

bors commented Apr 24, 2023

☀️ Test successful - checks-actions
Approved by: matthiaskrgr
Pushing 64bcb32 to master...

1 similar comment
@bors
Copy link
Contributor

bors commented Apr 24, 2023

☀️ Test successful - checks-actions
Approved by: matthiaskrgr
Pushing 64bcb32 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Apr 24, 2023
@bors bors merged commit 64bcb32 into rust-lang:master Apr 24, 2023
@rust-timer
Copy link
Collaborator

📌 Perf builds for each rolled up PR:

PR# Perf Build Sha

previous master: 64bcb32651

In the case of a perf regression, run the following command for each PR you suspect might be the cause: @rust-timer build $SHA

@rustbot rustbot added this to the 1.71.0 milestone Apr 24, 2023
@rust-timer
Copy link
Collaborator

📌 Perf builds for each rolled up PR:

PR# Perf Build Sha
#110714 5155cf6c8de4f22bac9952b3a1fd5bf5f5e59625
#110706 e99ae471c8dc6ac25c35ffdf3d436fc376c9f74d
#110637 f863ea173386b92332f1c0efcbc181961815b939
#110566 fc34389c6e44beaa2a829425ffc9190c13e21b4c
#110514 905928844aa26e8cd5d643986835ecea988801b8
#110255 4c25b09f1994f4682d7481e57aff838c74a3fbc8

previous master: f65615f02d

In the case of a perf regression, run the following command for each PR you suspect might be the cause: @rust-timer build $SHA

@rust-timer
Copy link
Collaborator

Finished benchmarking commit (64bcb32): comparison URL.

Overall result: ✅ improvements - no action needed

@rustbot label: -perf-regression

Instruction count

This is a highly reliable metric that was used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)		 - - 0
Regressions ❌
(secondary)		 - - 0
Improvements ✅
(primary)		 -2.7% [-2.9%, -2.5%] 2
Improvements ✅
(secondary)		 -4.7% [-7.6%, -0.3%] 8
All ❌✅ (primary) -2.7% [-2.9%, -2.5%] 2

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)		 2.1% [2.1%, 2.1%] 1
Regressions ❌
(secondary)		 - - 0
Improvements ✅
(primary)		 - - 0
Improvements ✅
(secondary)		 -5.3% [-5.3%, -5.3%] 1
All ❌✅ (primary) 2.1% [2.1%, 2.1%] 1

Cycles

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)		 - - 0
Regressions ❌
(secondary)		 - - 0
Improvements ✅
(primary)		 - - 0
Improvements ✅
(secondary)		 -3.8% [-3.9%, -3.7%] 2
All ❌✅ (primary) - - 0

@matthiaskrgr matthiaskrgr deleted the rollup-959s77u branch March 16, 2024 18:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
merged-by-bors This PR was explicitly merged by bors. rollup A PR which is a rollup S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-libs Relevant to the library team, which will review and decide on the PR/issue. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. WG-trait-system-refactor The Rustc Trait System Refactor Initiative (-Znext-solver)
Projects
None yet
Milestone
1.71.0
Development

Successfully merging this pull request may close these issues.
9 participants
@matthiaskrgr @bors @rust-timer @rustbot @clubby789 @compiler-errors @oli-obk @scottmcm @cjgillot