Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Specialize some io::Read and io::Write methods for VecDeque<u8> and &[u8] #110608

Merged
merged 1 commit into from
Apr 21, 2023
Merged

Specialize some io::Read and io::Write methods for VecDeque<u8> and &[u8] #110608

merged 1 commit into from
Apr 21, 2023

Conversation

a1phyr
Copy link
Contributor

@a1phyr a1phyr commented Apr 20, 2023

This improves implementation of:

  • <&[u8]>::read_to_string
  • VecDeque<u8>::read_to_end
  • VecDeque<u8>::read_to_string
  • VecDeque<u8>::write_vectored

@rustbot
Copy link
Collaborator

rustbot commented Apr 20, 2023

r? @thomcc

(rustbot has picked a reviewer for you, use r? to override)

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Apr 20, 2023
@rustbot
Copy link
Collaborator

rustbot commented Apr 20, 2023

Hey! It looks like you've submitted a new PR for the library teams!

If this PR contains changes to any rust-lang/rust public library APIs then please comment with @rustbot label +T-libs-api -T-libs to tag it appropriately. If this PR contains changes to any unstable APIs please edit the PR description to add a link to the relevant API Change Proposal or create one if you haven't already. If you're unsure where your change falls no worries, just leave it as is and the reviewer will take a look and make a decision to forward on if necessary.

Examples of T-libs-api changes:

  • Stabilizing library features
  • Introducing insta-stable changes such as new implementations of existing stable traits on existing stable types
  • Introducing new or changing existing unstable library APIs (excluding permanently unstable features / features without a tracking issue)
  • Changing public documentation in ways that create new stability guarantees
  • Changing observable runtime behavior of library APIs

@thomcc
Copy link
Member

thomcc commented Apr 21, 2023

Looks great, thanks.

@bors r+

@bors
Copy link
Contributor

bors commented Apr 21, 2023

📌 Commit 1e6a7b4 has been approved by thomcc

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 21, 2023
@Dylan-DPC Dylan-DPC mentioned this pull request Apr 21, 2023
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Apr 21, 2023
@bors
Auto merge of rust-lang#110648 - Dylan-DPC:rollup-em3ovcq, r=Dylan-DPC
fec9adc 
Rollup of 5 pull requests

Successful merges:

 - rust-lang#110333 (rustc_metadata: Split `children` into multiple tables)
 - rust-lang#110501 (rustdoc: fix ICE from rustc_resolve and librustdoc parse divergence)
 - rust-lang#110608 (Specialize some `io::Read` and `io::Write` methods for `VecDeque<u8>` and `&[u8]`)
 - rust-lang#110632 (Panic instead of truncating if the incremental on-disk cache is too big)
 - rust-lang#110633 (More `mem::take` in `library`)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit f971264 into rust-lang:master Apr 21, 2023
@rustbot rustbot added this to the 1.71.0 milestone Apr 21, 2023
@a1phyr a1phyr deleted the specialize_io_methods branch March 12, 2024 17:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@thomcc thomcc

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-libs Relevant to the library team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.71.0
Development

Successfully merging this pull request may close these issues.
4 participants
@a1phyr @rustbot @thomcc @bors