-
Notifications
You must be signed in to change notification settings - Fork 13k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
rustdoc: migrate item_typedef to an Askama template #110470
Conversation
r? @jsha (rustbot has picked a reviewer for you, use r? to override) |
☔ The latest upstream changes (presumably #110666) made this pull request unmergeable. Please resolve the merge conflicts. |
64b450a
to
0b235d6
Compare
This comment has been minimized.
This comment has been minimized.
0b235d6
to
e2a3690
Compare
☔ The latest upstream changes (presumably #111001) made this pull request unmergeable. Please resolve the merge conflicts. |
e2a3690
to
786311c
Compare
I'm really not a big fan of using more templating in cases as small as this one: it increases code complexity quite a lot. Let's check the perf result to see if we have gains though. @bors try @rust-timer queue |
This comment has been minimized.
This comment has been minimized.
⌛ Trying commit 786311c with merge 796eb677726e5d6ac08a7ab1b1d49e8f0449f110... |
☀️ Try build successful - checks-actions |
This comment has been minimized.
This comment has been minimized.
Finished benchmarking commit (796eb677726e5d6ac08a7ab1b1d49e8f0449f110): comparison URL. Overall result: no relevant changes - no action neededBenchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. While you can manually mark this PR as fit for rollup, we strongly recommend not doing so since this PR may lead to changes in compiler perf. @bors rollup=never Instruction countThis benchmark run did not return any relevant results for this metric. Max RSS (memory usage)ResultsThis is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
CyclesResultsThis is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
Binary sizeThis benchmark run did not return any relevant results for this metric. Bootstrap: 658.519s -> 659.197s (0.10%) |
There doesn't seem to be any gain from this. So what do you want to do @notriddle? |
Part of #108868