Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rustdoc: migrate item_typedef to an Askama template #110470

Closed
wants to merge 2 commits into from

Conversation

notriddle
Copy link
Contributor

Part of #108868

@rustbot
Copy link
Collaborator

rustbot commented Apr 17, 2023

r? @jsha

(rustbot has picked a reviewer for you, use r? to override)

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. labels Apr 17, 2023
@bors
Copy link
Contributor

bors commented Apr 22, 2023

☔ The latest upstream changes (presumably #110666) made this pull request unmergeable. Please resolve the merge conflicts.

@notriddle notriddle force-pushed the notriddle/item-typedef branch from 64b450a to 0b235d6 Compare April 24, 2023 17:22
@rust-log-analyzer

This comment has been minimized.

@notriddle notriddle force-pushed the notriddle/item-typedef branch from 0b235d6 to e2a3690 Compare April 24, 2023 17:38
@bors
Copy link
Contributor

bors commented Apr 30, 2023

☔ The latest upstream changes (presumably #111001) made this pull request unmergeable. Please resolve the merge conflicts.

@notriddle notriddle force-pushed the notriddle/item-typedef branch from e2a3690 to 786311c Compare May 9, 2023 23:15
@notriddle notriddle assigned GuillaumeGomez and unassigned jsha May 9, 2023
@GuillaumeGomez
Copy link
Member

I'm really not a big fan of using more templating in cases as small as this one: it increases code complexity quite a lot. Let's check the perf result to see if we have gains though.

@bors try @rust-timer queue

@rust-timer

This comment has been minimized.

@rustbot rustbot added the S-waiting-on-perf Status: Waiting on a perf run to be completed. label May 10, 2023
@bors
Copy link
Contributor

bors commented May 10, 2023

⌛ Trying commit 786311c with merge 796eb677726e5d6ac08a7ab1b1d49e8f0449f110...

@bors
Copy link
Contributor

bors commented May 10, 2023

☀️ Try build successful - checks-actions
Build commit: 796eb677726e5d6ac08a7ab1b1d49e8f0449f110 (796eb677726e5d6ac08a7ab1b1d49e8f0449f110)

@rust-timer

This comment has been minimized.

@rust-timer
Copy link
Collaborator

Finished benchmarking commit (796eb677726e5d6ac08a7ab1b1d49e8f0449f110): comparison URL.

Overall result: no relevant changes - no action needed

Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. While you can manually mark this PR as fit for rollup, we strongly recommend not doing so since this PR may lead to changes in compiler perf.

@bors rollup=never
@rustbot label: -S-waiting-on-perf -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)
- - 0
Regressions ❌
(secondary)
- - 0
Improvements ✅
(primary)
- - 0
Improvements ✅
(secondary)
-1.1% [-1.1%, -1.1%] 1
All ❌✅ (primary) - - 0

Cycles

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)
- - 0
Regressions ❌
(secondary)
- - 0
Improvements ✅
(primary)
- - 0
Improvements ✅
(secondary)
-2.5% [-2.8%, -2.3%] 2
All ❌✅ (primary) - - 0

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 658.519s -> 659.197s (0.10%)

@rustbot rustbot removed the S-waiting-on-perf Status: Waiting on a perf run to be completed. label May 10, 2023
@GuillaumeGomez
Copy link
Member

There doesn't seem to be any gain from this. So what do you want to do @notriddle?

@notriddle notriddle closed this May 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants