Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Windows: map a few more error codes to ErrorKind #110433

Merged
merged 1 commit into from
Apr 17, 2023

Conversation

ChrisDenton
Copy link
Member

NotFound errors:

  • ERROR_INVALID_DRIVE: The system cannot find the drive specified
  • ERROR_BAD_NETPATH: The network path was not found
  • ERROR_BAD_NET_NAME: The network name cannot be found.

InvalidFilename:

  • ERROR_BAD_PATHNAME: The specified path is invalid.

Source: System Error Codes (0-499)

NotFound errors:

* `ERROR_INVALID_DRIVE`: The system cannot find the drive specified
* `ERROR_BAD_NETPATH`: The network path was not found
* `ERROR_BAD_NET_NAME`: The network name cannot be found.

InvalidFilename:

* `ERROR_BAD_PATHNAME`: The specified path is invalid.
@ChrisDenton ChrisDenton marked this pull request as ready for review April 16, 2023 22:46
@rustbot
Copy link
Collaborator

rustbot commented Apr 16, 2023

r? @thomcc

(rustbot has picked a reviewer for you, use r? to override)

@rustbot
Copy link
Collaborator

rustbot commented Apr 16, 2023

Hey! It looks like you've submitted a new PR for the library teams!

If this PR contains changes to any rust-lang/rust public library APIs then please comment with @rustbot label +T-libs-api -T-libs to tag it appropriately. If this PR contains changes to any unstable APIs please edit the PR description to add a link to the relevant API Change Proposal or create one if you haven't already. If you're unsure where your change falls no worries, just leave it as is and the reviewer will take a look and make a decision to forward on if necessary.

Examples of T-libs-api changes:

  • Stabilizing library features
  • Introducing insta-stable changes such as new implementations of existing stable traits on existing stable types
  • Introducing new or changing existing unstable library APIs (excluding permanently unstable features / features without a tracking issue)
  • Changing public documentation in ways that create new stability guarantees
  • Changing observable runtime behavior of library APIs

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Apr 16, 2023
@thomcc
Copy link
Member

thomcc commented Apr 17, 2023

Seems fine to me.

@bors r+ rollup

@bors
Copy link
Contributor

bors commented Apr 17, 2023

📌 Commit db8dfbd has been approved by thomcc

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 17, 2023
bors added a commit to rust-lang-ci/rust that referenced this pull request Apr 17, 2023
…iaskrgr

Rollup of 7 pull requests

Successful merges:

 - rust-lang#110038 (Erase regions when confirming transmutability candidate)
 - rust-lang#110341 (rustdoc: stop passing a title to `replaceState` second argument)
 - rust-lang#110388 (Add a message for if an overflow occurs in `core::intrinsics::is_nonoverlapping`.)
 - rust-lang#110404 (fix clippy::toplevel_ref_arg and ::manual_map)
 - rust-lang#110421 (Spelling librustdoc)
 - rust-lang#110423 (Spelling srcdoc)
 - rust-lang#110433 (Windows: map a few more error codes to ErrorKind)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 35e6389 into rust-lang:master Apr 17, 2023
@rustbot rustbot added this to the 1.71.0 milestone Apr 17, 2023
@ChrisDenton ChrisDenton deleted the notfound branch April 17, 2023 09:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-libs Relevant to the library team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants