-
Notifications
You must be signed in to change notification settings - Fork 13.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
rustdoc-json: Add test for #[automatically_derived] attribute #110406
Draft
aDotInTheVoid
wants to merge
1
commit into
rust-lang:master
Choose a base branch
from
aDotInTheVoid:rdj-derived-impl-attr
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
rustdoc-json: Add test for #[automatically_derived] attribute #110406
aDotInTheVoid
wants to merge
1
commit into
rust-lang:master
from
aDotInTheVoid:rdj-derived-impl-attr
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
fbstj
reviewed
Apr 16, 2023
283bcf0
to
46e1841
Compare
This comment has been minimized.
This comment has been minimized.
46e1841
to
5d42b16
Compare
The job Click to see the possible cause of the failure (guessed by this bot)
|
@aDotInTheVoid any updates on this? thanks |
still blocked on changing json path implementation. this is something i’d like to do, but low priority |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
A-rustdoc-json
Area: Rustdoc JSON backend
S-blocked
Status: Blocked on something else such as an RFC or other implementation work.
T-rustdoc
Relevant to the rustdoc team, which will review and decide on the PR/issue.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Will fail CI due to freestrings/jsonpath#91, but I wrote the test and don't want to forget it.
We should look into fixing the freestrings impl, or moving to a different one, so we can test things like this. Zulip Disussion
r? @ghost
@rustbot blocked