Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rustdoc-json: Add test for #[automatically_derived] attribute #110406

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

aDotInTheVoid
Copy link
Member

@aDotInTheVoid aDotInTheVoid commented Apr 16, 2023

Will fail CI due to freestrings/jsonpath#91, but I wrote the test and don't want to forget it.

We should look into fixing the freestrings impl, or moving to a different one, so we can test things like this. Zulip Disussion

r? @ghost

@rustbot blocked

@rustbot rustbot added A-rustdoc-json Area: Rustdoc JSON backend S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. S-blocked Status: Blocked on something else such as an RFC or other implementation work. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 16, 2023
@rust-log-analyzer

This comment has been minimized.

@rust-cloud-vms rust-cloud-vms bot force-pushed the rdj-derived-impl-attr branch from 283bcf0 to 46e1841 Compare April 16, 2023 14:02
@rust-log-analyzer

This comment has been minimized.

@rust-cloud-vms rust-cloud-vms bot force-pushed the rdj-derived-impl-attr branch from 46e1841 to 5d42b16 Compare April 19, 2023 13:44
@rust-log-analyzer
Copy link
Collaborator

The job x86_64-gnu-llvm-14 failed! Check out the build log: (web) (plain)

Click to see the possible cause of the failure (guessed by this bot)
status: exit status: 1
command: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0-tools-bin/jsondocck" "--doc-dir" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/rustdoc-json/traits/automatically_derived_attr" "--template" "/checkout/tests/rustdoc-json/traits/automatically_derived_attr.rs"
stdout: none
--- stderr -------------------------------
Failed check: $.index[*][?(@.inner.for.inner.name == "Derived")].attrs matched to [], but expected Array [String("#[automatically_derived]")] on line 4
Error: "Jsondocck failed for /checkout/tests/rustdoc-json/traits/automatically_derived_attr.rs"

Rustdoc Output:
status: exit status: 0
status: exit status: 0
command: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/bin/rustdoc" "-L" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/lib/rustlib/x86_64-unknown-linux-gnu/lib" "-L" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/rustdoc-json/traits/automatically_derived_attr/auxiliary" "-o" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/rustdoc-json/traits/automatically_derived_attr" "--deny" "warnings" "/checkout/tests/rustdoc-json/traits/automatically_derived_attr.rs" "--output-format" "json" "-Zunstable-options"
stdout: none
stderr: none


failures:
    [rustdoc-json] tests/rustdoc-json/traits/automatically_derived_attr.rs

@Dylan-DPC
Copy link
Member

@aDotInTheVoid any updates on this? thanks

@aDotInTheVoid
Copy link
Member Author

still blocked on changing json path implementation. this is something i’d like to do, but low priority

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-rustdoc-json Area: Rustdoc JSON backend S-blocked Status: Blocked on something else such as an RFC or other implementation work. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants