Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Temporarily disable the jobserver-error test #110361

Merged
merged 1 commit into from
Apr 15, 2023
Merged

Temporarily disable the jobserver-error test #110361

merged 1 commit into from
Apr 15, 2023

Conversation

ehuss
Copy link
Contributor

@ehuss ehuss commented Apr 15, 2023

This test is failing randomly on CI. We don't have a handle on what might be causing it, so disable it for now to reduce disruption.

cc #110321

@rustbot
Copy link
Collaborator

rustbot commented Apr 15, 2023

r? @Mark-Simulacrum

(rustbot has picked a reviewer for you, use r? to override)

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Apr 15, 2023
@ehuss ehuss mentioned this pull request Apr 15, 2023
Open
@Mark-Simulacrum
Copy link
Member

@bors r+

@bors
Copy link
Contributor

bors commented Apr 15, 2023

📌 Commit 79b3af3 has been approved by Mark-Simulacrum

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 15, 2023
@Noratrieb Noratrieb added the A-testsuite Area: The testsuite used to check the correctness of rustc label Apr 15, 2023
@bors
Copy link
Contributor

bors commented Apr 15, 2023

⌛ Testing commit 79b3af3 with merge 5cdb788...

@bors
Copy link
Contributor

bors commented Apr 15, 2023

☀️ Test successful - checks-actions
Approved by: Mark-Simulacrum
Pushing 5cdb788 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Apr 15, 2023
@bors bors merged commit 5cdb788 into rust-lang:master Apr 15, 2023
@rustbot rustbot added this to the 1.71.0 milestone Apr 15, 2023
@rust-timer
Copy link
Collaborator

Finished benchmarking commit (5cdb788): comparison URL.

Overall result: ✅ improvements - no action needed

@rustbot label: -perf-regression

Instruction count

This is a highly reliable metric that was used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)		 - - 0
Regressions ❌
(secondary)		 - - 0
Improvements ✅
(primary)		 -0.3% [-0.3%, -0.3%] 1
Improvements ✅
(secondary)		 - - 0
All ❌✅ (primary) -0.3% [-0.3%, -0.3%] 1

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)		 - - 0
Regressions ❌
(secondary)		 4.5% [4.5%, 4.5%] 1
Improvements ✅
(primary)		 - - 0
Improvements ✅
(secondary)		 - - 0
All ❌✅ (primary) - - 0

Cycles

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)		 2.6% [2.6%, 2.6%] 1
Regressions ❌
(secondary)		 - - 0
Improvements ✅
(primary)		 - - 0
Improvements ✅
(secondary)		 - - 0
All ❌✅ (primary) 2.6% [2.6%, 2.6%] 1

@ehuss ehuss added the beta-nominated Nominated for backporting to the compiler in the beta channel. label Apr 17, 2023
@ehuss
Copy link
Contributor Author

ehuss commented Apr 17, 2023

Nominated for beta 1.70 to help avoid trouble merging beta PRs.

@ehuss ehuss mentioned this pull request Apr 18, 2023
Merged
@ehuss ehuss mentioned this pull request Apr 29, 2023
Merged
@cuviper cuviper added beta-accepted Accepted for backporting to the compiler in the beta channel. and removed beta-nominated Nominated for backporting to the compiler in the beta channel. labels Apr 29, 2023
@cuviper cuviper modified the milestones: 1.71.0, 1.70.0 Apr 29, 2023
bors added a commit to rust-lang-ci/rust that referenced this pull request Apr 30, 2023
@bors
Auto merge of rust-lang#110871 - cuviper:beta-next, r=cuviper
071f14b 
[beta] backport

This PR backports:

- Encode def span for ConstParam rust-lang#110425
- Update to LLVM 16.0.2 rust-lang#110535
- Encode lifetime param spans too rust-lang#110469
- make sysroot finding compatible with multiarch systems rust-lang#110281
- Update awscli rust-lang#110952
- Temporarily disable the jobserver-error test rust-lang#110361

Also bumps us to the latest released stable, 1.69.0.

r? `@cuviper`
@DaniPopes DaniPopes mentioned this pull request Nov 8, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@Mark-Simulacrum Mark-Simulacrum

Labels
A-testsuite Area: The testsuite used to check the correctness of rustc beta-accepted Accepted for backporting to the compiler in the beta channel. merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
1.70.0
Development

Successfully merging this pull request may close these issues.
7 participants
@ehuss @rustbot @Mark-Simulacrum @bors @rust-timer @cuviper @Noratrieb