test for the default parallel compiler on threads=8 #110284

SparrowLii · 2023-04-13T13:28:11Z

test the perf of unchanged parallel compiler with two threads

SparrowLii · 2023-04-13T13:28:28Z

bors · 2023-04-13T13:28:37Z

⌛ Trying commit 4544ab3b44fb16e7106e6487a2f060722a00fe71 with merge 496da9ecae5ae01f39010d77848902aeac29ad90...

bors · 2023-04-13T15:10:37Z

☀️ Try build successful - checks-actions
Build commit: 496da9ecae5ae01f39010d77848902aeac29ad90 (496da9ecae5ae01f39010d77848902aeac29ad90)

rust-timer · 2023-04-14T12:57:47Z

Finished benchmarking commit (496da9ecae5ae01f39010d77848902aeac29ad90): comparison URL.

Overall result: ❌✅ regressions and improvements - ACTION NEEDED

Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. While you can manually mark this PR as fit for rollup, we strongly recommend not doing so since this PR may lead to changes in compiler perf.

Next Steps: If you can justify the regressions found in this try perf run, please indicate this with @rustbot label: +perf-regression-triaged along with sufficient written justification. If you cannot justify the regressions please fix the regressions and do another perf run. If the next run shows neutral or positive results, the label will be automatically removed.

@bors rollup=never
@rustbot label: -S-waiting-on-perf +perf-regression

Warning ⚠: The following benchmark(s) failed to build:

issue-88862
derive
serde_derive-1.0.136

Instruction count

This is a highly reliable metric that was used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	3.7%	[0.3%, 9.7%]	207
Regressions ❌ (secondary)	3.7%	[0.7%, 22.8%]	240
Improvements ✅ (primary)	-22.8%	[-45.5%, -5.3%]	15
Improvements ✅ (secondary)	-12.9%	[-30.1%, -6.3%]	4
All ❌✅ (primary)	1.9%	[-45.5%, 9.7%]	222

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	5.3%	[0.5%, 112.3%]	187
Regressions ❌ (secondary)	4.5%	[1.0%, 12.9%]	203
Improvements ✅ (primary)	-5.4%	[-22.9%, -0.4%]	12
Improvements ✅ (secondary)	-3.2%	[-4.1%, -2.6%]	3
All ❌✅ (primary)	4.6%	[-22.9%, 112.3%]	199

Cycles

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	19.8%	[1.1%, 50.8%]	235
Regressions ❌ (secondary)	17.0%	[1.8%, 65.2%]	257
Improvements ✅ (primary)	-21.1%	[-39.6%, -2.9%]	11
Improvements ✅ (secondary)	-24.3%	[-24.3%, -24.3%]	1
All ❌✅ (primary)	18.0%	[-39.6%, 50.8%]	246

SparrowLii · 2023-05-08T01:59:08Z

I checked the use cases where the efficiency is reduced, and almost all of them take up the main time consumption in the hir_crate query. If we can solve this problem, it should improve the efficiency of parallel compilation a lot.

SparrowLii · 2023-05-10T11:22:01Z

@bors try @rust-timer queue

bors · 2023-05-10T11:22:09Z

⌛ Trying commit a02cdf6a1ee8e1d8c5da202aaec125829a075b54 with merge 8a17e342d7f61af3f87734d76b33db1507550786...

bors · 2023-05-10T13:36:52Z

☀️ Try build successful - checks-actions
Build commit: 8a17e342d7f61af3f87734d76b33db1507550786 (8a17e342d7f61af3f87734d76b33db1507550786)

rust-timer · 2023-05-10T15:46:25Z

Finished benchmarking commit (8a17e342d7f61af3f87734d76b33db1507550786): comparison URL.

Overall result: ❌✅ regressions and improvements - ACTION NEEDED

Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. While you can manually mark this PR as fit for rollup, we strongly recommend not doing so since this PR may lead to changes in compiler perf.

Next Steps: If you can justify the regressions found in this try perf run, please indicate this with @rustbot label: +perf-regression-triaged along with sufficient written justification. If you cannot justify the regressions please fix the regressions and do another perf run. If the next run shows neutral or positive results, the label will be automatically removed.

@bors rollup=never
@rustbot label: -S-waiting-on-perf +perf-regression

Warning ⚠: The following benchmark(s) failed to build:

serde_derive-1.0.136
issue-88862

Instruction count

This is a highly reliable metric that was used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	3.4%	[0.7%, 6.8%]	190
Regressions ❌ (secondary)	3.6%	[0.9%, 7.3%]	208
Improvements ✅ (primary)	-22.2%	[-42.2%, -5.6%]	15
Improvements ✅ (secondary)	-15.9%	[-30.7%, -6.9%]	3
All ❌✅ (primary)	1.5%	[-42.2%, 6.8%]	205

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	4.7%	[1.1%, 13.6%]	203
Regressions ❌ (secondary)	5.8%	[1.3%, 14.8%]	234
Improvements ✅ (primary)	-5.3%	[-22.3%, -1.0%]	10
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	4.2%	[-22.3%, 13.6%]	213

Cycles

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	16.6%	[1.1%, 46.2%]	229
Regressions ❌ (secondary)	16.5%	[1.8%, 64.2%]	250
Improvements ✅ (primary)	-19.1%	[-38.7%, -2.5%]	12
Improvements ✅ (secondary)	-25.7%	[-25.7%, -25.7%]	1
All ❌✅ (primary)	14.8%	[-38.7%, 46.2%]	241

Binary size

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	0.1%	[0.0%, 0.2%]	8
Regressions ❌ (secondary)	0.1%	[0.1%, 0.1%]	1
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	0.1%	[0.0%, 0.2%]	8

Bootstrap: 660.093s -> 672.496s (1.88%)

SparrowLii · 2023-05-11T03:41:19Z

@bors try @rust-timer queue

rust-timer · 2023-07-26T14:42:53Z

Finished benchmarking commit (9148ca2269d942a02167b2ba918ed9e25467abe8): comparison URL.

Overall result: ❌✅ regressions and improvements - ACTION NEEDED

Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. While you can manually mark this PR as fit for rollup, we strongly recommend not doing so since this PR may lead to changes in compiler perf.

Next Steps: If you can justify the regressions found in this try perf run, please indicate this with @rustbot label: +perf-regression-triaged along with sufficient written justification. If you cannot justify the regressions please fix the regressions and do another perf run. If the next run shows neutral or positive results, the label will be automatically removed.

@bors rollup=never
@rustbot label: -S-waiting-on-perf +perf-regression

Warning ⚠: The following benchmark(s) failed to build:

clap-3.1.6
issue-88862
unicode-normalization-0.1.19
hyper-0.14.18
serde_derive-1.0.136
image-0.24.1

Instruction count

This is a highly reliable metric that was used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	3.8%	[0.3%, 20.7%]	209
Regressions ❌ (secondary)	4.3%	[0.5%, 14.6%]	218
Improvements ✅ (primary)	-21.2%	[-42.0%, -5.0%]	13
Improvements ✅ (secondary)	-15.9%	[-44.3%, -2.4%]	11
All ❌✅ (primary)	2.3%	[-42.0%, 20.7%]	222

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	9.4%	[0.6%, 34.0%]	220
Regressions ❌ (secondary)	8.7%	[1.4%, 24.1%]	227
Improvements ✅ (primary)	-4.9%	[-19.4%, -1.2%]	8
Improvements ✅ (secondary)	-5.2%	[-9.8%, -1.0%]	18
All ❌✅ (primary)	8.9%	[-19.4%, 34.0%]	228

Cycles

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	23.9%	[1.0%, 76.6%]	222
Regressions ❌ (secondary)	19.7%	[1.3%, 69.6%]	250
Improvements ✅ (primary)	-18.4%	[-38.5%, -2.9%]	10
Improvements ✅ (secondary)	-22.3%	[-32.9%, -5.0%]	4
All ❌✅ (primary)	22.1%	[-38.5%, 76.6%]	232

Binary size

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	0.0%	[0.0%, 0.0%]	17
Regressions ❌ (secondary)	0.1%	[0.1%, 0.1%]	1
Improvements ✅ (primary)	-0.0%	[-0.0%, -0.0%]	1
Improvements ✅ (secondary)	-0.1%	[-0.1%, -0.1%]	1
All ❌✅ (primary)	0.0%	[-0.0%, 0.0%]	18

Bootstrap: 650.76s -> 664.076s (2.05%)

Dylan-DPC · 2023-08-08T10:35:15Z

@SparrowLii any updates on this? thanks

SparrowLii · 2023-08-08T10:39:02Z

We have got a good perf result for parallel compiler under 8 threads. This draft will be used to test perf of changes under multi-threading when we finish some work of query caches or Lock

lqd · 2023-08-08T10:42:11Z

@Dylan-DPC the last activity on this PR is two weeks ago, there's no need for updates yet it's not inactive ^^

Dylan-DPC · 2023-08-08T17:07:19Z

oops yeah, i had sorted prs by date created instead of activity so forgot to see the timestamp of the last commit :P

SparrowLii · 2023-12-01T04:47:14Z

@bors try @rust-timer queue

bors · 2023-12-01T04:48:23Z

⌛ Trying commit 366a1b5 with merge a3832dd...

test for the default parallel compiler on threads=8 test the perf of unchanged parallel compiler with two threads r? `@ghost`

bors · 2023-12-01T06:11:17Z

☀️ Try build successful - checks-actions
Build commit: a3832dd (a3832dd1538d4a9fdcfc3b09fecd01468d84e5a3)

rust-timer · 2023-12-01T07:55:55Z

Finished benchmarking commit (a3832dd): comparison URL.

Overall result: ❌ regressions - ACTION NEEDED

Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. While you can manually mark this PR as fit for rollup, we strongly recommend not doing so since this PR may lead to changes in compiler perf.

Next Steps: If you can justify the regressions found in this try perf run, please indicate this with @rustbot label: +perf-regression-triaged along with sufficient written justification. If you cannot justify the regressions please fix the regressions and do another perf run. If the next run shows neutral or positive results, the label will be automatically removed.

@bors rollup=never
@rustbot label: -S-waiting-on-perf +perf-regression

Warning ⚠: The following benchmark(s) failed to build:

ripgrep-13.0.0

Instruction count

This is a highly reliable metric that was used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	3.3%	[0.2%, 14.2%]	224
Regressions ❌ (secondary)	4.4%	[0.5%, 18.9%]	235
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	3.3%	[0.2%, 14.2%]	224

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	7.7%	[0.7%, 28.5%]	233
Regressions ❌ (secondary)	5.8%	[1.0%, 23.2%]	185
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-3.4%	[-5.1%, -2.2%]	6
All ❌✅ (primary)	7.7%	[0.7%, 28.5%]	233

Cycles

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	31.1%	[1.2%, 74.7%]	251
Regressions ❌ (secondary)	21.4%	[1.0%, 82.2%]	248
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	31.1%	[1.2%, 74.7%]	251

Binary size

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	0.0%	[0.0%, 0.1%]	17
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	0.0%	[0.0%, 0.1%]	17

Bootstrap: 673.487s -> 649.366s (-3.58%)
Artifact size: 313.39 MiB -> 313.73 MiB (0.11%)

SparrowLii · 2023-12-07T00:48:28Z

@bors try @rust-timer queue

rust-timer · 2023-12-07T00:48:31Z

Awaiting bors try build completion.

@rustbot label: +S-waiting-on-perf

bors · 2023-12-07T00:49:39Z

⌛ Trying commit 366a1b5 with merge f54d17c...

test for the default parallel compiler on threads=8 test the perf of unchanged parallel compiler with two threads r? `@ghost`

rust-log-analyzer · 2023-12-07T01:00:28Z

The job dist-x86_64-linux failed! Check out the build log: (web) (plain)

Click to see the possible cause of the failure (guessed by this bot)

[TIMING] core::build_steps::tool::ToolBuild { compiler: Compiler { stage: 0, host: x86_64-unknown-linux-gnu }, target: x86_64-unknown-linux-gnu, tool: "opt-dist", path: "src/tools/opt-dist", mode: ToolBootstrap, is_optional_tool: false, source_type: InTree, extra_features: [], allow_features: "" } -- 41.010
[TIMING] core::build_steps::tool::OptimizedDist { compiler: Compiler { stage: 0, host: x86_64-unknown-linux-gnu }, target: x86_64-unknown-linux-gnu } -- 0.000
Build completed successfully in 0:00:41
+ ./build/x86_64-unknown-linux-gnu/stage0-tools-bin/opt-dist linux-ci -- python3 ../x.py dist --host x86_64-unknown-linux-gnu --target x86_64-unknown-linux-gnu --include-default-paths build-manifest bootstrap
[2023-12-07T00:53:22.890Z INFO  opt_dist] Skipping building of unimportant components for a try build
---
##[group]Building stage1 library artifacts (x86_64-unknown-linux-gnu)
error: failed to run `rustc` to learn about target-specific information

Caused by:
  process didn't exit successfully: `/checkout/obj/build/bootstrap/debug/rustc - --crate-name ___ --print=file-names -Csymbol-mangling-version=legacy -Zunstable-options '--check-cfg=cfg(feature,values(any()))' -Zunstable-options '--check-cfg=cfg(bootstrap,values())' '--check-cfg=cfg(stdarch_intel_sde,values())' '--check-cfg=cfg(no_fp_fmt_parse,values())' '--check-cfg=cfg(no_global_oom_handling,values())' '--check-cfg=cfg(no_rc,values())' '--check-cfg=cfg(no_sync,values())' '--check-cfg=cfg(freebsd12,values())' '--check-cfg=cfg(freebsd13,values())' '--check-cfg=cfg(backtrace_in_libstd,values())' '--check-cfg=cfg(target_env,values("libnx"))' '--check-cfg=cfg(target_arch,values("spirv","nvptx","xtensa"))' -Zmacro-backtrace -Clink-args=-Wl,-z,origin '-Clink-args=-Wl,-rpath,$ORIGIN/../lib' -Clink-args=-fuse-ld=lld -Csplit-debuginfo=off -Cprefer-dynamic -Zinline-mir -Cembed-bitcode=yes '-Zcrate-attr=doc(html_root_url="https://doc.rust-lang.org/nightly/")' --target x86_64-unknown-linux-gnu --crate-type bin --crate-type rlib --crate-type dylib --crate-type cdylib --crate-type staticlib --crate-type proc-macro --print=sysroot --print=split-debuginfo --print=crate-name --print=cfg` (exit status: 254)
  thread 'rustc' panicked at compiler/rustc_data_structures/src/jobserver.rs:73:33:
  jobserver check should have been called earlier
  stack backtrace:
  thread 'rustc' panicked at compiler/rustc_data_structures/src/jobserver.rs:73:33:
  thread 'rustc' panicked at compiler/rustc_data_structures/src/jobserver.rs:73:33:
  jobserver check should have been called earlier
  thread 'rustc' panicked at compiler/rustc_data_structures/src/jobserver.rs:73:33:
  jobserver check should have been called earlier
  thread 'thread 'mainrustc' panicked at ' panicked at compiler/rustc_data_structures/src/jobserver.rscompiler/rustc_data_structures/src/jobserver.rs::7773::3333:
  :
  jobserver check should have been called earlierjobserver check should have been called earlier
  thread 'rustc' panicked at compiler/rustc_data_structures/src/jobserver.rs:73:33:
  jobserver check should have been called earlier
  thread 'rustc' panicked at compiler/rustc_data_structures/src/jobserver.rs:73:33:
  jobserver check should have been called earlier
---
     8:     0x7feb87eac244 - std::sys_common::backtrace::print::h3b927afc1647fbad
                                 at /rustc/f54d17c29bdb1200b1083d364fd2c3f13f01205b/library/std/src/sys_common/backtrace.rs:34:9
     9:     0x7feb87eaeed7 - std::panicking::default_hook::{{closure}}::ha6969053640e854b
    10:     0x7feb87eaec3f - std::panicking::default_hook::hb8c2992d65e2a1fd
                                 at /rustc/f54d17c29bdb1200b1083d364fd2c3f13f01205b/library/std/src/panicking.rs:292:9
    11:     0x7feb8560f6a6 - std[3cc7befc00c2e885]::panicking::update_hook::<alloc[14f9cae0e30d7e5f]::boxed::Box<rustc_driver_impl[a104305ea8c6183c]::install_ice_hook::{closure#0}>>::{closure#0}
    12:     0x7feb87eaf618 - <alloc::boxed::Box<F,A> as core::ops::function::Fn<Args>>::call::ha25fbd5d0c172899
                                 at /rustc/f54d17c29bdb1200b1083d364fd2c3f13f01205b/library/alloc/src/boxed.rs:2029:9
                                 at /rustc/f54d17c29bdb1200b1083d364fd2c3f13f01205b/library/std/src/panicking.rs:783:13
    14:     0x7feb87eaf36e - std::panicking::begin_panic_handler::{{closure}}::hfc2e5d86d9a119a7
                                 at /rustc/f54d17c29bdb1200b1083d364fd2c3f13f01205b/library/std/src/panicking.rs:657:13
    15:     0x7feb87eac926 - std::sys_common::backtrace::__rust_end_short_backtrace::h9ca14654061dc901
---
                                 at /rustc/f54d17c29bdb1200b1083d364fd2c3f13f01205b/library/core/src/panicking.rs:196:5
    19:     0x7feb87efb913 - core::panicking::panic_str::h283a31a663ae054e
                                 at /rustc/f54d17c29bdb1200b1083d364fd2c3f13f01205b/library/core/src/panicking.rs:171:5
    20:     0x7feb87efb913 - core::option::expect_failed::h44a1c3a8ce3ece59
                                 at /rustc/f54d17c29bdb1200b1083d364fd2c3f13f01205b/library/core/src/option.rs:1980:5
    21:     0x7feb879f60c9 - rustc_data_structures[9acb839a4f011a83]::jobserver::acquire_thread
    22:     0x7feb87a380d8 - <rayon_core[de21a43092b5b74f]::registry::ThreadBuilder>::run
    23:     0x7feb85612862 - <<crossbeam_utils[4d36e0f62ade3d30]::thread::ScopedThreadBuilder>::spawn<<rayon_core[de21a43092b5b74f]::ThreadPoolBuilder>::build_scoped<rustc_interface[144b0912e9fa0e54]::util::run_in_thread_pool_with_globals<rustc_interface[144b0912e9fa0e54]::interface::run_compiler<core[8a36ddf6fdea383d]::result::Result<(), rustc_span[9688fd9577add11f]::ErrorGuaranteed>, rustc_driver_impl[a104305ea8c6183c]::run_compiler::{closure#0}>::{closure#0}, core[8a36ddf6fdea383d]::result::Result<(), rustc_span[9688fd9577add11f]::ErrorGuaranteed>>::{closure#3}::{closure#0}::{closure#0}, rustc_interface[144b0912e9fa0e54]::util::run_in_thread_pool_with_globals<rustc_interface[144b0912e9fa0e54]::interface::run_compiler<core[8a36ddf6fdea383d]::result::Result<(), rustc_span[9688fd9577add11f]::ErrorGuaranteed>, rustc_driver_impl[a104305ea8c6183c]::run_compiler::{closure#0}>::{closure#0}, core[8a36ddf6fdea383d]::result::Result<(), rustc_span[9688fd9577add11f]::ErrorGuaranteed>>::{closure#3}::{closure#0}::{closure#1}, core[8a36ddf6fdea383d]::result::Result<(), rustc_span[9688fd9577add11f]::ErrorGuaranteed>>::{closure#0}::{closure#0}::{closure#0}, ()>::{closure#0} as core[8a36ddf6fdea383d]::ops::function::FnOnce<()>>::call_once::{shim:vtable#0}
    24:     0x7feb855f8e4e - std[3cc7befc00c2e885]::sys_common::backtrace::__rust_begin_short_backtrace::<alloc[14f9cae0e30d7e5f]::boxed::Box<dyn core[8a36ddf6fdea383d]::ops::function::FnOnce<(), Output = ()> + core[8a36ddf6fdea383d]::marker::Send>, ()>
    25:     0x7feb85612129 - <<std[3cc7befc00c2e885]::thread::Builder>::spawn_unchecked_<alloc[14f9cae0e30d7e5f]::boxed::Box<dyn core[8a36ddf6fdea383d]::ops::function::FnOnce<(), Output = ()> + core[8a36ddf6fdea383d]::marker::Send>, ()>::{closure#1} as core[8a36ddf6fdea383d]::ops::function::FnOnce<()>>::call_once::{shim:vtable#0}
    26:     0x7feb87eb94a5 - <alloc::boxed::Box<F,A> as core::ops::function::FnOnce<Args>>::call_once::hd1bdc4496162a15a
                                 at /rustc/f54d17c29bdb1200b1083d364fd2c3f13f01205b/library/alloc/src/boxed.rs:2015:9
    27:     0x7feb87eb94a5 - <alloc::boxed::Box<F,A> as core::ops::function::FnOnce<Args>>::call_once::h8b5c739378b82ea9
                                 at /rustc/f54d17c29bdb1200b1083d364fd2c3f13f01205b/library/alloc/src/boxed.rs:2015:9
                                 at /rustc/f54d17c29bdb1200b1083d364fd2c3f13f01205b/library/std/src/sys/unix/thread.rs:108:17
    29:     0x7feb841b5ea5 - start_thread
    30:     0x7feb83edeb0d - clone
    31:                0x0 - <unknown>
---
     8:     0x7feb87eac244 - std::sys_common::backtrace::print::h3b927afc1647fbad
                                 at /rustc/f54d17c29bdb1200b1083d364fd2c3f13f01205b/library/std/src/sys_common/backtrace.rs:34:9
     9:     0x7feb87eaeed7 - std::panicking::default_hook::{{closure}}::ha6969053640e854b
    10:     0x7feb87eaec3f - std::panicking::default_hook::hb8c2992d65e2a1fd
                                 at /rustc/f54d17c29bdb1200b1083d364fd2c3f13f01205b/library/std/src/panicking.rs:292:9
    11:     0x7feb8560f6a6 - std[3cc7befc00c2e885]::panicking::update_hook::<alloc[14f9cae0e30d7e5f]::boxed::Box<rustc_driver_impl[a104305ea8c6183c]::install_ice_hook::{closure#0}>>::{closure#0}
    12:     0x7feb87eaf618 - <alloc::boxed::Box<F,A> as core::ops::function::Fn<Args>>::call::ha25fbd5d0c172899
                                 at /rustc/f54d17c29bdb1200b1083d364fd2c3f13f01205b/library/alloc/src/boxed.rs:2029:9
                                 at /rustc/f54d17c29bdb1200b1083d364fd2c3f13f01205b/library/std/src/panicking.rs:783:13
    14:     0x7feb87eaf36e - std::panicking::begin_panic_handler::{{closure}}::hfc2e5d86d9a119a7
                                 at /rustc/f54d17c29bdb1200b1083d364fd2c3f13f01205b/library/std/src/panicking.rs:657:13
    15:     0x7feb87eac926 - std::sys_common::backtrace::__rust_end_short_backtrace::h9ca14654061dc901
---
                                 at /rustc/f54d17c29bdb1200b1083d364fd2c3f13f01205b/library/core/src/panicking.rs:196:5
    19:     0x7feb87efb913 - core::panicking::panic_str::h283a31a663ae054e
                                 at /rustc/f54d17c29bdb1200b1083d364fd2c3f13f01205b/library/core/src/panicking.rs:171:5
    20:     0x7feb87efb913 - core::option::expect_failed::h44a1c3a8ce3ece59
                                 at /rustc/f54d17c29bdb1200b1083d364fd2c3f13f01205b/library/core/src/option.rs:1980:5
    21:     0x7feb879f60c9 - rustc_data_structures[9acb839a4f011a83]::jobserver::acquire_thread
    22:     0x7feb87a380d8 - <rayon_core[de21a43092b5b74f]::registry::ThreadBuilder>::run
    23:     0x7feb85612862 - <<crossbeam_utils[4d36e0f62ade3d30]::thread::ScopedThreadBuilder>::spawn<<rayon_core[de21a43092b5b74f]::ThreadPoolBuilder>::build_scoped<rustc_interface[144b0912e9fa0e54]::util::run_in_thread_pool_with_globals<rustc_interface[144b0912e9fa0e54]::interface::run_compiler<core[8a36ddf6fdea383d]::result::Result<(), rustc_span[9688fd9577add11f]::ErrorGuaranteed>, rustc_driver_impl[a104305ea8c6183c]::run_compiler::{closure#0}>::{closure#0}, core[8a36ddf6fdea383d]::result::Result<(), rustc_span[9688fd9577add11f]::ErrorGuaranteed>>::{closure#3}::{closure#0}::{closure#0}, rustc_interface[144b0912e9fa0e54]::util::run_in_thread_pool_with_globals<rustc_interface[144b0912e9fa0e54]::interface::run_compiler<core[8a36ddf6fdea383d]::result::Result<(), rustc_span[9688fd9577add11f]::ErrorGuaranteed>, rustc_driver_impl[a104305ea8c6183c]::run_compiler::{closure#0}>::{closure#0}, core[8a36ddf6fdea383d]::result::Result<(), rustc_span[9688fd9577add11f]::ErrorGuaranteed>>::{closure#3}::{closure#0}::{closure#1}, core[8a36ddf6fdea383d]::result::Result<(), rustc_span[9688fd9577add11f]::ErrorGuaranteed>>::{closure#0}::{closure#0}::{closure#0}, ()>::{closure#0} as core[8a36ddf6fdea383d]::ops::function::FnOnce<()>>::call_once::{shim:vtable#0}
    24:     0x7feb855f8e4e - std[3cc7befc00c2e885]::sys_common::backtrace::__rust_begin_short_backtrace::<alloc[14f9cae0e30d7e5f]::boxed::Box<dyn core[8a36ddf6fdea383d]::ops::function::FnOnce<(), Output = ()> + core[8a36ddf6fdea383d]::marker::Send>, ()>
    25:     0x7feb85612129 - <<std[3cc7befc00c2e885]::thread::Builder>::spawn_unchecked_<alloc[14f9cae0e30d7e5f]::boxed::Box<dyn core[8a36ddf6fdea383d]::ops::function::FnOnce<(), Output = ()> + core[8a36ddf6fdea383d]::marker::Send>, ()>::{closure#1} as core[8a36ddf6fdea383d]::ops::function::FnOnce<()>>::call_once::{shim:vtable#0}
    26:     0x7feb87eb94a5 - <alloc::boxed::Box<F,A> as core::ops::function::FnOnce<Args>>::call_once::hd1bdc4496162a15a
                                 at /rustc/f54d17c29bdb1200b1083d364fd2c3f13f01205b/library/alloc/src/boxed.rs:2015:9
    27:     0x7feb87eb94a5 - <alloc::boxed::Box<F,A> as core::ops::function::FnOnce<Args>>::call_once::h8b5c739378b82ea9
                                 at /rustc/f54d17c29bdb1200b1083d364fd2c3f13f01205b/library/alloc/src/boxed.rs:2015:9
                                 at /rustc/f54d17c29bdb1200b1083d364fd2c3f13f01205b/library/std/src/sys/unix/thread.rs:108:17
    29:     0x7feb841b5ea5 - start_thread
    30:     0x7feb83edeb0d - clone
    31:                0x0 - <unknown>
---
     8:     0x7feb87eac244 - std::sys_common::backtrace::print::h3b927afc1647fbad
                                 at /rustc/f54d17c29bdb1200b1083d364fd2c3f13f01205b/library/std/src/sys_common/backtrace.rs:34:9
     9:     0x7feb87eaeed7 - std::panicking::default_hook::{{closure}}::ha6969053640e854b
    10:     0x7feb87eaec3f - std::panicking::default_hook::hb8c2992d65e2a1fd
                                 at /rustc/f54d17c29bdb1200b1083d364fd2c3f13f01205b/library/std/src/panicking.rs:292:9
    11:     0x7feb8560f6a6 - std[3cc7befc00c2e885]::panicking::update_hook::<alloc[14f9cae0e30d7e5f]::boxed::Box<rustc_driver_impl[a104305ea8c6183c]::install_ice_hook::{closure#0}>>::{closure#0}
    12:     0x7feb87eaf618 - <alloc::boxed::Box<F,A> as core::ops::function::Fn<Args>>::call::ha25fbd5d0c172899
                                 at /rustc/f54d17c29bdb1200b1083d364fd2c3f13f01205b/library/alloc/src/boxed.rs:2029:9
                                 at /rustc/f54d17c29bdb1200b1083d364fd2c3f13f01205b/library/std/src/panicking.rs:783:13
    14:     0x7feb87eaf36e - std::panicking::begin_panic_handler::{{closure}}::hfc2e5d86d9a119a7
                                 at /rustc/f54d17c29bdb1200b1083d364fd2c3f13f01205b/library/std/src/panicking.rs:657:13
    15:     0x7feb87eac926 - std::sys_common::backtrace::__rust_end_short_backtrace::h9ca14654061dc901
---
                                 at /rustc/f54d17c29bdb1200b1083d364fd2c3f13f01205b/library/core/src/panicking.rs:196:5
    19:     0x7feb87efb913 - core::panicking::panic_str::h283a31a663ae054e
                                 at /rustc/f54d17c29bdb1200b1083d364fd2c3f13f01205b/library/core/src/panicking.rs:171:5
    20:     0x7feb87efb913 - core::option::expect_failed::h44a1c3a8ce3ece59
                                 at /rustc/f54d17c29bdb1200b1083d364fd2c3f13f01205b/library/core/src/option.rs:1980:5
    21:     0x7feb879f60c9 - rustc_data_structures[9acb839a4f011a83]::jobserver::acquire_thread
    22:     0x7feb87a380d8 - <rayon_core[de21a43092b5b74f]::registry::ThreadBuilder>::run
    23:     0x7feb85612862 - <<crossbeam_utils[4d36e0f62ade3d30]::thread::ScopedThreadBuilder>::spawn<<rayon_core[de21a43092b5b74f]::ThreadPoolBuilder>::build_scoped<rustc_interface[144b0912e9fa0e54]::util::run_in_thread_pool_with_globals<rustc_interface[144b0912e9fa0e54]::interface::run_compiler<core[8a36ddf6fdea383d]::result::Result<(), rustc_span[9688fd9577add11f]::ErrorGuaranteed>, rustc_driver_impl[a104305ea8c6183c]::run_compiler::{closure#0}>::{closure#0}, core[8a36ddf6fdea383d]::result::Result<(), rustc_span[9688fd9577add11f]::ErrorGuaranteed>>::{closure#3}::{closure#0}::{closure#0}, rustc_interface[144b0912e9fa0e54]::util::run_in_thread_pool_with_globals<rustc_interface[144b0912e9fa0e54]::error: the compiler unexpectedly panicked. this is a bug.
  interface::run_compiler
  <core[8a36ddf6fdea383d]::result::Result<(), rustc_span[9688fd9577add11f]::ErrorGuaranteed>, rustc_driver_impl[a104305ea8c6183c]::run_compiler::{note: we would appreciate a bug report: https://github.com/rust-lang/rust/issues/new?labels=C-bug%2C+I-ICE%2C+T-compiler&template=ice.md
  closure#
  0}>::{closure#0}, core[8a36ddf6fdea383d]::result::Result<(), rustc_span[9688fd9577add11f]::ErrorGuaranteed>>::{closure#3}::{closure#0}::{closurewarning: the ICE couldn't be written to `/checkout/rustc-ice-2023-12-07T01_00_11-40952.txt`: Read-only file system (os error 30)
  1}, core[8a36ddf6fdea383d]::result::Resultnote: rustc 1.76.0-nightly (f54d17c29 2023-12-07) running on x86_64-unknown-linux-gnu
  <
  <
  (), rustc_span[9688fd9577add11f]::ErrorGuaranteed>>::{closure#0}::{closure#0}::{closure#0}, ()>::{closure#0} as core[8a36ddf6fdea383dnote: compiler flags: -C symbol-mangling-version=legacy -Z unstable-options -Z unstable-options -Z macro-backtrace -C link-args=-Wl,-z,origin -C link-args=-Wl,-rpath,$ORIGIN/../lib -C link-args=-fuse-ld=lld -C split-debuginfo=off -C prefer-dynamic -Z inline-mir -C embed-bitcode=yes -Z crate-attr=doc(html_root_url="https://doc.rust-lang.org/nightly/") --crate-type bin --crate-type rlib --crate-type dylib --crate-type cdylib --crate-type staticlib --crate-type proc-macro -Z force-unstable-if-unmarked
  ]::
  ops::function::FnOnce<()>>::call_once::{shimquery stack during panic:
  :end of query stack
  vtable#0}
    24:     0x7feb855f8e4e - std[3cc7befc00c2e885]::sys_common::backtrace::__rust_begin_short_backtrace::<alloc[14f9cae0e30d7e5f]::boxed::Box<dyn core[8a36ddf6fdea383d]::ops::function::FnOnce<(), Output = ()> + core[8a36ddf6fdea383d]::marker::Send>, ()>
    25:     0x7feb85612129 - <<std[3cc7befc00c2e885]::thread::Builder>::spawn_unchecked_<alloc[14f9cae0e30d7e5f]::boxed::Box<dyn core[8a36ddf6fdea383d]::ops::function::FnOnce<(), Output = ()> + core[8a36ddf6fdea383d]::marker::Send>, ()>::{closure#1} as core[8a36ddf6fdea383d]::ops::function::FnOnce<()>>::call_once::{shim:vtable#0}
    26:     0x7feb87eb94a5 - <alloc::boxed::Box<F,A> as core::ops::function::FnOnce<Args>>::call_once::hd1bdc4496162a15a
                                 at /rustc/f54d17c29bdb1200b1083d364fd2c3f13f01205b/library/alloc/src/boxed.rs:2015:9
    27:     0x7feb87eb94a5 - <alloc::boxed::Box<F,A> as core::ops::function::FnOnce<Args>>::call_once::h8b5c739378b82ea9
                                 at /rustc/f54d17c29bdb1200b1083d364fd2c3f13f01205b/library/alloc/src/boxed.rs:2015:9
                                 at /rustc/f54d17c29bdb1200b1083d364fd2c3f13f01205b/library/std/src/sys/unix/thread.rs:108:17
    29:     0x7feb841b5ea5 - start_thread
    30:     0x7feb83edeb0d - clone
    31:                0x0 - <unknown>
    31:                0x0 - <unknown>
  Rayon: detected unexpected panic; aborting
  [RUSTC-TIMING] ___ test:false 0.716
  [RUSTC-TIMING] ___ test:false 0.716
  rustc exited with signal: 6 (SIGABRT) (core dumped)
[2023-12-07T01:00:12.308Z INFO  opt_dist::timer] Section `Stage 1 (Rustc PGO) > Build PGO instrumented rustc and LLVM` ended: FAIL (384.89s)`
[2023-12-07T01:00:12.308Z INFO  opt_dist::timer] Section `Stage 1 (Rustc PGO)` ended: FAIL (384.89s)`
[2023-12-07T01:00:12.308Z INFO  opt_dist] Timer results
    -----------------------------------------------------------------
---
Caused by:
    Command RUST_BACKTRACE=full python3 /checkout/x.py build --target x86_64-unknown-linux-gnu --host x86_64-unknown-linux-gnu --stage 2 library/std --rust-profile-generate /tmp/tmp-multistage/opt-artifacts/rustc-pgo --set llvm.thin-lto=false --set llvm.link-shared=true [at /checkout/obj] has failed with exit code Some(1)

Stack backtrace:
   0: <opt_dist::exec::CmdBuilder>::run
             at /rustc/f54d17c29bdb1200b1083d364fd2c3f13f01205b/src/tools/opt-dist/src/exec.rs:78:17
   1: <opt_dist::exec::Bootstrap>::run
             at /rustc/f54d17c29bdb1200b1083d364fd2c3f13f01205b/src/tools/opt-dist/src/exec.rs:179:9
   2: opt_dist::execute_pipeline::{closure#1}::{closure#0}
             at /rustc/f54d17c29bdb1200b1083d364fd2c3f13f01205b/src/tools/opt-dist/src/main.rs:210:13
      <opt_dist::timer::TimerSection>::section::<opt_dist::execute_pipeline::{closure#1}::{closure#0}, ()>
             at /rustc/f54d17c29bdb1200b1083d364fd2c3f13f01205b/src/tools/opt-dist/src/timer.rs:111:22
      opt_dist::execute_pipeline::{closure#1}
             at /rustc/f54d17c29bdb1200b1083d364fd2c3f13f01205b/src/tools/opt-dist/src/main.rs:199:9
      <opt_dist::timer::TimerSection>::section::<opt_dist::execute_pipeline::{closure#1}, opt_dist::training::RustcPGOProfile>
             at /rustc/f54d17c29bdb1200b1083d364fd2c3f13f01205b/src/tools/opt-dist/src/timer.rs:111:22
      opt_dist::execute_pipeline
             at /rustc/f54d17c29bdb1200b1083d364fd2c3f13f01205b/src/tools/opt-dist/src/main.rs:196:29
             at /rustc/f54d17c29bdb1200b1083d364fd2c3f13f01205b/src/tools/opt-dist/src/main.rs:385:18
   4: <fn() -> core::result::Result<(), anyhow::Error> as core::ops::function::FnOnce<()>>::call_once
             at /rustc/782883f609713fe9617ba64d90086742ec62d374/library/core/src/ops/function.rs:250:5
             at /rustc/782883f609713fe9617ba64d90086742ec62d374/library/core/src/ops/function.rs:250:5
      std::sys_common::backtrace::__rust_begin_short_backtrace::<fn() -> core::result::Result<(), anyhow::Error>, core::result::Result<(), anyhow::Error>>
   5: std::rt::lang_start::<core::result::Result<(), anyhow::Error>>::{closure#0}
             at /rustc/782883f609713fe9617ba64d90086742ec62d374/library/std/src/rt.rs:167:18
             at /rustc/782883f609713fe9617ba64d90086742ec62d374/library/std/src/rt.rs:167:18
   6: core::ops::function::impls::<impl core::ops::function::FnOnce<A> for &F>::call_once
      std::panicking::try::do_call
             at /rustc/782883f609713fe9617ba64d90086742ec62d374/library/std/src/panicking.rs:552:40
      std::panicking::try
             at /rustc/782883f609713fe9617ba64d90086742ec62d374/library/std/src/panicking.rs:516:19

bors · 2023-12-07T01:00:40Z

💔 Test failed - checks-actions

Dylan-DPC · 2024-03-24T09:42:19Z

@SparrowLii any updates on this? thanks

SparrowLii · 2024-03-25T00:38:59Z

Yea the parallel compiler has landed in nightly so I think this pr can be closed

This comment has been minimized.

Sign in to view

rustbot added the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Apr 13, 2023

This comment has been minimized.

Sign in to view

rustbot added perf-regression Performance regression. and removed S-waiting-on-perf Status: Waiting on a perf run to be completed. labels Apr 14, 2023

SparrowLii mentioned this pull request May 8, 2023

avoid deadlock when reporting ice #111352

Closed

SparrowLii force-pushed the parallel_2 branch from 4544ab3 to a02cdf6 Compare May 10, 2023 10:42

rustbot added the A-query-system Area: The rustc query system (https://rustc-dev-guide.rust-lang.org/query.html) label May 10, 2023

This comment has been minimized.

Sign in to view

rustbot added the S-waiting-on-perf Status: Waiting on a perf run to be completed. label May 10, 2023

This comment has been minimized.

Sign in to view

rustbot removed the S-waiting-on-perf Status: Waiting on a perf run to be completed. label May 10, 2023

This comment has been minimized.

Sign in to view

rustbot removed the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Jul 26, 2023

SparrowLii changed the title ~~test for the default parallel compiler on threads=2~~ test for the default parallel compiler on threads=8 Oct 9, 2023

set default threads to 8

366a1b5

SparrowLii force-pushed the parallel_2 branch from 1de34eb to 366a1b5 Compare December 1, 2023 04:46

This comment has been minimized.

Sign in to view

rustbot added the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Dec 1, 2023

bors added a commit to rust-lang-ci/rust that referenced this pull request Dec 1, 2023

Auto merge of rust-lang#110284 - SparrowLii:parallel_2, r=<try>

a3832dd

test for the default parallel compiler on threads=8 test the perf of unchanged parallel compiler with two threads r? `@ghost`

This comment has been minimized.

Sign in to view

rustbot removed the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Dec 1, 2023

SparrowLii mentioned this pull request Dec 4, 2023

Change prefetch to avoid deadlock #118488

Merged

rustbot added the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Dec 7, 2023

bors added a commit to rust-lang-ci/rust that referenced this pull request Dec 7, 2023

Auto merge of rust-lang#110284 - SparrowLii:parallel_2, r=<try>

f54d17c

test for the default parallel compiler on threads=8 test the perf of unchanged parallel compiler with two threads r? `@ghost`

SparrowLii closed this Mar 25, 2024

test for the default parallel compiler on threads=8 #110284

test for the default parallel compiler on threads=8 #110284

Conversation

SparrowLii commented Apr 13, 2023

SparrowLii commented Apr 13, 2023

This comment has been minimized.

bors commented Apr 13, 2023

bors commented Apr 13, 2023

This comment has been minimized.

This comment has been minimized.

rust-timer commented Apr 14, 2023

Overall result: ❌✅ regressions and improvements - ACTION NEEDED

SparrowLii commented May 8, 2023

SparrowLii commented May 10, 2023

This comment has been minimized.

bors commented May 10, 2023

bors commented May 10, 2023

This comment has been minimized.

rust-timer commented May 10, 2023

Overall result: ❌✅ regressions and improvements - ACTION NEEDED

This comment has been minimized.

SparrowLii commented May 11, 2023

This comment has been minimized.

This comment has been minimized.

rust-timer commented Jul 26, 2023

Overall result: ❌✅ regressions and improvements - ACTION NEEDED

Dylan-DPC commented Aug 8, 2023

SparrowLii commented Aug 8, 2023 • edited Loading

lqd commented Aug 8, 2023

Dylan-DPC commented Aug 8, 2023

SparrowLii commented Dec 1, 2023

This comment has been minimized.

bors commented Dec 1, 2023

bors commented Dec 1, 2023

This comment has been minimized.

rust-timer commented Dec 1, 2023

Overall result: ❌ regressions - ACTION NEEDED

SparrowLii commented Dec 7, 2023

rust-timer commented Dec 7, 2023

bors commented Dec 7, 2023

rust-log-analyzer commented Dec 7, 2023

bors commented Dec 7, 2023

Dylan-DPC commented Mar 24, 2024

SparrowLii commented Mar 25, 2024

SparrowLii commented Aug 8, 2023 •

edited

Loading