-
Notifications
You must be signed in to change notification settings - Fork 12.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Split out a separate feature gate for impl trait in associated types #110237
Conversation
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @jackh726 (or someone else) soon. Please see the contribution instructions for more information. Namely, in order to ensure the minimum review times lag, PR authors and assigned reviewers should ensure that the review label (
|
r=me with CI green |
65d3b42
to
28f7646
Compare
28f7646
to
f263f88
Compare
@bors r=jackh726 |
…iaskrgr Rollup of 8 pull requests Successful merges: - rust-lang#110153 (Fix typos in compiler) - rust-lang#110165 (rustdoc: use CSS `overscroll-behavior` instead of JavaScript) - rust-lang#110175 (Symbol cleanups) - rust-lang#110203 (Remove `..` from return type notation) - rust-lang#110205 (rustdoc: make settings radio and checks thicker, less contrast) - rust-lang#110222 (Improve the error message when forwarding a matched fragment to another macro) - rust-lang#110237 (Split out a separate feature gate for impl trait in associated types) - rust-lang#110241 (tidy: Issue an error when UI test limits are too high) Failed merges: - rust-lang#110218 (Remove `ToRegionVid`) r? `@ghost` `@rustbot` modify labels: rollup
…assoc_type` This change was introduced by rust-lang/rust#110237 in the latest nightlies.
This change was introduced by rust-lang/rust#110237 in the latest nightly.
This change was introduced by rust-lang/rust#110237 in the latest nightly.
This change was introduced by rust-lang/rust#110237 in the latest nightly.
Includes this TAIT breaking change. rust-lang/rust#110237
Includes this TAIT breaking change. rust-lang/rust#110237
Includes this TAIT breaking change. rust-lang/rust#110237
See rust-lang/rust/pull/110237 Signed-off-by: Neil Shen <overvenus@gmail.com>
in #107645 it was decided that we'll take a new route for type alias impl trait. The exact route isn't clear yet, so while I'm working on implementing some of these proposed changes (e.g. in #110010) to be able to experiment with them, I will also work on stabilizing another sugar version first: impl trait in associated types. Similarly I'll look into creating feature gates for impl trait in const/static types.
This PR does nothing but split the feature gate, so that you need to enable a different feature gate for
than what you need for
type Foo = impl SomeTrait;