Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split out a separate feature gate for impl trait in associated types #110237

Merged
merged 1 commit into from
Apr 12, 2023

Conversation

oli-obk
Copy link
Contributor

@oli-obk oli-obk commented Apr 12, 2023

in #107645 it was decided that we'll take a new route for type alias impl trait. The exact route isn't clear yet, so while I'm working on implementing some of these proposed changes (e.g. in #110010) to be able to experiment with them, I will also work on stabilizing another sugar version first: impl trait in associated types. Similarly I'll look into creating feature gates for impl trait in const/static types.

This PR does nothing but split the feature gate, so that you need to enable a different feature gate for

impl Trait for Type {
    type Assoc = impl SomeTrait;
}

than what you need for type Foo = impl SomeTrait;

@rustbot
Copy link
Collaborator

rustbot commented Apr 12, 2023

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @jackh726 (or someone else) soon.

Please see the contribution instructions for more information. Namely, in order to ensure the minimum review times lag, PR authors and assigned reviewers should ensure that the review label (S-waiting-on-review and S-waiting-on-author) stays updated, invoking these commands when appropriate:

  • @rustbot author: the review is finished, PR author should check the comments and take action accordingly
  • @rustbot review: the author is ready for a review, this PR will be queued again in the reviewer's queue

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Apr 12, 2023
@jackh726
Copy link
Member

r=me with CI green

@oli-obk oli-obk force-pushed the impl_trait_in_assoc_tys branch from 65d3b42 to 28f7646 Compare April 12, 2023 15:50
@oli-obk oli-obk force-pushed the impl_trait_in_assoc_tys branch from 28f7646 to f263f88 Compare April 12, 2023 16:17
@oli-obk
Copy link
Contributor Author

oli-obk commented Apr 12, 2023

@bors r=jackh726

@bors
Copy link
Contributor

bors commented Apr 12, 2023

📌 Commit f263f88 has been approved by jackh726

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 12, 2023
bors added a commit to rust-lang-ci/rust that referenced this pull request Apr 12, 2023
…iaskrgr

Rollup of 8 pull requests

Successful merges:

 - rust-lang#110153 (Fix typos in compiler)
 - rust-lang#110165 (rustdoc: use CSS `overscroll-behavior` instead of JavaScript)
 - rust-lang#110175 (Symbol cleanups)
 - rust-lang#110203 (Remove `..` from return type notation)
 - rust-lang#110205 (rustdoc: make settings radio and checks thicker, less contrast)
 - rust-lang#110222 (Improve the error message when forwarding a matched fragment to another macro)
 - rust-lang#110237 (Split out a separate feature gate for impl trait in associated types)
 - rust-lang#110241 (tidy: Issue an error when UI test limits are too high)

Failed merges:

 - rust-lang#110218 (Remove `ToRegionVid`)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 214e4ef into rust-lang:master Apr 12, 2023
@rustbot rustbot added this to the 1.70.0 milestone Apr 12, 2023
AlexTMjugador added a commit to ComunidadAylas/PackSquash that referenced this pull request Apr 13, 2023
…assoc_type`

This change was introduced by
rust-lang/rust#110237 in the latest nightlies.
BlueGlassBlock added a commit to BlueGlassBlock/ricq that referenced this pull request Apr 13, 2023
This change was introduced by
rust-lang/rust#110237 in the latest nightly.
BlueGlassBlock added a commit to BlueGlassBlock/ricq that referenced this pull request Apr 13, 2023
This change was introduced by rust-lang/rust#110237 in the latest nightly.
lz1998 pushed a commit to lz1998/ricq that referenced this pull request Apr 13, 2023
This change was introduced by
rust-lang/rust#110237 in the latest nightly.
Dirbaio added a commit to embassy-rs/embassy that referenced this pull request Apr 14, 2023
Includes this TAIT breaking change. rust-lang/rust#110237
Dirbaio added a commit to embassy-rs/embassy that referenced this pull request Apr 17, 2023
Includes this TAIT breaking change. rust-lang/rust#110237
Dirbaio added a commit to embassy-rs/embassy that referenced this pull request Apr 18, 2023
Includes this TAIT breaking change. rust-lang/rust#110237
@workingjubilee workingjubilee added the F-impl_trait_in_assoc_type `#![feature(impl_trait_in_assoc_type)]` label Nov 8, 2023
overvenus added a commit to overvenus/tikv that referenced this pull request Dec 22, 2023
See rust-lang/rust/pull/110237

Signed-off-by: Neil Shen <overvenus@gmail.com>
@oli-obk oli-obk deleted the impl_trait_in_assoc_tys branch June 13, 2024 06:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
F-impl_trait_in_assoc_type `#![feature(impl_trait_in_assoc_type)]` S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants