Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove ToRegionVid #110218

Merged
merged 4 commits into from
Apr 13, 2023
Merged

Remove ToRegionVid #110218

merged 4 commits into from
Apr 13, 2023

Commits on Apr 13, 2023

  1. Make Region::as_var infallible. 

    It's what all the call sites require.
    @nnethercote
    nnethercote committed Apr 13, 2023
    Configuration menu
    Copy the full SHA
    c802694 View commit details
    Browse the repository at this point in the history

  2. Remove impl ToRegionVid for RegionVid. 

    It's weird and unnecessary.
    @nnethercote
    nnethercote committed Apr 13, 2023
    Configuration menu
    Copy the full SHA
    411422f View commit details
    Browse the repository at this point in the history

  3. Remove ToRegionVid. 

    It is only implemented for `Region`, where it is equivalent to the
inherent `as_var` method.
    @nnethercote
    nnethercote committed Apr 13, 2023
    Configuration menu
    Copy the full SHA
    bbc4009 View commit details
    Browse the repository at this point in the history

  4. Remove some unused type folders. 

    I'm surprised the compiler doesn't warn about these. It appears having
an `impl` on a struct is enough to avoid a warning about it never being
constructed.
    @nnethercote
    nnethercote committed Apr 13, 2023
    Configuration menu
    Copy the full SHA
    72605cd View commit details
    Browse the repository at this point in the history