Rollup of 9 pull requests #110201
Closed
Rollup of 9 pull requests #110201
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… literals" Reverts PR rust-lang#108031 Fixes (doesnt close until beta backported) rust-lang#109746 This reverts commit e3f9db5. This reverts commit 98b82ae. This reverts commit 380fa26.
This will allow moving jobs between 8 and 16 core VMs in the next commit more easily.
These builders aren't particularly high on overall average CPU usage and finish in typically around 30 minutes. Cutting their core counts will hopefully not significantly increase wall-time while cutting costs, allowing us to shift some of the wins into our slower builders.
This functionality is already tested in `hash-item-expansion.goml`, and was implemented twice: * First, in code that ran at load time and at hash change: 917cdd2 * Later, the hash change event handler was itself run at load time, and the code handling both cases diverged in implementation, though their behavior still matches pretty well: f66a331
Fixes the desktop scrolling weirdness mentioned in rust-lang#98775 (comment) As described in the MDN page for this property: * The current Firefox ESR is 102, and the first Firefox version to support this feature is 59. * The current Chrome version 112, and the first version to support this is 63. * Edge is described as having a minor bug in `none` mode, but we use `contain` mode anyway, so it doesn't matter. * Safari 16, released September 2022, is the last browser to add this feature, and is also the oldest version we officially support.
For a common pattern.
There's a bad pattern matching confusion present in this function. `_anon` gets assigned to, and then `_anon` is used as an unbound variable in the pattern, which is unrelated to the first `_anon`. If the `_anon` didn't start with `_` the compiler would give warnings. This was introduced in rust-lang#104239. I have rewritten the function to remove the confusion and preserve the existing behaviour. This seems safest, because the original intent is not clear.
I have no idea why it's here, but it's not used at all.
…avidtwco Revert "Don't recover lifetimes/labels containing emojis as character literals" Reverts PR rust-lang#108031 per rust-lang#109754 (comment) Fixes (doesnt close until beta backported) rust-lang#109746 This reverts commit e3f9db5. This reverts commit 98b82ae. This reverts commit 380fa26.
…, r=pietroalbini Reduce core counts for a number of builders Best reviewed by-commit; first commit renames all builder names to include core counts. Applied changes for these builders (only on the auto branch, haven't touched PR CI): - arm-android -> 8 core (currently at 39 minutes; 25.58% CPU) - armhf-gnu -> 8 core (currently at 31 minutes; 30.97% CPU) - dist-aarch64-linux -> 8 core (currently at 35 minutes; 55.38% CPU) - dist-android -> 8 core (currently at 18 minutes; 43.03% CPU) - dist-armhf-linux -> 8 core (currently at 27 minutes; 54.71% CPU) - dist-armv7-linux -> 8 core (currently at 29 minutes; 50.33% CPU) - dist-i586-gnu-i586-i686-musl -> 8 core (currently at 27 minutes; 48.31% CPU) - dist-i686-linux -> 8 core (currently at 32 minutes; 52.39% CPU) - dist-mips-linux -> 8 core (currently at 25 minutes; 55.09% CPU) - dist-mips64-linux -> 8 core (currently at 25 minutes; 55.33% CPU) - dist-mips64el-linux -> 8 core (currently at 26 minutes; 54.93% CPU) - dist-mipsel-linux -> 8 core (currently at 25 minutes; 55.38% CPU) - dist-powerpc-linux -> 8 core (currently at 26 minutes; 55.77% CPU) - dist-powerpc64-linux -> 8 core (currently at 27 minutes; 55.03% CPU) - dist-powerpc64le-linux -> 8 core (currently at 27 minutes; 54.95% CPU) - dist-riscv64-linux -> 8 core (currently at 26 minutes; 54.43% CPU) - dist-s390x-linux -> 8 core (currently at 30 minutes; 55.97% CPU) - dist-various-1 -> 8 core (currently at 36 minutes; 29.16% CPU) - dist-various-2 -> 8 core (currently at 27 minutes; 32.69% CPU) - dist-x86_64-freebsd -> 8 core (currently at 27 minutes; 51.69% CPU) - dist-x86_64-illumos -> 8 core (currently at 30 minutes; 54.88% CPU) - dist-x86_64-musl -> 8 core (currently at 39 minutes; 57.56% CPU) - dist-x86_64-netbsd -> 8 core (currently at 26 minutes; 55.82% CPU) - mingw-check -> 8 core (currently at 17 minutes; 35.00% CPU) - test-various -> 8 core (currently at 22 minutes; 44.84% CPU) - wasm32 -> 8 core (currently at 19 minutes; 62.94% CPU) - x86_64-gnu -> 8 core (currently at 32 minutes; 50.31% CPU) - x86_64-gnu-stable -> 8 core (currently at 32 minutes; 51.23% CPU) - x86_64-gnu-aux -> 8 core (currently at 22 minutes; 46.39% CPU) - x86_64-gnu-debug -> 8 core (currently at 21 minutes; 53.93% CPU) - x86_64-gnu-distcheck -> 8 core (currently at 38 minutes; 55.93% CPU) - x86_64-gnu-llvm-15 -> 8 core (currently at 34 minutes; 52.99% CPU) - x86_64-gnu-llvm-14 -> 8 core (currently at 34 minutes; 52.09% CPU) - x86_64-gnu-llvm-14-stage1 -> 8 core (currently at 33 minutes; 51.13% CPU) - x86_64-gnu-nopt -> 8 core (currently at 29 minutes; 53.36% CPU) - x86_64-gnu-tools -> 8 core (currently at 22 minutes; 40.56% CPU) We may also want to look at merging some of these builders in the future (to deduplicate stage0 builds and such) but that can happen separately - and is more work than just adjusting core counts. r? `@pietroalbini`
Fix typos in compiler I ran [`typos -w compiler`](https://github.com/crate-ci/typos) to fix typos in the `compiler` directory. Refs rust-lang#110150
…, r=GuillaumeGomez rustdoc: remove redundant expandSection code from main.js This functionality is already tested in `hash-item-expansion.goml`, and was implemented twice: * First, in code that ran at load time and at hash change: 917cdd2 * Later, the hash change event handler was itself run at load time, and the code handling both cases diverged in implementation, though their behavior still matches pretty well: f66a331
…avior, r=GuillaumeGomez rustdoc: use CSS `overscroll-behavior` instead of JavaScript Fixes the desktop scrolling weirdness mentioned in rust-lang#98775 (comment) Preview: https://notriddle.com/rustdoc-demo-html-3/overscroll-behavior/issue_107918/index.html As described in the [MDN overscroll-behavior] page: * The current Firefox ESR is 102, and the first Firefox version to support this feature is 59. * The current Chrome version 112, and the first version to support this is 63. * Edge is described as having a minor bug in `none` mode, but we use `contain` mode anyway, so it doesn't matter. * Safari 16, released September 2022, is the last browser to add this feature, and is also the oldest version we officially support. [MDN overscroll-behavior]: https://developer.mozilla.org/en-US/docs/Web/CSS/overscroll-behavior
…kh726 Symbol cleanups r? `@jackh726` cc `@b-naber`
Use `itertools::Either` instead of own impl Yeah.
…=jyn514 Remove orphaned remove_dir_all implementation from rust-installer I have no idea why it's here, but it's not used at all. r? Mark-Simulacrum
Custom MIR: Support `BinOp::Offset` Since offset doesn't have an infix operator, a new function `Offset` is added which is lowered to `Rvalue::BinaryOp(BinOp::Offset, ..)` r? `@oli-obk` or `@tmiasko` or `@JakobDegen`
rustbot
added
A-testsuite
rustbot
added
T-libs
|
@bors r+ rollup=never p=9 |
bors
added
S-waiting-on-bors
|
⌛ Testing commit 5eb6805 with merge e8ee8de4c44754e11406b83b6435dfa4d302c86e... |
|
💔 Test failed - checks-actions |
bors
added
S-waiting-on-review
Spurious? @bors retry |
bors
added
S-waiting-on-bors
|
⌛ Testing commit 5eb6805 with merge 8e84f5023b3f23fd53e36bde48c806f0ec354a77... |
|
💔 Test failed - checks-actions |
bors
added
S-waiting-on-review
|
Not sure what the test failure is from, perhaps #110142? |
|
The job Click to see the possible cause of the failure (guessed by this bot) |
|
The job Click to see the possible cause of the failure (guessed by this bot) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Successful merges:
overscroll-behaviorinstead of JavaScript #110165 (rustdoc: use CSSoverscroll-behaviorinstead of JavaScript)itertools::Eitherinstead of own impl #110182 (Useitertools::Eitherinstead of own impl)BinOp::Offset#110190 (Custom MIR: SupportBinOp::Offset)Failed merges:
r? @ghost
@rustbot modify labels: rollup
Create a similar rollup