Report overflows gracefully with new solver #110103
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
S-waiting-on-review
|
Some changes occurred to the core trait solver cc @rust-lang/initiative-trait-system-refactor |
lcnr
reviewed
Apr 10, 2023
Comment on lines
131
to
134
| CodeAmbiguity, | ||
| /// Overflow reported from the new solver `-Ztrait-solver=next`, which will | ||
| /// be reported as an regular error as opposed to a fatal error. | ||
| CodeOverflow, |
There was a problem hiding this comment.
can you merge CodeOverflow with CodeAmbiguity?
This should make it clearer that overflow should be treated as ambiguous and not as an actual hard error.
So something like CodeAmbuguity { overflow: bool }
r=me after that
|
☔ The latest upstream changes (presumably #110137) made this pull request unmergeable. Please resolve the merge conflicts. |
rust-cloud-vms
bot
force-pushed
the
new-solver-overflows
branch
2 times, most recently
from
b374229
to
9f9df8f
Compare
rust-cloud-vms
bot
force-pushed
the
new-solver-overflows
branch
from
9f9df8f
to
05a6daa
Compare
|
@bors r=lcnr |
bors
added
S-waiting-on-bors
Dylan-DPC
added a commit
to Dylan-DPC/rust
that referenced
this pull request
Apr 11, 2023
…ws, r=lcnr Report overflows gracefully with new solver avoid reporting overflows as ambiguity errors, so that the error message is clearer. r? `@lcnr`
compiler-errors
added a commit
to compiler-errors/rust
that referenced
this pull request
Apr 11, 2023
…ws, r=lcnr Report overflows gracefully with new solver avoid reporting overflows as ambiguity errors, so that the error message is clearer. r? ``@lcnr``
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Apr 12, 2023
…iaskrgr Rollup of 8 pull requests Successful merges: - rust-lang#109810 (Replace rustdoc-ui/{c,z}-help tests with a stable run-make test ) - rust-lang#110035 (fix: ensure bad `#[test]` invocs retain correct AST) - rust-lang#110089 (sync::mpsc: synchronize receiver disconnect with initialization) - rust-lang#110103 (Report overflows gracefully with new solver) - rust-lang#110122 (Fix x check --stage 1 when download-ci-llvm=false) - rust-lang#110133 (Do not use ImplDerivedObligationCause for inherent impl method error reporting) - rust-lang#110135 (Revert "Don't recover lifetimes/labels containing emojis as character literals") - rust-lang#110235 (Fix `--extend-css` option) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
avoid reporting overflows as ambiguity errors, so that the error message is clearer.
r? @lcnr