Rollup of 7 pull requests #109998
Closed
Rollup of 7 pull requests #109998
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Oli Scherer <github35764891676564198441@oli-obk.de>
Signed-off-by: ozkanonur <work@onurozkan.dev>
…alizer, r=oli-obk use `ObligationCtxt` not `QueryNormalizer` in rustdoc's `normalization` `QueryNormalizer` doesn't handle not-well-formed projections or ambiguity so should not be used by rustdoc as rustdoc happens on code that is not well formed. This PR replaces the usage of `QueryNormalizer` with `ObligationCtxt::normalize` which is designed to work on not-wf code while not being in typeck. This also removes two uses of `actually_rustdoc` from the compiler which seems good to me. I am somewhat confused as to the "point" of `QueryNormalizer`, it intends to be "the main way of normalizing" in the future and yet ICEs when encountering not wf types or when normalization is ambiguous which seems very incompatible with its stated goal since that makes it only suitable for using after typeck?
…t_test, r=jyn514 extend `detect_src_and_out` test > I was thinking about the following cases when I wrote the comment in rust-lang#109055 > > 1. Running bootstrap from the source root. > 2. Running from a subdirectory of the source root. > 3. Running from outside the source root. > 4. Running on a different machine from where bootstrap was compiled (which will be important > for rust-lang#107812). You can mostly replicate this by renaming the source root so it no longer exists on disk. > 5. Running with `--build-dir`. > 6. Running with `$RUST_BOOTSTRAP_CONFIG` set in the environment and `build-dir` set in the file. Tested all the topics mentioned above. All worked fine. The test is now also covers if build dir is manually specified in config. r? `@jyn514` helps rust-lang#109120 partially
…gillot Fix issue when there are multiple candidates for edit_distance_with_substrings Fixes rust-lang#109291
…or-witness-mir, r=cjgillot Implement support for `GeneratorWitnessMIR` in new solver r? `@cjgillot` I mostly want this to cut down the number of failing UI tests when running the UI test suite with `--compare-mode=next-solver`, but there doesn't seem like much reason to block implementing this since it adds minimal complexity to the existing structural traits impl in the new solver. If others are against adding this for some reason, then maybe we should just make `GeneratorWitnessMIR` return `NoSolution` for these traits. Anything but an ICE please 😸 🧊
…, r=jsha,the8472 rustdoc: avoid including line numbers in Google SERP snippets 
…ottmcm Derive String's PartialEq implementation
Remove f32 & f64 from MemDecoder/MemEncoder r? `@Nilstrieb` since they said (maybe joked) on discord that it's a bug if the compiler uses f32 anywhere 🙃
rustbot
added
A-query-system
|
@bors r+ rollup=never p=5 |
bors
added
S-waiting-on-bors
|
⌛ Testing commit 27adc70 with merge d957ef74d7e8e048ceb94473ac03619a38c794ed... |
|
💔 Test failed - checks-actions |
bors
added
S-waiting-on-review
|
The job Click to see the possible cause of the failure (guessed by this bot) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Successful merges:
ObligationCtxtnotQueryNormalizerin rustdoc'snormalization#108503 (useObligationCtxtnotQueryNormalizerin rustdoc'snormalization)detect_src_and_outtest #109162 (extenddetect_src_and_outtest)GeneratorWitnessMIRin new solver #109755 (Implement support forGeneratorWitnessMIRin new solver)Failed merges:
r? @ghost
@rustbot modify labels: rollup
Create a similar rollup