-
Notifications
You must be signed in to change notification settings - Fork 13k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add inline assembly support for m68k #109989
Conversation
(rustbot has picked a reviewer for you, use r? to override) |
Apparently |
Some changes occurred in compiler/rustc_codegen_gcc cc @antoyo |
📌 Commit ba1d7b9fe5a5bc21cff2c4866c4a518f1b668eba has been approved by It is now in the queue for this repository. |
@bors r- |
Also please add a test in tests/assembly/asm to ensure that:
|
r? @Amanieu |
57d278c
to
6a151c9
Compare
src/doc/unstable-book/src/language-features/asm-experimental-arch.md
Outdated
Show resolved
Hide resolved
src/doc/unstable-book/src/language-features/asm-experimental-arch.md
Outdated
Show resolved
Hide resolved
src/doc/unstable-book/src/language-features/asm-experimental-arch.md
Outdated
Show resolved
Hide resolved
4c3e2db
to
a0de8e1
Compare
@@ -244,6 +244,7 @@ impl<'ll, 'tcx> AsmBuilderMethods<'tcx> for Builder<'_, 'll, 'tcx> { | |||
InlineAsmArch::Msp430 => { | |||
constraints.push("~{sr}".to_string()); | |||
} | |||
InlineAsmArch::M68k => {} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should clobber ccr
. Also document this in the unstable book under the preserves_flags
section.
@bors r+ |
⌛ Testing commit 2ac8dee with merge 1870bbdaba6f3e8202139f5ce939223adb875e9c... |
💔 Test failed - checks-actions |
@bors retry |
☀️ Test successful - checks-actions |
Finished benchmarking commit (e14b81f): comparison URL. Overall result: no relevant changes - no action needed@rustbot label: -perf-regression Instruction countThis benchmark run did not return any relevant results for this metric. Max RSS (memory usage)ResultsThis is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
CyclesResultsThis is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
|
The job Click to see the possible cause of the failure (guessed by this bot)
|
@bors retry |
Oh wait this is already merged. |
Add inline assembly support for m68k I believe this should be correct, to the extent I understand the logic around inline assembly. M68k is fairly straightforward here, other than having separate address registers.
I believe this should be correct, to the extent I understand the logic around inline assembly. M68k is fairly straightforward here, other than having separate address registers.