Move almost all run-make-fulldeps tests to run-make #109770
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
They pass fine.
jyn514
changed the title
|
(rustbot has picked a reviewer for you, use r? to override) |
rustbot
added
the
S-waiting-on-review
|
You may need to add |
apparently I missed some tests in the last commit. Rather than having dozens of tests use the long version, use the short version in `run-make` and the long version in `run-make-fulldeps` (which is now only three tests)
`run-make-fulldeps` is never cross-compiled, so a lot of these tests never accounted for --target. Ignore them when cross-compiling for now.
|
@bors r+ rollup=iffy Presuming this passes CI, I think it makes sense - I'm a little surprised we put so many tests in the wrong category, but not that much :) |
bors
added
S-waiting-on-bors
|
⌛ Testing commit 4851d56 with merge af86a1d8720c1fcb8184a05eeba5eb8f2f4aea2f... |
|
💔 Test failed - checks-actions |
bors
added
S-waiting-on-review
This comment has been minimized.
This comment has been minimized.
rustbot
added
A-testsuite
jyn514
force-pushed
the
run-make-fulldeps
branch
from
4e5064f
to
c45037b
Compare
bors
added
S-waiting-on-bors
|
☀️ Test successful - checks-actions |
1 similar comment
|
☀️ Test successful - checks-actions |
|
Finished benchmarking commit (3328913): comparison URL. Overall result: no relevant changes - no action needed@rustbot label: -perf-regression Instruction countThis benchmark run did not return any relevant results for this metric. Max RSS (memory usage)ResultsThis is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
CyclesResultsThis is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
|
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Apr 14, 2023
Move most ui-fulldeps tests to ui/ Same rationale as rust-lang#109770, they don't actually need a stage 2 build. This increases the limit for the UI directory because otherwise it was annoying to be constantly moving files into subdirectories when I fixed a test; rust-lang#109873 makes up for it. cc rust-lang#109770, rust-lang#109874
RalfJung
pushed a commit
to RalfJung/miri
that referenced
this pull request
Apr 14, 2023
Move most ui-fulldeps tests to ui/ Same rationale as rust-lang/rust#109770, they don't actually need a stage 2 build. This increases the limit for the UI directory because otherwise it was annoying to be constantly moving files into subdirectories when I fixed a test; rust-lang/rust#109873 makes up for it. cc rust-lang/rust#109770, rust-lang/rust#109874
matthiaskrgr
added a commit
to matthiaskrgr/rust
that referenced
this pull request
Jun 9, 2024
…-ozkan Remove empty test suite `tests/run-make-fulldeps` After rust-lang#109770, there were only a handful of tests left in the run-make-fulldeps suite. As of rust-lang#126111, there are no longer *any* run-make-fulldeps tests, so now we can: - Remove the directory - Remove related bootstrap/compiletest code - Remove various other references in CI scripts and documentation. By removing this suite, we also no longer need to worry about discrepancies between it and ui-fulldeps, and we don't have to worry about porting tests from Makefile to [rmake](rust-lang#121876) (or whether rmake even works with fulldeps).
rust-timer
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Jun 9, 2024
Rollup merge of rust-lang#126155 - Zalathar:run-make-fulldeps, r=onur-ozkan Remove empty test suite `tests/run-make-fulldeps` After rust-lang#109770, there were only a handful of tests left in the run-make-fulldeps suite. As of rust-lang#126111, there are no longer *any* run-make-fulldeps tests, so now we can: - Remove the directory - Remove related bootstrap/compiletest code - Remove various other references in CI scripts and documentation. By removing this suite, we also no longer need to worry about discrepancies between it and ui-fulldeps, and we don't have to worry about porting tests from Makefile to [rmake](rust-lang#121876) (or whether rmake even works with fulldeps).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
They pass fine, and this avoids having to build the compiler twice.
There are few enough tests left that I think it should be possible to get rid of this test suite altogether, but I expect this PR to fail at least a few times in bors and want to get it merged before tackling further changes. cc #83775
Fixes #66085. Fixes #83773.