rustdoc: implement bag semantics for function parameter search #109331
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(rustbot has picked a reviewer for you, use r? to override) |
rustbot
added
S-waiting-on-review
|
Some changes occurred in HTML/CSS/JS. cc @GuillaumeGomez, @Folyd, @jsha |
|
Can you give a bit more explanations about what this is doing please? |
|
@GuillaumeGomez Okay, I added a description to the PR. Does that make sense? |
This comment has been minimized.
This comment has been minimized.
GuillaumeGomez
approved these changes
Mar 19, 2023
|
Yes it does! Thanks for the explanation. Seems like the CI is failing for everyone. Once fixed, r=me. |
notriddle
force-pushed
the
notriddle/search-bag-semantics
branch
2 times, most recently
from
09233f9 to
2402b90
Compare
This comment has been minimized.
This comment has been minimized.
notriddle
force-pushed
the
notriddle/search-bag-semantics
branch
from
2402b90 to
19dc4ce
Compare
This comment has been minimized.
This comment has been minimized.
notriddle
force-pushed
the
notriddle/search-bag-semantics
branch
from
19dc4ce to
52ef786
Compare
This comment has been minimized.
This comment has been minimized.
This tweak to the function signature search engine makes things so that, if a type is repeated in the search query, it'll only match if the function actually includes it that many times.
notriddle
force-pushed
the
notriddle/search-bag-semantics
branch
from
52ef786 to
5451fe7
Compare
|
@bors r=GuillaumeGomez rollup |
bors
added
S-waiting-on-bors
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Mar 20, 2023
…iaskrgr Rollup of 13 pull requests Successful merges: - rust-lang#109249 (Update names/comments for new return-position impl trait in trait lowering strategy) - rust-lang#109259 (rustdoc: Fix missing private inlining) - rust-lang#109269 (rustdoc: cleanup some intermediate allocs) - rust-lang#109301 (fix: fix ICE in `custom-test-frameworks` feature) - rust-lang#109319 (Add test for `c_variadic` in rustdoc-json) - rust-lang#109323 (Ignore files in .gitignore in mir opt check) - rust-lang#109331 (rustdoc: implement bag semantics for function parameter search) - rust-lang#109337 (Improve `Iterator::collect_into` documentation) - rust-lang#109351 (rustdoc: Remove footnote references from doc summary) - rust-lang#109353 (Fix wrong crate name in custom MIR docs) - rust-lang#109362 (Split `items` from `-Zmeta-stats` in two.) - rust-lang#109370 (fix ClashingExternDeclarations lint ICE) - rust-lang#109375 (rustdoc: Fix improper escaping of deprecation reasons) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This tweak to the function signature search engine makes things so that, if a type is repeated in the search query, it'll only match if the function actually includes it that many times.