Revert "Auto merge of #107224 - nikic:llvm-16, r=cuviper" #109326

nikic · 2023-03-18T22:14:10Z

This reverts commit 4a04d08, reversing changes made to 2d0a7de.

The LLVM 16 upgrade is almost certainly responsible for the CI segfaults that were observed after it landed, looking something like this:

Building stage1 library artifacts (x86_64-unknown-linux-gnu) 
error: failed to run `rustc` to learn about target-specific information

Caused by:
  process didn't exit successfully: `/checkout/obj/build/bootstrap/debug/rustc - --crate-name ___ --print=file-names -Csymbol-mangling-version=legacy -Zunstable-options -Zunstable-options '--check-cfg=values(bootstrap)' '--check-cfg=values(stdarch_intel_sde)' '--check-cfg=values(no_fp_fmt_parse)' '--check-cfg=values(no_global_oom_handling)' '--check-cfg=values(no_rc)' '--check-cfg=values(no_sync)' '--check-cfg=values(freebsd12)' '--check-cfg=values(backtrace_in_libstd)' '--check-cfg=values(target_env,"libnx")' '--check-cfg=values(target_arch,"asmjs","spirv","nvptx","xtensa")' -Zmacro-backtrace -Clink-args=-Wl,-z,origin '-Clink-args=-Wl,-rpath,$ORIGIN/../lib' -Csplit-debuginfo=off -Cprefer-dynamic -Cembed-bitcode=yes '-Zcrate-attr=doc(html_root_url="https://doc.rust-lang.org/nightly/")' --target x86_64-unknown-linux-gnu --crate-type bin --crate-type rlib --crate-type dylib --crate-type cdylib --crate-type staticlib --crate-type proc-macro --print=sysroot --print=split-debuginfo --print=crate-name --print=cfg` (exit status: 254)
  --- stderr
  /checkout/obj/build/x86_64-unknown-linux-gnu/stage1/lib/librustc_driver-fdca23ff32bf7124.so(+0x97f0b3)[0x7faee84e60b3]
  /lib/x86_64-linux-gnu/libc.so.6(+0x43090)[0x7faee77f2090]
  /checkout/obj/build/x86_64-unknown-linux-gnu/stage1/lib/libLLVM-16-rust-1.70.0-nightly.so(+0x7262e06)[0x7faee608fe06]
  /checkout/obj/build/x86_64-unknown-linux-gnu/stage1/lib/librustc_driver-fdca23ff32bf7124.so(+0xd10ad4)[0x7faee8877ad4]
  /checkout/obj/build/x86_64-unknown-linux-gnu/stage1/lib/librustc_driver-fdca23ff32bf7124.so(+0xbcb6cc)[0x7faee87326cc]
  /checkout/obj/build/x86_64-unknown-linux-gnu/stage1/lib/librustc_driver-fdca23ff32bf7124.so(+0xbca804)[0x7faee8731804]
  /checkout/obj/build/x86_64-unknown-linux-gnu/stage1/lib/librustc_driver-fdca23ff32bf7124.so(_RNvXs5_Cs7DTEPoQIU0M_18rustc_codegen_llvmNtB5_18LlvmCodegenBackendNtNtNtCsiydnvZ3aRh1_17rustc_codegen_ssa6traits7backend14CodegenBackend15target_features+0x1b)[0x7faee879183b]
  /checkout/obj/build/x86_64-unknown-linux-gnu/stage1/lib/librustc_driver-fdca23ff32bf7124.so(_RNvNtCsbMR7lNZiyEF_15rustc_interface4util17add_configuration+0x37)[0x7faee85d38f7]
  /checkout/obj/build/x86_64-unknown-linux-gnu/stage1/lib/librustc_driver-fdca23ff32bf7124.so(_RNvNtCsbMR7lNZiyEF_15rustc_interface4util14create_session+0x89d)[0x7faee85d439d]
  /checkout/obj/build/x86_64-unknown-linux-gnu/stage1/lib/librustc_driver-fdca23ff32bf7124.so(+0x989600)[0x7faee84f0600]
  /checkout/obj/build/x86_64-unknown-linux-gnu/stage1/lib/librustc_driver-fdca23ff32bf7124.so(+0x984380)[0x7faee84eb380]
  /checkout/obj/build/x86_64-unknown-linux-gnu/stage1/lib/librustc_driver-fdca23ff32bf7124.so(+0x985ec3)[0x7faee84ecec3]
  /checkout/obj/build/x86_64-unknown-linux-gnu/stage1/lib/libstd-2268eb07c4da6a07.so(rust_metadata_std_e292dd3bffb96032+0xca4ae)[0x7faee7a6f4ae]
  /lib/x86_64-linux-gnu/libpthread.so.0(+0x8609)[0x7faedec0d609]
  /lib/x86_64-linux-gnu/libc.so.6(clone+0x43)[0x7faee78ce133]
  [RUSTC-TIMING] ___ test:false 0.203
  rustc exited with signal: 11 (SIGSEGV) (core dumped)

r? @ehuss

the8472 · 2023-03-18T22:18:28Z

@bors r+ p=1

bors · 2023-03-18T22:18:30Z

📌 Commit 253a28a26c59ed0c5fbcc6f282eecb9c0dd60a8c has been approved by the8472

It is now in the queue for this repository.

bors · 2023-03-18T22:18:30Z

🌲 The tree is currently closed for pull requests below priority 100. This pull request will be tested once the tree is reopened.

the8472 · 2023-03-18T22:21:46Z

@bors p=100

bors · 2023-03-18T22:21:54Z

⌛ Testing commit 253a28a26c59ed0c5fbcc6f282eecb9c0dd60a8c with merge fba87d696a7fd31dcf564b235f0a890e1841289a...

bors · 2023-03-18T22:29:27Z

💔 Test failed - checks-actions

nikic · 2023-03-18T22:36:57Z

Oh, looks like git revert did not revert the actual submodule update. Applied this manually now.

@bors r=the8472

bors · 2023-03-18T22:36:59Z

📌 Commit b612a926d394b893505ccd8d2fe9e4ab2c989cc4 has been approved by the8472

It is now in the queue for this repository.

bors · 2023-03-18T22:37:07Z

⌛ Testing commit b612a926d394b893505ccd8d2fe9e4ab2c989cc4 with merge 54e311fb4fc2425e1f7e4716285390f5e7b57743...

bors · 2023-03-18T22:41:13Z

💔 Test failed - checks-actions

ehuss · 2023-03-18T22:44:48Z

I would guess you need to bump src/bootstrap/download-ci-llvm-stamp

This reverts commit 4a04d08, reversing changes made to 2d0a7de.

nikic · 2023-03-18T22:51:10Z

Ah, this also reverted the fix to is_ci_llvm_available(), so it wasn't detected as an LLVM update. Next try...

@bors r=the8472

bors · 2023-03-18T22:51:12Z

📌 Commit 4192743 has been approved by the8472

It is now in the queue for this repository.

bors · 2023-03-18T22:51:20Z

⌛ Testing commit 4192743 with merge 5f0d7702b680eba8973ebc2bb48e001296f125d4...

ehuss · 2023-03-18T23:03:08Z

FYI, I'm still getting a SIGSEGV locally with this PR.

the8472 · 2023-03-18T23:04:47Z

The LLVM PR was the last one that succeded though: https://github.com/rust-lang-ci/rust/actions

nikic · 2023-03-18T23:20:16Z

@ehuss That's probably due to #109070. Looks like it works in CI (at least some of the jobs already passed).

bors · 2023-03-18T23:52:11Z

💔 Test failed - checks-actions

compiler-errors · 2023-03-18T23:54:34Z

---- [rustdoc] tests/rustdoc/primitive/no_std.rs stdout ----
thread '[rustdoc] tests/rustdoc/primitive/no_std.rs' panicked at 'called Result::unwrap() on an Err value: Os { code: 22, kind: InvalidInput, message: "Invalid argument" }', src/tools/compiletest/src/runtest.rs:130:43
note: run with RUST_BACKTRACE=1 environment variable to display a backtrace

@bors retry seems like a spurious os error?

bors · 2023-03-18T23:54:42Z

⌛ Testing commit 4192743 with merge ab9bb3e...

the8472 · 2023-03-18T23:56:23Z

Yeah, seems to have happened before: #107504 (comment)

bors · 2023-03-19T02:42:10Z

☀️ Test successful - checks-actions
Approved by: the8472
Pushing ab9bb3e to master...

the8472 · 2023-03-19T02:46:02Z

@bors treeclosed-

rust-timer · 2023-03-19T05:14:06Z

Finished benchmarking commit (ab9bb3e): comparison URL.

Overall result: ❌✅ regressions and improvements - ACTION NEEDED

Next Steps: If you can justify the regressions found in this perf run, please indicate this with @rustbot label: +perf-regression-triaged along with sufficient written justification. If you cannot justify the regressions please open an issue or create a new PR that fixes the regressions, add a comment linking to the newly created issue or PR, and then add the perf-regression-triaged label to this PR.

@rustbot label: +perf-regression
cc @rust-lang/wg-compiler-performance

Instruction count

This is a highly reliable metric that was used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	1.1%	[0.5%, 3.6%]	51
Regressions ❌ (secondary)	1.2%	[0.3%, 4.5%]	67
Improvements ✅ (primary)	-1.2%	[-3.6%, -0.3%]	64
Improvements ✅ (secondary)	-1.1%	[-2.4%, -0.2%]	25
All ❌✅ (primary)	-0.2%	[-3.6%, 3.6%]	115

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	3.1%	[1.6%, 4.1%]	3
Regressions ❌ (secondary)	4.5%	[4.5%, 4.5%]	1
Improvements ✅ (primary)	-1.7%	[-4.3%, -0.4%]	15
Improvements ✅ (secondary)	-3.5%	[-5.9%, -1.7%]	8
All ❌✅ (primary)	-0.9%	[-4.3%, 4.1%]	18

Cycles

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	2.0%	[1.0%, 5.4%]	87
Regressions ❌ (secondary)	3.1%	[1.2%, 11.8%]	43
Improvements ✅ (primary)	-1.9%	[-2.8%, -0.7%]	12
Improvements ✅ (secondary)	-2.2%	[-2.4%, -2.0%]	2
All ❌✅ (primary)	1.5%	[-2.8%, 5.4%]	99

nnethercote · 2023-03-19T05:18:04Z

This is a revert of a recently merged PR, so the overall perf effect of the original PR and this one is nil.

@rustbot label: +perf-regression-triaged

rust-log-analyzer · 2023-03-19T06:17:35Z

The job x86_64-gnu-tools failed! Check out the build log: (web) (plain)

Click to see the possible cause of the failure (guessed by this bot)

Prepare all required actions
Getting action download info
Download action repository 'actions/checkout@v3' (SHA:24cb9080177205b6e8c946b17badbe402adc938f)
Download action repository 'rust-lang/simpleinfra@master' (SHA:3fb2b44a4eaebb9ed8086446bde46c27199ef5ed)
Complete job name: PR (x86_64-gnu-tools, false, ubuntu-20.04-xl)
git config --global core.autocrlf false
shell: /usr/bin/bash --noprofile --norc -e -o pipefail {0}
env:
  CI_JOB_NAME: x86_64-gnu-tools
---
Building stage1 library artifacts (x86_64-unknown-linux-gnu) 
error: failed to run `rustc` to learn about target-specific information

Caused by:
  process didn't exit successfully: `/checkout/obj/build/bootstrap/debug/rustc - --crate-name ___ --print=file-names -Csymbol-mangling-version=legacy -Zunstable-options -Zunstable-options '--check-cfg=values(bootstrap)' '--check-cfg=values(stdarch_intel_sde)' '--check-cfg=values(no_fp_fmt_parse)' '--check-cfg=values(no_global_oom_handling)' '--check-cfg=values(no_rc)' '--check-cfg=values(no_sync)' '--check-cfg=values(freebsd12)' '--check-cfg=values(backtrace_in_libstd)' '--check-cfg=values(target_env,"libnx")' '--check-cfg=values(target_arch,"asmjs","spirv","nvptx","xtensa")' -Zmacro-backtrace -Clink-args=-Wl,-z,origin '-Clink-args=-Wl,-rpath,$ORIGIN/../lib' -Csplit-debuginfo=off -Cprefer-dynamic -Cembed-bitcode=yes '-Zcrate-attr=doc(html_root_url="https://doc.rust-lang.org/nightly/")' --target x86_64-unknown-linux-gnu --crate-type bin --crate-type rlib --crate-type dylib --crate-type cdylib --crate-type staticlib --crate-type proc-macro --print=sysroot --print=split-debuginfo --print=crate-name --print=cfg` (exit status: 254)
  --- stderr
  /checkout/obj/build/x86_64-unknown-linux-gnu/stage1/lib/librustc_driver-fdca23ff32bf7124.so(+0x97cff3)[0x7f41adb9eff3]
  /lib/x86_64-linux-gnu/libc.so.6(+0x42520)[0x7f41ace76520]
  /checkout/obj/build/x86_64-unknown-linux-gnu/stage1/lib/libLLVM-16-rust-1.70.0-nightly.so(+0x7262e06)[0x7f41ab662e06]
  /checkout/obj/build/x86_64-unknown-linux-gnu/stage1/lib/librustc_driver-fdca23ff32bf7124.so(+0xd10d87)[0x7f41adf32d87]
  /checkout/obj/build/x86_64-unknown-linux-gnu/stage1/lib/librustc_driver-fdca23ff32bf7124.so(+0xbc960c)[0x7f41addeb60c]
  /checkout/obj/build/x86_64-unknown-linux-gnu/stage1/lib/librustc_driver-fdca23ff32bf7124.so(+0xbc8744)[0x7f41addea744]
  /checkout/obj/build/x86_64-unknown-linux-gnu/stage1/lib/librustc_driver-fdca23ff32bf7124.so(_RNvXs5_Cs7DTEPoQIU0M_18rustc_codegen_llvmNtB5_18LlvmCodegenBackendNtNtNtCsiydnvZ3aRh1_17rustc_codegen_ssa6traits7backend14CodegenBackend15target_features+0x1b)[0x7f41ade4a77b]
  /checkout/obj/build/x86_64-unknown-linux-gnu/stage1/lib/librustc_driver-fdca23ff32bf7124.so(_RNvNtCsbMR7lNZiyEF_15rustc_interface4util17add_configuration+0x37)[0x7f41adc8c837]
  /checkout/obj/build/x86_64-unknown-linux-gnu/stage1/lib/librustc_driver-fdca23ff32bf7124.so(_RNvNtCsbMR7lNZiyEF_15rustc_interface4util14create_session+0x89d)[0x7f41adc8d2dd]
  /checkout/obj/build/x86_64-unknown-linux-gnu/stage1/lib/librustc_driver-fdca23ff32bf7124.so(+0x987540)[0x7f41adba9540]
  /checkout/obj/build/x86_64-unknown-linux-gnu/stage1/lib/librustc_driver-fdca23ff32bf7124.so(+0x9822c0)[0x7f41adba42c0]
  /checkout/obj/build/x86_64-unknown-linux-gnu/stage1/lib/librustc_driver-fdca23ff32bf7124.so(+0x983e03)[0x7f41adba5e03]
  /checkout/obj/build/x86_64-unknown-linux-gnu/stage1/lib/libstd-2268eb07c4da6a07.so(rust_metadata_std_e292dd3bffb96032+0xca46e)[0x7f41ad12a46e]
  /lib/x86_64-linux-gnu/libc.so.6(+0x94b43)[0x7f41acec8b43]
  /lib/x86_64-linux-gnu/libc.so.6(+0x126a00)[0x7f41acf5aa00]
Build completed unsuccessfully in 0:04:14
  rustc exited with signal: 11 (SIGSEGV) (core dumped)
cat: /tmp/toolstate/toolstates.json: No such file or directory

rust-log-analyzer · 2023-03-19T06:18:31Z

The job x86_64-apple-2 failed! Check out the build log: (web) (plain)

Click to see the possible cause of the failure (guessed by this bot)

      L3 Cache: 12 MB
      Memory: 30 GB
      System Firmware Version: 1.00
      OS Loader Version: 540.120.3~22
      Serial Number (system): C02J5DDCG1HW
      Hardware UUID: 7D97AE97-2EA9-49FC-9EE3-C892277F44C7
      Provisioning UDID: 7D97AE97-2EA9-49FC-9EE3-C892277F44C7
hw.ncpu: 12
hw.byteorder: 1234
hw.memsize: 32212254720
hw.activecpu: 12
---
Some tests failed in compiletest suite=rustdoc mode=rustdoc host=x86_64-apple-darwin target=x86_64-apple-darwin

failures:

---- [rustdoc] tests/rustdoc/primitive/no_std.rs stdout ----
thread '[rustdoc] tests/rustdoc/primitive/no_std.rs' panicked at 'called `Result::unwrap()` on an `Err` value: Os { code: 22, kind: InvalidInput, message: "Invalid argument" }', src/tools/compiletest/src/runtest.rs:130:43


failures:
    [rustdoc] tests/rustdoc/primitive/no_std.rs

rustbot assigned ehuss Mar 18, 2023

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) labels Mar 18, 2023

nikic mentioned this pull request Mar 18, 2023

Upgrade to LLVM 16 #107224

Merged

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 18, 2023

bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Mar 18, 2023

nikic force-pushed the revert-llvm-16 branch from 253a28a to b612a92 Compare March 18, 2023 22:34

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 18, 2023

bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Mar 18, 2023

Revert "Auto merge of rust-lang#107224 - nikic:llvm-16, r=cuviper"

4192743

This reverts commit 4a04d08, reversing changes made to 2d0a7de.

nikic force-pushed the revert-llvm-16 branch from b612a92 to 4192743 Compare March 18, 2023 22:49

bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Mar 18, 2023

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 18, 2023

bors added the merged-by-bors This PR was explicitly merged by bors. label Mar 19, 2023

bors merged commit ab9bb3e into rust-lang:master Mar 19, 2023

rustbot added this to the 1.70.0 milestone Mar 19, 2023

This comment has been minimized.

Sign in to view

rustbot added the perf-regression Performance regression. label Mar 19, 2023

rustbot added the perf-regression-triaged The performance regression has been triaged. label Mar 19, 2023

bkchr mentioned this pull request Mar 19, 2023

Unsupported Wasm Opcode after updating nightly toolchain paritytech/substrate#13636

Closed

2 tasks

WaffleLapkin mentioned this pull request Mar 20, 2023

mv tests/codegen/issue-* tests/codegen/issues/ #109172

Merged

ehuss mentioned this pull request Mar 20, 2023

CI random failure on x86_64-apple-2 InvalidInput in create_dir_all while running test/rustdoc/primitive/no_std.rs #109397

Closed

cuviper mentioned this pull request Mar 24, 2023

Use llvm 16.0.0 instead of 16.0.0-rc4 for build-clang.sh #109561

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Revert "Auto merge of #107224 - nikic:llvm-16, r=cuviper" #109326

Revert "Auto merge of #107224 - nikic:llvm-16, r=cuviper" #109326

nikic commented Mar 18, 2023

the8472 commented Mar 18, 2023

bors commented Mar 18, 2023

bors commented Mar 18, 2023

the8472 commented Mar 18, 2023

bors commented Mar 18, 2023

bors commented Mar 18, 2023

nikic commented Mar 18, 2023

bors commented Mar 18, 2023

bors commented Mar 18, 2023

bors commented Mar 18, 2023

ehuss commented Mar 18, 2023

nikic commented Mar 18, 2023

bors commented Mar 18, 2023

bors commented Mar 18, 2023

ehuss commented Mar 18, 2023

the8472 commented Mar 18, 2023

nikic commented Mar 18, 2023

bors commented Mar 18, 2023

compiler-errors commented Mar 18, 2023

bors commented Mar 18, 2023

the8472 commented Mar 18, 2023

bors commented Mar 19, 2023

the8472 commented Mar 19, 2023

This comment has been minimized.

This comment has been minimized.

rust-timer commented Mar 19, 2023

nnethercote commented Mar 19, 2023

rust-log-analyzer commented Mar 19, 2023

rust-log-analyzer commented Mar 19, 2023

Revert "Auto merge of #107224 - nikic:llvm-16, r=cuviper" #109326

Revert "Auto merge of #107224 - nikic:llvm-16, r=cuviper" #109326

Conversation

nikic commented Mar 18, 2023

the8472 commented Mar 18, 2023

bors commented Mar 18, 2023

bors commented Mar 18, 2023

the8472 commented Mar 18, 2023

bors commented Mar 18, 2023

bors commented Mar 18, 2023

nikic commented Mar 18, 2023

bors commented Mar 18, 2023

bors commented Mar 18, 2023

bors commented Mar 18, 2023

ehuss commented Mar 18, 2023

nikic commented Mar 18, 2023

bors commented Mar 18, 2023

bors commented Mar 18, 2023

ehuss commented Mar 18, 2023

the8472 commented Mar 18, 2023

nikic commented Mar 18, 2023

bors commented Mar 18, 2023

compiler-errors commented Mar 18, 2023

bors commented Mar 18, 2023

the8472 commented Mar 18, 2023

bors commented Mar 19, 2023

the8472 commented Mar 19, 2023

This comment has been minimized.

This comment has been minimized.

rust-timer commented Mar 19, 2023

Overall result: ❌✅ regressions and improvements - ACTION NEEDED

Instruction count

Max RSS (memory usage)

Cycles

nnethercote commented Mar 19, 2023

rust-log-analyzer commented Mar 19, 2023

rust-log-analyzer commented Mar 19, 2023