Rollup of 11 pull requests #109275
Closed
Rollup of 11 pull requests #109275
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Print at least the Some/None/Ok/Err status of the nested bindings if not the bindings themselves.
Co-authored-by: Waffle Maybe <waffle.lapkin@gmail.com>
…-lt-binder, r=jackh726 Erase escaping late-bound regions when probing for ambiguous associated types Fixes rust-lang#109090
…er-errors Add revisions for -Zlower-impl-trait-in-trait-to-assoc-ty fixed tests Needs to go on top of rust-lang#109198 r? `@compiler-errors`
…ffleLapkin Fix index out of bounds in `suggest_trait_fn_ty_for_impl_fn_infer` Fixes rust-lang#109191
…tion, r=WaffleLapkin E0206 - update description added `union` to description
…trochenkov Do not ICE for unexpected lifetime with ConstGeneric rib Fixes rust-lang#109143 r? ``@petrochenkov`` Combining this test with the previous test will affect the previous diagnostics, so I added a separate test case.
fallback to lstat when stat fails on Windows Fixes rust-lang#109106 ``@ChrisDenton`` please let me know if this is the expected behavior for stat on windows
…=WaffleLapkin Pass the right HIR back from `get_fn_decl` Fixes rust-lang#109232 Makes sure that the `fn_id: HirId` that we pass to `suggest_missing_return_type` matches up with the `fn_decl: hir::FnDecl` that we pass to it, so the late-bound vars that we fetch from the former match up with the types in the latter... This HIR suggestion code really needs a big refactor. I've tried to do it in the past (a couple of attempts), but it's a super tangled mess. It really shouldn't be passing around things like `hir::Node` and just deal with `LocalDefId`s everywhere... Anyways, I'd rather fix this ICE, now.
Suggest surrounding the macro with `{}` to interpret as a statement
Fixes rust-lang#109237
…san68 Check for llvm-tools before install Fixes rust-lang#108948 ``@jpalus`` Please review
resolve: Improve debug impls for `NameBinding` Print at least the Some/None/Ok/Err status of the nested bindings if not the bindings themselves. Noticed while reviewing rust-lang#108729.
…-inlining, r=notriddle rustdoc: Fix missing private inlining Fixes rust-lang#109258. If the item isn't inlined, it shouldn't have been added into `view_item_stack`. The problem here was that it was not removed, preventing sub items to be inlined if they have a re-export in "upper levels". cc ``@epage`` r? ``@notriddle``
rustbot
added
S-waiting-on-review
rustbot
added
T-compiler
|
@bors r+ rollup=never p=11 |
bors
added
S-waiting-on-bors
|
uff, I think something is wrong and weird again with my PR. @bors r- |
bors
added
S-waiting-on-author
|
The job Click to see the possible cause of the failure (guessed by this bot) |
|
@spastorino hm, maybe its a weird interaction with a different pr in the rollup? |
in case you are curious, it was just my mistake. Lots of different branches with very similar things that each one worked on top of the previous one. After rebasing one added test started to fail and I think it's just fixed by a different PR that's not yet merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Successful merges:
suggest_trait_fn_ty_for_impl_fn_infer#109200 (Fix index out of bounds insuggest_trait_fn_ty_for_impl_fn_infer)get_fn_decl#109248 (Pass the right HIR back fromget_fn_decl){}to interpret as a statement #109251 (Suggest surrounding the macro with{}to interpret as a statement)NameBinding#109257 (resolve: Improve debug impls forNameBinding)Failed merges:
r? @ghost
@rustbot modify labels: rollup
Create a similar rollup